diff mbox series

[v2,5/5] configure: allow the selection of alternate config in the build

Message ID 20210707131744.26027-6-alex.bennee@linaro.org
State New
Headers show
Series custom device configs | expand

Commit Message

Alex Bennée July 7, 2021, 1:17 p.m. UTC 
While the default config works well enough it does end up enabling a
lot of stuff. For more minimal builds we can select a different list
of devices and let Kconfig work out what we want. For example:

  ../../configure --without-default-features \
    --target-list=arm-softmmu,aarch64-softmmu \
    --with-devices-aarch64=minimal

will override the aarch64-softmmu default set of devices with a more
minimal set of devices that just enables the virt and sbsa-ref models.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20210621152120.4465-6-alex.bennee@linaro.org>

---
v2
  - fix ws
---
 configure                                   | 24 ++++++++++++++++++++-
 configs/devices/aarch64-softmmu/minimal.mak |  9 ++++++++
 meson.build                                 |  3 ++-
 3 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 configs/devices/aarch64-softmmu/minimal.mak

-- 
2.20.1

Comments

Richard Henderson July 7, 2021, 3:16 p.m. UTC | #1 
On 7/7/21 6:17 AM, Alex Bennée wrote:
> While the default config works well enough it does end up enabling a

> lot of stuff. For more minimal builds we can select a different list

> of devices and let Kconfig work out what we want. For example:

> 

>    ../../configure --without-default-features \

>      --target-list=arm-softmmu,aarch64-softmmu \

>      --with-devices-aarch64=minimal

> 

> will override the aarch64-softmmu default set of devices with a more

> minimal set of devices that just enables the virt and sbsa-ref models.

> 

> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>

> Cc: Philippe Mathieu-Daudé<philmd@redhat.com>

> Cc: Paolo Bonzini<pbonzini@redhat.com>

> Message-Id:<20210621152120.4465-6-alex.bennee@linaro.org>


I guess I can just follow the shell scripting.  It's a shame we can't just put together 
the properties section contents while we're parsing the command-line, and instead have to 
break it up into N variables.

> +  # unroll any custom device configs

> +  if test -n "$device_archs"; then

> +      for a in $device_archs; do

> +          eval "c=\$devices_${a}"

> +          echo "${a}-softmmu = '$c'" >> $cross

> +      done

> +  fi


Do you really need the IF around the FOR?  Shouldn't the loop iterate zero times if 
$device_archs is empty?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>



r~
diff mbox series

Patch

diff --git a/configure b/configure
index 0ed451d9a0..d3942b78e3 100755
--- a/configure
+++ b/configure
@@ -915,6 +915,18 @@  for opt do
   ;;
   --without-default-devices) default_devices="false"
   ;;
+  --with-devices-*[!a-zA-Z0-9_-]*=*) error_exit "Passed bad --with-devices-FOO option"
+  ;;
+  --with-devices-*) device_arch=${opt#--with-devices-};
+                    device_arch=${device_arch%%=*}
+                    cf=$source_path/configs/devices/$device_arch-softmmu/$optarg.mak
+                    if test -f "$cf"; then
+                        device_archs="$device_archs $device_arch"
+                        eval "devices_${device_arch}=\$optarg"
+                    else
+                        error_exit "File $cf does not exist"
+                    fi
+  ;;
   --without-default-features) # processed above
   ;;
   --enable-gprof) gprof="yes"
@@ -1764,7 +1776,8 @@  Advanced options (experts only):
   --without-default-features default all --enable-* options to "disabled"
   --without-default-devices  do not include any device that is not needed to
                            start the emulator (only use if you are including
-                           desired devices in default-configs/devices/)
+                           desired devices in configs/devices/)
+  --with-devices-ARCH=NAME override default configs/devices
   --enable-debug           enable common debug build options
   --enable-sanitizers      enable default sanitizers
   --enable-tsan            enable thread sanitizer
@@ -5088,6 +5101,15 @@  if test "$skip_meson" = no; then
 
   echo "# Automatically generated by configure - do not modify" > $cross
   echo "[properties]" >> $cross
+
+  # unroll any custom device configs
+  if test -n "$device_archs"; then
+      for a in $device_archs; do
+          eval "c=\$devices_${a}"
+          echo "${a}-softmmu = '$c'" >> $cross
+      done
+  fi
+
   test -z "$cxx" && echo "link_language = 'c'" >> $cross
   echo "[built-in options]" >> $cross
   echo "c_args = [${CFLAGS:+$(meson_quote $CFLAGS)}]" >> $cross
diff --git a/configs/devices/aarch64-softmmu/minimal.mak b/configs/devices/aarch64-softmmu/minimal.mak
new file mode 100644
index 0000000000..0ebc1dca56
--- /dev/null
+++ b/configs/devices/aarch64-softmmu/minimal.mak
@@ -0,0 +1,9 @@ 
+#
+# A minimal version of the config that only supports only a few
+# virtual machines. This avoids bringing in any of numerous legacy
+# features from the 32bit platform (although virt still supports 32bit
+# itself)
+#
+
+CONFIG_ARM_VIRT=y
+CONFIG_SBSA_REF=y
diff --git a/meson.build b/meson.build
index 283b4d12af..563dddd2b3 100644
--- a/meson.build
+++ b/meson.build
@@ -1584,9 +1584,10 @@  foreach target : target_dirs
                                                configuration: config_target_data)}
 
   if target.endswith('-softmmu')
+    config_input = meson.get_external_property(target, 'default')
     config_devices_mak = target + '-config-devices.mak'
     config_devices_mak = configure_file(
-      input: ['configs/devices' / target / 'default.mak', 'Kconfig'],
+      input: ['configs/devices' / target / config_input + '.mak', 'Kconfig'],
       output: config_devices_mak,
       depfile: config_devices_mak + '.d',
       capture: true,