| Message ID | 20210614202842.581640-1-mathieu.poirier@linaro.org |
|---|---|
| Headers | show |
| Series | virtio: Add vhost-user based RNG | expand |
On Mon, Jun 14, 2021 at 02:28:37PM -0600, Mathieu Poirier wrote: > This sets adds a vhost-user based random number generator (RNG), > similar to what has been done for i2c and virtiofsd, with the > implementation following the patterns already set forth in those. > > Applies cleanly to git://git.qemu.org/qemu.git master(1ea06abceec6). I get /scm/qemu/docs/tools/vhost-user-rng.rst:document isn't included in any toctree any idea? > Thanks, > Mathieu > > ----- > New for V2: > - Replaced "antropy" for "entropy" (Joakim). > > Mathieu Poirier (5): > vhost-user-rng: Add vhost-user-rng implementation > vhost-user-rng-pci: Add vhost-user-rng-pci implementation > vhost-user-rng: backend: Add RNG vhost-user daemon implementation > docs: Add documentation for vhost based RNG implementation > MAINTAINERS: Add maintainer for vhost-user RNG implementation > > MAINTAINERS | 9 + > docs/tools/vhost-user-rng.rst | 74 +++++ > hw/virtio/Kconfig | 5 + > hw/virtio/meson.build | 2 + > hw/virtio/vhost-user-rng-pci.c | 79 +++++ > hw/virtio/vhost-user-rng.c | 294 +++++++++++++++++ > include/hw/virtio/vhost-user-rng.h | 33 ++ > tools/meson.build | 8 + > tools/vhost-user-rng/50-qemu-rng.json.in | 5 + > tools/vhost-user-rng/main.c | 403 +++++++++++++++++++++++ > tools/vhost-user-rng/meson.build | 10 + > 11 files changed, 922 insertions(+) > create mode 100644 docs/tools/vhost-user-rng.rst > create mode 100644 hw/virtio/vhost-user-rng-pci.c > create mode 100644 hw/virtio/vhost-user-rng.c > create mode 100644 include/hw/virtio/vhost-user-rng.h > create mode 100644 tools/vhost-user-rng/50-qemu-rng.json.in > create mode 100644 tools/vhost-user-rng/main.c > create mode 100644 tools/vhost-user-rng/meson.build > > -- > 2.25.1
Good day Michael, On Fri, Jul 02, 2021 at 12:27:08PM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 14, 2021 at 02:28:37PM -0600, Mathieu Poirier wrote: > > This sets adds a vhost-user based random number generator (RNG), > > similar to what has been done for i2c and virtiofsd, with the > > implementation following the patterns already set forth in those. > > > > Applies cleanly to git://git.qemu.org/qemu.git master(1ea06abceec6). > > > I get > > /scm/qemu/docs/tools/vhost-user-rng.rst:document isn't included in any toctree > I assume this is because vhost-user-rng isn't listed in docs/tools/index.rst but I would like to test my theory before sending another revision. What build command did you use to generate this? I tried "make html" and "make man" as shown in the Documenation section of "make help" but those targets don't seem to be valid anymore. Thanks, Mathieu > any idea? > > > Thanks, > > Mathieu > > > > ----- > > New for V2: > > - Replaced "antropy" for "entropy" (Joakim). > > > > Mathieu Poirier (5): > > vhost-user-rng: Add vhost-user-rng implementation > > vhost-user-rng-pci: Add vhost-user-rng-pci implementation > > vhost-user-rng: backend: Add RNG vhost-user daemon implementation > > docs: Add documentation for vhost based RNG implementation > > MAINTAINERS: Add maintainer for vhost-user RNG implementation > > > > MAINTAINERS | 9 + > > docs/tools/vhost-user-rng.rst | 74 +++++ > > hw/virtio/Kconfig | 5 + > > hw/virtio/meson.build | 2 + > > hw/virtio/vhost-user-rng-pci.c | 79 +++++ > > hw/virtio/vhost-user-rng.c | 294 +++++++++++++++++ > > include/hw/virtio/vhost-user-rng.h | 33 ++ > > tools/meson.build | 8 + > > tools/vhost-user-rng/50-qemu-rng.json.in | 5 + > > tools/vhost-user-rng/main.c | 403 +++++++++++++++++++++++ > > tools/vhost-user-rng/meson.build | 10 + > > 11 files changed, 922 insertions(+) > > create mode 100644 docs/tools/vhost-user-rng.rst > > create mode 100644 hw/virtio/vhost-user-rng-pci.c > > create mode 100644 hw/virtio/vhost-user-rng.c > > create mode 100644 include/hw/virtio/vhost-user-rng.h > > create mode 100644 tools/vhost-user-rng/50-qemu-rng.json.in > > create mode 100644 tools/vhost-user-rng/main.c > > create mode 100644 tools/vhost-user-rng/meson.build > > > > -- > > 2.25.1 >
On Tue, Jul 06, 2021 at 02:20:57PM -0600, Mathieu Poirier wrote: > Good day Michael, > > On Fri, Jul 02, 2021 at 12:27:08PM -0400, Michael S. Tsirkin wrote: > > On Mon, Jun 14, 2021 at 02:28:37PM -0600, Mathieu Poirier wrote: > > > This sets adds a vhost-user based random number generator (RNG), > > > similar to what has been done for i2c and virtiofsd, with the > > > implementation following the patterns already set forth in those. > > > > > > Applies cleanly to git://git.qemu.org/qemu.git master(1ea06abceec6). > > > > > > I get > > > > /scm/qemu/docs/tools/vhost-user-rng.rst:document isn't included in any toctree > > > > I assume this is because vhost-user-rng isn't listed in > docs/tools/index.rst but I would like to test my theory before sending another > revision. What build command did you use to generate this? I tried "make html" > and "make man" as shown in the Documenation section of "make help" but those > targets don't seem to be valid anymore. > > Thanks, > Mathieu I just used configure then make. So this is why the patches got dropped from the pull request. I remember now. > > any idea? > > > > > Thanks, > > > Mathieu > > > > > > ----- > > > New for V2: > > > - Replaced "antropy" for "entropy" (Joakim). > > > > > > Mathieu Poirier (5): > > > vhost-user-rng: Add vhost-user-rng implementation > > > vhost-user-rng-pci: Add vhost-user-rng-pci implementation > > > vhost-user-rng: backend: Add RNG vhost-user daemon implementation > > > docs: Add documentation for vhost based RNG implementation > > > MAINTAINERS: Add maintainer for vhost-user RNG implementation > > > > > > MAINTAINERS | 9 + > > > docs/tools/vhost-user-rng.rst | 74 +++++ > > > hw/virtio/Kconfig | 5 + > > > hw/virtio/meson.build | 2 + > > > hw/virtio/vhost-user-rng-pci.c | 79 +++++ > > > hw/virtio/vhost-user-rng.c | 294 +++++++++++++++++ > > > include/hw/virtio/vhost-user-rng.h | 33 ++ > > > tools/meson.build | 8 + > > > tools/vhost-user-rng/50-qemu-rng.json.in | 5 + > > > tools/vhost-user-rng/main.c | 403 +++++++++++++++++++++++ > > > tools/vhost-user-rng/meson.build | 10 + > > > 11 files changed, 922 insertions(+) > > > create mode 100644 docs/tools/vhost-user-rng.rst > > > create mode 100644 hw/virtio/vhost-user-rng-pci.c > > > create mode 100644 hw/virtio/vhost-user-rng.c > > > create mode 100644 include/hw/virtio/vhost-user-rng.h > > > create mode 100644 tools/vhost-user-rng/50-qemu-rng.json.in > > > create mode 100644 tools/vhost-user-rng/main.c > > > create mode 100644 tools/vhost-user-rng/meson.build > > > > > > -- > > > 2.25.1 > >