mbox series

[0/6] spi: stm32: various fixes & cleanup

Message ID 1625042723-661-1-git-send-email-alain.volmat@foss.st.com
Headers show
Series spi: stm32: various fixes & cleanup | expand

Message

Alain Volmat June 30, 2021, 8:45 a.m. UTC
This series contains fixes & cleanup mainly regarding fifo
and the way end of transfer triggered, when used with or
without DMA.
An additional patch cleans up the pm_runtime calls.

Alain Volmat (5):
  spi: stm32: fixes pm_runtime calls in probe/remove
  spi: stm32h7: fix full duplex irq handler handling
  Revert "spi: stm32: properly handle 0 byte transfer"
  spi: stm32h7: don't wait for EOT and flush fifo on disable
  spi: stm32: finalize message either on dma callback or EOT

Amelie Delaunay (1):
  spi: stm32h7: rework rx fifo read function

 drivers/spi/spi-stm32.c | 146 +++++++++++++++++-----------------------
 1 file changed, 61 insertions(+), 85 deletions(-)

Comments

Amelie DELAUNAY June 30, 2021, 10:10 a.m. UTC | #1
On 6/30/21 10:45 AM, Alain Volmat wrote:
> This series contains fixes & cleanup mainly regarding fifo
> and the way end of transfer triggered, when used with or
> without DMA.
> An additional patch cleans up the pm_runtime calls.
> 
> Alain Volmat (5):
>    spi: stm32: fixes pm_runtime calls in probe/remove
>    spi: stm32h7: fix full duplex irq handler handling
>    Revert "spi: stm32: properly handle 0 byte transfer"
>    spi: stm32h7: don't wait for EOT and flush fifo on disable
>    spi: stm32: finalize message either on dma callback or EOT
> 
> Amelie Delaunay (1):
>    spi: stm32h7: rework rx fifo read function
> 
>   drivers/spi/spi-stm32.c | 146 +++++++++++++++++-----------------------
>   1 file changed, 61 insertions(+), 85 deletions(-)
> 

For the whole series,

Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>

Thanks Alain!

Regards,
Amelie
Mark Brown June 30, 2021, 12:34 p.m. UTC | #2
On Wed, Jun 30, 2021 at 10:45:18AM +0200, Alain Volmat wrote:

> +	pm_runtime_set_autosuspend_delay(&pdev->dev,
> +					 STM32_SPI_AUTOSUSPEND_DELAY);
> +	pm_runtime_use_autosuspend(&pdev->dev);

The driver wasn't using autosuspend at all prior to this patch so
there's no fix from that part of the change, the enabling of autosuspend
ought to be split out into a separate patch.