[v2,22/28] target/s390x: Use translator_use_goto_tb

Message ID	20210630183226.3290849-23-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH v2 22/28] target/s390x: Use translator_use_goto_tb Date: Wed, 30 Jun 2021 11:32:20 -0700 Message-Id: <20210630183226.3290849-23-richard.henderson@linaro.org> In-Reply-To: <20210630183226.3290849-1-richard.henderson@linaro.org> References: <20210630183226.3290849-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Cc: David Hildenbrand <david@redhat.com> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	accel/tcg: Introduce translator_use_goto_tb \| expand [v2,00/28] accel/tcg: Introduce translator_use_goto_tb [v2,01/28] accel/tcg: Introduce translator_use_goto_tb [v2,02/28] target/alpha: Remove use_exit_tb [v2,03/28] target/alpha: Remove in_superpage [v2,04/28] target/alpha: Use translator_use_goto_tb [v2,05/28] target/arm: Use gen_jmp for ISB and SB [v2,06/28] target/arm: Use translator_use_goto_tb for aarch64 [v2,07/28] target/arm: Use translator_use_goto_tb for aarch32 [v2,08/28] target/avr: Use translator_use_goto_tb [v2,09/28] target/avr: Mark some helpers noreturn [v2,10/28] target/cris: Use translator_use_goto_tb [v2,11/28] target/hppa: Use translator_use_goto_tb [v2,12/28] target/i386: Use translator_use_goto_tb [v2,13/28] target/m68k: Use translator_use_goto_tb [v2,14/28] target/microblaze: Use translator_use_goto_tb [v2,15/28] target/mips: Use translator_use_goto_tb [v2,16/28] target/mips: Fix missing else in gen_goto_tb [v2,17/28] target/nios2: Use translator_use_goto_tb [v2,18/28] target/openrisc: Use translator_use_goto_tb [v2,19/28] target/ppc: Use translator_use_goto_tb [v2,20/28] target/riscv: Use translator_use_goto_tb [v2,21/28] target/rx: Use translator_use_goto_tb [v2,22/28] target/s390x: Use translator_use_goto_tb [v2,23/28] target/s390x: Remove use_exit_tb [v2,24/28] target/sh4: Use translator_use_goto_tb [v2,25/28] target/sparc: Use translator_use_goto_tb [v2,26/28] target/tricore: Use translator_use_goto_tb [v2,27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr [v2,28/28] target/xtensa: Use translator_use_goto_tb

Message ID

20210630183226.3290849-23-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 22/28] target/s390x: Use translator_use_goto_tb
Date: Wed, 30 Jun 2021 11:32:20 -0700
Message-Id: <20210630183226.3290849-23-richard.henderson@linaro.org>
In-Reply-To: <20210630183226.3290849-1-richard.henderson@linaro.org>
References: <20210630183226.3290849-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::102c;
	envelope-from=richard.henderson@linaro.org;
	helo=mail-pj1-x102c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
	DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
	RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
	SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: David Hildenbrand <david@redhat.com>
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

accel/tcg: Introduce translator_use_goto_tb | expand

Cc: David Hildenbrand <david@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/s390x/translate.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.25.1

Comments

David Hildenbrand July 1, 2021, 7:42 a.m. UTC | #1

On 30.06.21 20:32, Richard Henderson wrote:
> Cc: David Hildenbrand <david@redhat.com>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   target/s390x/translate.c | 7 +------

>   1 file changed, 1 insertion(+), 6 deletions(-)

> 

> diff --git a/target/s390x/translate.c b/target/s390x/translate.c

> index 03dab9f350..117a890ecd 100644

> --- a/target/s390x/translate.c

> +++ b/target/s390x/translate.c

> @@ -697,12 +697,7 @@ static bool use_goto_tb(DisasContext *s, uint64_t dest)

>       if (unlikely(use_exit_tb(s))) {

>           return false;

>       }

> -#ifndef CONFIG_USER_ONLY

> -    return (dest & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK) ||

> -           (dest & TARGET_PAGE_MASK) == (s->base.pc_next & TARGET_PAGE_MASK);

> -#else

> -    return true;

> -#endif

> +    return translator_use_goto_tb(&s->base, dest);

>   }

>   

>   static void account_noninline_branch(DisasContext *s, int cc_op)

> 


Reviewed-by: David Hildenbrand <david@redhat.com>


-- 
Thanks,

David / dhildenb

diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 03dab9f350..117a890ecd 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -697,12 +697,7 @@  static bool use_goto_tb(DisasContext *s, uint64_t dest)
     if (unlikely(use_exit_tb(s))) {
         return false;
     }
-#ifndef CONFIG_USER_ONLY
-    return (dest & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK) ||
-           (dest & TARGET_PAGE_MASK) == (s->base.pc_next & TARGET_PAGE_MASK);
-#else
-    return true;
-#endif
+    return translator_use_goto_tb(&s->base, dest);
 }
 
 static void account_noninline_branch(DisasContext *s, int cc_op)

[v2,22/28] target/s390x: Use translator_use_goto_tb

Commit Message

Comments

Patch