| Message ID | 20210628191719.2823947-1-clabbe@baylibre.com |
|---|---|
| State | New |
| Headers | show |
| Series | leds: remove ide-disk trigger | expand |
On 28.06.21 21:17, Corentin Labbe wrote: > diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c > index 0741910785bb..38a5c21c0466 100644 > --- a/drivers/leds/trigger/ledtrig-disk.c > +++ b/drivers/leds/trigger/ledtrig-disk.c > @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void) > led_trigger_register_simple("disk-activity", &ledtrig_disk); > led_trigger_register_simple("disk-read", &ledtrig_disk_read); > led_trigger_register_simple("disk-write", &ledtrig_disk_write); > - led_trigger_register_simple("ide-disk", &ledtrig_ide); > > return 0; > } Shouldn't this line also be removed ? DEFINE_LED_TRIGGER(ledtrig_ide); --mtx
Le Tue, Jun 29, 2021 at 12:47:27PM +0200, Enrico Weigelt, metux IT consult a écrit : > On 28.06.21 21:17, Corentin Labbe wrote: > > > diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c > > index 0741910785bb..38a5c21c0466 100644 > > --- a/drivers/leds/trigger/ledtrig-disk.c > > +++ b/drivers/leds/trigger/ledtrig-disk.c > > @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void) > > led_trigger_register_simple("disk-activity", &ledtrig_disk); > > led_trigger_register_simple("disk-read", &ledtrig_disk_read); > > led_trigger_register_simple("disk-write", &ledtrig_disk_write); > > - led_trigger_register_simple("ide-disk", &ledtrig_ide); > > > > return 0; > > } > > Shouldn't this line also be removed ? > > DEFINE_LED_TRIGGER(ledtrig_ide); > Yes, I will send a v2. Thanks
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index a9b8c21779e3..2d3d4af1d35e 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -91,9 +91,6 @@ properties: - disk-activity - disk-read - disk-write - # LED indicates IDE disk activity (deprecated), in new implementations - # use "disk-activity" - - ide-disk # LED flashes at a fixed, configurable rate - timer # LED alters the brightness for the specified duration with one software diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c index 0741910785bb..38a5c21c0466 100644 --- a/drivers/leds/trigger/ledtrig-disk.c +++ b/drivers/leds/trigger/ledtrig-disk.c @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void) led_trigger_register_simple("disk-activity", &ledtrig_disk); led_trigger_register_simple("disk-read", &ledtrig_disk_read); led_trigger_register_simple("disk-write", &ledtrig_disk_write); - led_trigger_register_simple("ide-disk", &ledtrig_ide); return 0; }
No user of ide-disk remains, so remove this deprecated trigger. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- Documentation/devicetree/bindings/leds/common.yaml | 3 --- drivers/leds/trigger/ledtrig-disk.c | 1 - 2 files changed, 4 deletions(-)