| Message ID | 20210622151608.23741-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Commit | cd5c91fe62519af6af238bbead32f2943a85c7de |
| Headers | show |
| Series | crypto: qat: ratelimit invalid ioctl message and print the invalid cmd | expand |
On Tue, Jun 22, 2021 at 04:16:08PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently incorrect QAT ioctls can spam the kernel log with error messages > of the form "QAT: Invalid ioctl" if a userspace program uses the wrong > ioctl command. Quench the messages by ratelimiting them and also print > the invalid command being used as that is useful to know. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Just a minor comment on the commit message: crypto: qat: ratelimit invalid ioctl message and print ^ Patches to the qat driver have the following headline: crypto: qat - not crypto: qat: Apart from that Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> Regards, -- Giovanni
On Tue, Jun 22, 2021 at 04:16:08PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently incorrect QAT ioctls can spam the kernel log with error messages > of the form "QAT: Invalid ioctl" if a userspace program uses the wrong > ioctl command. Quench the messages by ratelimiting them and also print > the invalid command being used as that is useful to know. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c index 96b437bfe3de..6f64aa693146 100644 --- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c +++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c @@ -406,7 +406,7 @@ static long adf_ctl_ioctl(struct file *fp, unsigned int cmd, unsigned long arg) ret = adf_ctl_ioctl_get_status(fp, cmd, arg); break; default: - pr_err("QAT: Invalid ioctl\n"); + pr_err_ratelimited("QAT: Invalid ioctl %d\n", cmd); ret = -EFAULT; break; }