| Message ID | 20210504135209.4757-1-bjorn.ardo@axis.com |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: slave-eeprom: add an of_match_table | expand |
On Tue, May 04, 2021 at 03:52:09PM +0200, Björn Ardö wrote: > This is needed since commit af503716ac14 ("i2c: core: report OF style > module alias for devices registered via OF"). > > Signed-off-by: Björn Ardö <bjorn.ardo@axis.com> I'm afraid we need a YAML file, too. checkpatch says: WARNING: DT compatible string "linux,slave-24c02" appears un-documented -- check ./Documentation/devicetree/bindings/
Hi, This is missing for the entire module, so maybe then it should be added for the existing DT-API as a separate patch and then this patch can just add the things it is actually adding to the API? Or do you think it should be included here? /BA On 6/26/21 12:31 PM, Wolfram Sang wrote: > On Tue, May 04, 2021 at 03:52:09PM +0200, Björn Ardö wrote: >> This is needed since commit af503716ac14 ("i2c: core: report OF style >> module alias for devices registered via OF"). >> >> Signed-off-by: Björn Ardö <bjorn.ardo@axis.com> > I'm afraid we need a YAML file, too. checkpatch says: > > WARNING: DT compatible string "linux,slave-24c02" appears un-documented -- check ./Documentation/devicetree/bindings/ >
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c index 5c7ae421cacf..89274b72b369 100644 --- a/drivers/i2c/i2c-slave-eeprom.c +++ b/drivers/i2c/i2c-slave-eeprom.c @@ -204,9 +204,23 @@ static const struct i2c_device_id i2c_slave_eeprom_id[] = { }; MODULE_DEVICE_TABLE(i2c, i2c_slave_eeprom_id); +static const struct of_device_id i2c_slave_eeprom_match[] = { + { .compatible = "linux,slave-24c02", }, + { .compatible = "linux,slave-24c02ro", }, + { .compatible = "linux,slave-24c32", }, + { .compatible = "linux,slave-24c32ro", }, + { .compatible = "linux,slave-24c64", }, + { .compatible = "linux,slave-24c64ro", }, + { .compatible = "linux,slave-24c512", }, + { .compatible = "linux,slave-24c512ro", }, + { } +}; +MODULE_DEVICE_TABLE(of, i2c_slave_eeprom_match); + static struct i2c_driver i2c_slave_eeprom_driver = { .driver = { .name = "i2c-slave-eeprom", + .of_match_table = i2c_slave_eeprom_match, }, .probe = i2c_slave_eeprom_probe, .remove = i2c_slave_eeprom_remove,
This is needed since commit af503716ac14 ("i2c: core: report OF style module alias for devices registered via OF"). Signed-off-by: Björn Ardö <bjorn.ardo@axis.com> --- drivers/i2c/i2c-slave-eeprom.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)