[07/26] target/avr: Mark some helpers noreturn

Message ID	20210621013439.1791385-8-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH 07/26] target/avr: Mark some helpers noreturn Date: Sun, 20 Jun 2021 18:34:20 -0700 Message-Id: <20210621013439.1791385-8-richard.henderson@linaro.org> In-Reply-To: <20210621013439.1791385-1-richard.henderson@linaro.org> References: <20210621013439.1791385-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Cc: Michael Rolnik <mrolnik@gmail.com> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	accel/tcg: Introduce translator_use_goto_tb \| expand [00/26] accel/tcg: Introduce translator_use_goto_tb [01/26] accel/tcg: Introduce translator_use_goto_tb [02/26] target/alpha: Remove use_exit_tb [03/26] target/alpha: Remove in_superpage [04/26] target/alpha: Use translator_use_goto_tb [05/26] target/arm: Use translator_use_goto_tb [06/26] target/avr: Use translator_use_goto_tb [07/26] target/avr: Mark some helpers noreturn [08/26] target/cris: Use translator_use_goto_tb [09/26] target/hppa: Use translator_use_goto_tb [10/26] target/i386: Use translator_use_goto_tb [11/26] target/m68k: Use translator_use_goto_tb [12/26] target/microblaze: Use translator_use_goto_tb [13/26] target/mips: Use translator_use_goto_tb [14/26] target/mips: Fix missing else in gen_goto_tb [15/26] target/nios2: Use translator_use_goto_tb [16/26] target/openrisc: Use translator_use_goto_tb [17/26] target/ppc: Use translator_use_goto_tb [18/26] target/riscv: Use translator_use_goto_tb [19/26] target/rx: Use translator_use_goto_tb [20/26] target/s390x: Use translator_use_goto_tb [21/26] target/s390x: Remove use_exit_tb [22/26] target/sh4: Use translator_use_goto_tb [23/26] target/sparc: Use translator_use_goto_tb [24/26] target/tricore: Use translator_use_goto_tb [25/26] target/tricore: Use tcg_gen_lookup_and_goto_ptr [26/26] target/xtensa: Use translator_use_goto_tb

Message ID

20210621013439.1791385-8-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	209.51.188.17 as permitted sender) client-ip=209.51.188.17; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 07/26] target/avr: Mark some helpers noreturn
Date: Sun, 20 Jun 2021 18:34:20 -0700
Message-Id: <20210621013439.1791385-8-richard.henderson@linaro.org>
In-Reply-To: <20210621013439.1791385-1-richard.henderson@linaro.org>
References: <20210621013439.1791385-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::62a;
	envelope-from=richard.henderson@linaro.org;
	helo=mail-pl1-x62a.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
	DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
	RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
	SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: Michael Rolnik <mrolnik@gmail.com>
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

accel/tcg: Introduce translator_use_goto_tb | expand

Commit Message

Richard Henderson June 21, 2021, 1:34 a.m. UTC

All of these helpers end with cpu_loop_exit.

Cc: Michael Rolnik <mrolnik@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/avr/helper.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.25.1

Comments

Michael Rolnik June 21, 2021, 5:39 a.m. UTC | #1

Reviewed-by: Michael Rolnik <mrolnik@gmail.com>



On Mon, Jun 21, 2021 at 4:34 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> All of these helpers end with cpu_loop_exit.

>

> Cc: Michael Rolnik <mrolnik@gmail.com>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  target/avr/helper.h | 8 ++++----

>  1 file changed, 4 insertions(+), 4 deletions(-)

>

> diff --git a/target/avr/helper.h b/target/avr/helper.h

> index 8e1ae7fda0..4d02e648fa 100644

> --- a/target/avr/helper.h

> +++ b/target/avr/helper.h

> @@ -19,10 +19,10 @@

>   */

>

>  DEF_HELPER_1(wdr, void, env)

> -DEF_HELPER_1(debug, void, env)

> -DEF_HELPER_1(break, void, env)

> -DEF_HELPER_1(sleep, void, env)

> -DEF_HELPER_1(unsupported, void, env)

> +DEF_HELPER_1(debug, noreturn, env)

> +DEF_HELPER_1(break, noreturn, env)

> +DEF_HELPER_1(sleep, noreturn, env)

> +DEF_HELPER_1(unsupported, noreturn, env)

>  DEF_HELPER_3(outb, void, env, i32, i32)

>  DEF_HELPER_2(inb, tl, env, i32)

>  DEF_HELPER_3(fullwr, void, env, i32, i32)

> --

> 2.25.1

>

>


-- 
Best Regards,
Michael Rolnik
<div dir="ltr">Reviewed-by: Michael Rolnik &lt;<a href="mailto:mrolnik@gmail.com">mrolnik@gmail.com</a>&gt;<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 21, 2021 at 4:34 AM Richard Henderson &lt;<a href="mailto:richard.henderson@linaro.org">richard.henderson@linaro.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">All of these helpers end with cpu_loop_exit.<br>
<br>
Cc: Michael Rolnik &lt;<a href="mailto:mrolnik@gmail.com" target="_blank">mrolnik@gmail.com</a>&gt;<br>
Signed-off-by: Richard Henderson &lt;<a href="mailto:richard.henderson@linaro.org" target="_blank">richard.henderson@linaro.org</a>&gt;<br>

---<br>
 target/avr/helper.h | 8 ++++----<br>
 1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/target/avr/helper.h b/target/avr/helper.h<br>
index 8e1ae7fda0..4d02e648fa 100644<br>
--- a/target/avr/helper.h<br>
+++ b/target/avr/helper.h<br>
@@ -19,10 +19,10 @@<br>
  */<br>
<br>
 DEF_HELPER_1(wdr, void, env)<br>
-DEF_HELPER_1(debug, void, env)<br>
-DEF_HELPER_1(break, void, env)<br>
-DEF_HELPER_1(sleep, void, env)<br>
-DEF_HELPER_1(unsupported, void, env)<br>
+DEF_HELPER_1(debug, noreturn, env)<br>
+DEF_HELPER_1(break, noreturn, env)<br>
+DEF_HELPER_1(sleep, noreturn, env)<br>
+DEF_HELPER_1(unsupported, noreturn, env)<br>
 DEF_HELPER_3(outb, void, env, i32, i32)<br>
 DEF_HELPER_2(inb, tl, env, i32)<br>
 DEF_HELPER_3(fullwr, void, env, i32, i32)<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Best Regards,<br>Michael Rolnik</div>

Philippe Mathieu-Daudé June 21, 2021, 12:31 p.m. UTC | #2

On 6/21/21 3:34 AM, Richard Henderson wrote:
> All of these helpers end with cpu_loop_exit.

> 

> Cc: Michael Rolnik <mrolnik@gmail.com>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  target/avr/helper.h | 8 ++++----

>  1 file changed, 4 insertions(+), 4 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

diff --git a/target/avr/helper.h b/target/avr/helper.h
index 8e1ae7fda0..4d02e648fa 100644
--- a/target/avr/helper.h
+++ b/target/avr/helper.h
@@ -19,10 +19,10 @@ 
  */
 
 DEF_HELPER_1(wdr, void, env)
-DEF_HELPER_1(debug, void, env)
-DEF_HELPER_1(break, void, env)
-DEF_HELPER_1(sleep, void, env)
-DEF_HELPER_1(unsupported, void, env)
+DEF_HELPER_1(debug, noreturn, env)
+DEF_HELPER_1(break, noreturn, env)
+DEF_HELPER_1(sleep, noreturn, env)
+DEF_HELPER_1(unsupported, noreturn, env)
 DEF_HELPER_3(outb, void, env, i32, i32)
 DEF_HELPER_2(inb, tl, env, i32)
 DEF_HELPER_3(fullwr, void, env, i32, i32)

[07/26] target/avr: Mark some helpers noreturn

Commit Message

Comments

Patch