| Message ID | 20210522171609.299611-1-caleb@connolly.tech |
|---|---|
| State | New |
| Headers | show |
| Series | ath10k: demote chan info without scan request warning | expand |
Caleb Connolly <caleb@connolly.tech> wrote: > Some devices/firmwares cause this to be printed every 5-15 seconds, > though it has no impact on functionality. Demote this to a debug > message. > > Signed-off-by: Caleb Connolly <caleb@connolly.tech> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> On what hardware and firmware version do you see this?
Hi Kalle, On 12/06/2021 11:36 am, Kalle Valo wrote: > Caleb Connolly <caleb@connolly.tech> wrote: > >> Some devices/firmwares cause this to be printed every 5-15 seconds, >> though it has no impact on functionality. Demote this to a debug >> message. >> >> Signed-off-by: Caleb Connolly <caleb@connolly.tech> >> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Is this meant to be an Ack? > > On what hardware and firmware version do you see this? I see this on SDM845 and MSM8998 platforms, specifically the OnePlus 6 devices, PocoPhone F1 and OnePlus 5. On the OnePlus 6 (SDM845) we are stuck with the following signed vendor fw: [ 9.339873] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001 [ 9.339897] ath10k_snoc 18800000.wifi: qmi fw_version 0x20060029 fw_build_timestamp 2019-07-12 02:14 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c8-00041-QCAHLSWMTPLZ-1 The OnePlus 5 (MSM8998) is using firmware: [ 6096.956799] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40010002 [ 6096.956824] ath10k_snoc 18800000.wifi: qmi fw_version 0x1007007e fw_build_timestamp 2020-04-14 22:45 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.c6-00126-QCAHLSWMTPLZ-1.211883.1.278648. > > -- > https://patchwork.kernel.org/project/linux-wireless/patch/20210522171609.299611-1-caleb@connolly.tech/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches > -- Kind Regards, Caleb
Caleb Connolly <caleb@connolly.tech> wrote: > Some devices/firmwares cause this to be printed every 5-15 seconds, > though it has no impact on functionality. Demote this to a debug > message. > > I see this on SDM845 and MSM8998 platforms, specifically the OnePlus 6 devices, > PocoPhone F1 and OnePlus 5. On the OnePlus 6 (SDM845) we are stuck with the > following signed vendor fw: > > [ 9.339873] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001 > [ 9.339897] ath10k_snoc 18800000.wifi: qmi fw_version 0x20060029 fw_build_timestamp 2019-07-12 02:14 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c8-00041-QCAHLSWMTPLZ-1 > > The OnePlus 5 (MSM8998) is using firmware: > > [ 6096.956799] ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40010002 > [ 6096.956824] ath10k_snoc 18800000.wifi: qmi fw_version 0x1007007e fw_build_timestamp 2020-04-14 22:45 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.c6-00126-QCAHLSWMTPLZ-1.211883.1.278648. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.2.0.c8-00041-QCAHLSWMTPLZ-1 > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.1.0.c6-00126-QCAHLSWMTPLZ-1.211883.1.278648 > > Signed-off-by: Caleb Connolly <caleb@connolly.tech> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 8a952a955de7 ath10k: demote chan info without scan request warning
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index d48b922215eb..6c69f7ef0546 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2795,7 +2795,7 @@ void ath10k_wmi_event_chan_info(struct ath10k *ar, struct sk_buff *skb) switch (ar->scan.state) { case ATH10K_SCAN_IDLE: case ATH10K_SCAN_STARTING: - ath10k_warn(ar, "received chan info event without a scan request, ignoring\n"); + ath10k_dbg(ar, ATH10K_DBG_WMI, "received chan info event without a scan request, ignoring\n"); goto exit; case ATH10K_SCAN_RUNNING: case ATH10K_SCAN_ABORTING:
Some devices/firmwares cause this to be printed every 5-15 seconds, though it has no impact on functionality. Demote this to a debug message. Signed-off-by: Caleb Connolly <caleb@connolly.tech> --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1