diff mbox series

dt-bindings: mtd: gpmc: Fix the ECC bytes vs. OOB bytes equation

Message ID 20210610143945.3504781-1-miquel.raynal@bootlin.com
State Accepted
Commit 778cb8e39f6ec252be50fc3850d66f3dcbd5dd5a
Headers show
Series dt-bindings: mtd: gpmc: Fix the ECC bytes vs. OOB bytes equation | expand

Commit Message

Miquel Raynal June 10, 2021, 2:39 p.m. UTC
"PAGESIZE / 512" is the number of ECC chunks.
"ECC_BYTES" is the number of bytes needed to store a single ECC code.
"2" is the space reserved by the bad block marker.

"2 + (PAGESIZE / 512) * ECC_BYTES" should of course be lower or equal
than the total number of OOB bytes, otherwise it won't fit.

Fix the equation by substituting s/>=/<=/.

Suggested-by: Ryan J. Barnett <ryan.barnett@collins.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 Documentation/devicetree/bindings/mtd/gpmc-nand.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring (Arm) June 18, 2021, 9:19 p.m. UTC | #1
On Thu, 10 Jun 2021 16:39:45 +0200, Miquel Raynal wrote:
> "PAGESIZE / 512" is the number of ECC chunks.

> "ECC_BYTES" is the number of bytes needed to store a single ECC code.

> "2" is the space reserved by the bad block marker.

> 

> "2 + (PAGESIZE / 512) * ECC_BYTES" should of course be lower or equal

> than the total number of OOB bytes, otherwise it won't fit.

> 

> Fix the equation by substituting s/>=/<=/.

> 

> Suggested-by: Ryan J. Barnett <ryan.barnett@collins.com>

> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---

>  Documentation/devicetree/bindings/mtd/gpmc-nand.txt | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 


Acked-by: Rob Herring <robh@kernel.org>
Miquel Raynal July 15, 2021, 11:08 p.m. UTC | #2
On Thu, 2021-06-10 at 14:39:45 UTC, Miquel Raynal wrote:
> "PAGESIZE / 512" is the number of ECC chunks.

> "ECC_BYTES" is the number of bytes needed to store a single ECC code.

> "2" is the space reserved by the bad block marker.

> 

> "2 + (PAGESIZE / 512) * ECC_BYTES" should of course be lower or equal

> than the total number of OOB bytes, otherwise it won't fit.

> 

> Fix the equation by substituting s/>=/<=/.

> 

> Suggested-by: Ryan J. Barnett <ryan.barnett@collins.com>

> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

> Acked-by: Rob Herring <robh@kernel.org>


Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next.

Miquel
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
index 44919d48d241..c459f169a904 100644
--- a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
+++ b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
@@ -122,7 +122,7 @@  on various other factors also like;
 	so the device should have enough free bytes available its OOB/Spare
 	area to accommodate ECC for entire page. In general following expression
 	helps in determining if given device can accommodate ECC syndrome:
-	"2 + (PAGESIZE / 512) * ECC_BYTES" >= OOBSIZE"
+	"2 + (PAGESIZE / 512) * ECC_BYTES" <= OOBSIZE"
 	where
 		OOBSIZE		number of bytes in OOB/spare area
 		PAGESIZE	number of bytes in main-area of device page