| Message ID | 1623837686-22569-1-git-send-email-liweihang@huawei.com |
|---|---|
| Headers | show |
| Series | net: phy: fix some coding-style issues | expand |
On Wed, Jun 16, 2021 at 06:01:21PM +0800, Weihang Li wrote: > From: Wenpeng Liang <liangwenpeng@huawei.com> > > There are some repeated words in some comments, they should be deleted. > > Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com> > Signed-off-by: Weihang Li <liweihang@huawei.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Wed, Jun 16, 2021 at 06:01:23PM +0800, Weihang Li wrote: > From: Wenpeng Liang <liangwenpeng@huawei.com> > > Fix following format issues: > 1. open brace '{' following function definitions should go to the next > line. > 2. braces {} are not necessary for single line statements. > 3. else should follow close brace '}'. > > Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com> > Signed-off-by: Weihang Li <liweihang@huawei.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 16 Jun 2021 18:01:18 +0800 you wrote: > Make some cleanups according to the coding style of kernel. > > Changes since v1: > - Update commit description of #1 and #3. > - Avoid changing the indentation in #2. > - Change a group of if-else statement into switch from #4 and put it into > a single patch. > - Put '|' at the end of line in #5 and #7. > - Avoid deleting spaces in definition of 'settings' in #5. > - Drop #8 from the series which needs more discussion with David. > > [...] Here is the summary with links: - [v2,net-next,1/8] net: phy: change format of some declarations https://git.kernel.org/netdev/net-next/c/775f25479df9 - [v2,net-next,2/8] net: phy: correct format of block comments https://git.kernel.org/netdev/net-next/c/1953feb02215 - [v2,net-next,3/8] net: phy: delete repeated words of comments https://git.kernel.org/netdev/net-next/c/e1f82127d67f - [v2,net-next,4/8] net: phy: fix space alignment issues https://git.kernel.org/netdev/net-next/c/3bdee6a8e92e - [v2,net-next,5/8] net: phy: fix formatting issues with braces https://git.kernel.org/netdev/net-next/c/169d7a402dfa - [v2,net-next,6/8] net: phy: print the function name by __func__ instead of an fixed string https://git.kernel.org/netdev/net-next/c/450bf1f0c60e - [v2,net-next,7/8] net: phy: remove unnecessary line continuation https://git.kernel.org/netdev/net-next/c/33ab463220e5 - [v2,net-next,8/8] net: phy: replace if-else statements with switch https://git.kernel.org/netdev/net-next/c/16d4d650966d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Make some cleanups according to the coding style of kernel. Changes since v1: - Update commit description of #1 and #3. - Avoid changing the indentation in #2. - Change a group of if-else statement into switch from #4 and put it into a single patch. - Put '|' at the end of line in #5 and #7. - Avoid deleting spaces in definition of 'settings' in #5. - Drop #8 from the series which needs more discussion with David. Weihang Li (1): net: phy: replace if-else statements with switch Wenpeng Liang (7): net: phy: change format of some declarations net: phy: correct format of block comments net: phy: delete repeated words of comments net: phy: fix space alignment issues net: phy: fix formatting issues with braces net: phy: print the function name by __func__ instead of an fixed string net: phy: remove unnecessary line continuation drivers/net/phy/bcm87xx.c | 4 ++-- drivers/net/phy/davicom.c | 6 +++--- drivers/net/phy/dp83640.c | 5 +++-- drivers/net/phy/et1011c.c | 15 ++++++++------- drivers/net/phy/fixed_phy.c | 4 ++-- drivers/net/phy/lxt.c | 4 ++-- drivers/net/phy/marvell.c | 13 +++++++++---- drivers/net/phy/mdio_bus.c | 1 + drivers/net/phy/mdio_device.c | 4 ++-- drivers/net/phy/national.c | 6 ++++-- drivers/net/phy/phy-c45.c | 2 +- drivers/net/phy/phy-core.c | 3 ++- drivers/net/phy/phy.c | 3 +-- drivers/net/phy/phy_device.c | 9 ++++----- drivers/net/phy/phylink.c | 14 ++++++++------ drivers/net/phy/qsemi.c | 1 + drivers/net/phy/sfp-bus.c | 28 ++++++++++++++-------------- drivers/net/phy/sfp.c | 2 +- drivers/net/phy/spi_ks8995.c | 10 +++++----- drivers/net/phy/ste10Xp.c | 6 +++--- drivers/net/phy/vitesse.c | 3 ++- 21 files changed, 78 insertions(+), 65 deletions(-)