| Message ID | cover.1622628333.git.matti.vaittinen@fi.rohmeurope.com |
|---|---|
| Headers | show |
| Series | Extend regulator notification support | expand |
On Thu, Jun 03, 2021 at 08:40:07AM +0300, Matti Vaittinen wrote: > Extend regulator notification support > > This series extends the regulator notification and error flag support. > Initial discussion on the topic can be found here: > https://lore.kernel.org/lkml/6046836e22b8252983f08d5621c35ececb97820d.camel@fi.rohmeurope.com/ Any thoughts on the reboot or thermal patches? In the absence of any further feedback by the end of the week I might go ahead and apply things to the regulator tree if that's OK with people.
On 03/06/2021 07:40, Matti Vaittinen wrote: > There can be few cases when we need to shut-down the system in order to > protect the hardware. Currently this is done at least by the thermal core > when temperature raises over certain limit. > > Some PMICs can also generate interrupts for example for over-current or > over-voltage, voltage drops, short-circuit, ... etc. On some systems > these are a sign of hardware failure and only thing to do is try to > protect the rest of the hardware by shutting down the system. > > Add shut-down logic which can be used by all subsystems instead of > implementing the shutdown in each subsystem. The logic is stolen from > thermal_core with difference of using atomic_t instead of a mutex in > order to allow calls directly from IRQ context and changing the WARN() > to pr_emerg() as discussed here: > https://lore.kernel.org/lkml/YJuPwAZroVZ%2Fw633@alley/ > and here: > https://lore.kernel.org/linux-iommu/20210331093104.383705-4-geert+renesas@glider.be/ > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
On Thu, 3 Jun 2021 08:40:07 +0300, Matti Vaittinen wrote: > Extend regulator notification support > > This series extends the regulator notification and error flag support. > Initial discussion on the topic can be found here: > https://lore.kernel.org/lkml/6046836e22b8252983f08d5621c35ececb97820d.camel@fi.rohmeurope.com/ > > In a nutshell - the series adds: > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [01/11] dt_bindings: Add protection limit properties commit: 673e851b7da81256e73fb738c550ec39bac1c9ff [02/11] reboot: Add hardware protection power-off commit: dfa19b11385d4cf8f0242fd93e2073e25183c331 [03/11] thermal: Use generic HW-protection shutdown API commit: db0aeb4f074f7023da26fb65078197c39590346b [04/11] regulator: add warning flags commit: e6c3092d43faf0aa095160cc552f8c05490d0962 [05/11] regulator: move rdev_print helpers to internal.h commit: 157d2230193ae683fcffcc1cd0a2c3aa4479955f [06/11] regulator: IRQ based event/error notification helpers commit: 7111c6d1b31b42c8c758f6681e895a5116e3bad6 [07/11] regulator: add property parsing and callbacks to set protection limits commit: 89a6a5e56c8248a077d12424a1383a6b18ea840b [08/11] dt-bindings: regulator: bd9576 add FET ON-resistance for OCW commit: 627793e4ca4f511837de893545baf0e1b8174dc2 [09/11] regulator: bd9576: Support error reporting commit: e7bf1fa58c46db9f72220c4472272d6da0a54c91 [10/11] regulator: bd9576: Fix the driver name in id table commit: e71e7d3df7eb712fc29b609bd712a63d60b81b5f [11/11] MAINTAINERS: Add reviewer for regulator irq_helpers commit: d55444adedaee5a3024c61637032057fcf38491b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Extend regulator notification support This series extends the regulator notification and error flag support. Initial discussion on the topic can be found here: https://lore.kernel.org/lkml/6046836e22b8252983f08d5621c35ececb97820d.camel@fi.rohmeurope.com/ In a nutshell - the series adds: 1. WARNING level events/error flags. (Patch 3) Current regulator 'ERROR' event notifications for over/under voltage, over current and over temperature are used to indicate condition where monitored entity is so badly "off" that it actually indicates a hardware error which can not be recovered. The most typical hanling for that is believed to be a (graceful) system-shutdown. Here we add set of 'WARNING' level flags to allow sending notifications to consumers before things are 'that badly off' so that consumer drivers can implement recovery-actions. 2. Device-tree properties for specifying limit values. (Patches 1, 5) Add limits for above mentioned 'ERROR' and 'WARNING' levels (which send notifications to consumers) and also for a 'PROTECTION' level (which will be used to immediately shut-down the regulator(s) W/O informing consumer drivers. Typically implemented by hardware). Property parsing is implemented in regulator core which then calls callback operations for limit setting from the IC drivers. A warning is emitted if protection is requested by device tree but the underlying IC does not support configuring requested protection. 3. Helpers which can be registered by IC. (Patch 4) Target is to avoid implementing IRQ handling and IRQ storm protection in each IC driver. (Many of the ICs implementin these IRQs do not allow masking or acking the IRQ but keep the IRQ asserted for the whole duration of problem keeping the processor in IRQ handling loop). 4. Emergency poweroff function (refactored out of the thermal_core to kernel/reboot.c) which is called if IC fires error IRQs but IC reading fails and given retry-count is exceeded. (Patches 2, 4) Please note that the mutex in the emergency shutdown was replaced by a simple atomic in order to allow call from any context. The helper was attempted to be done so it could be used to implement roughly same logic as is used in qcom-labibb regulator. This means amongst other things a safety shut-down if IC registers are not readable. Using these shut-down retry counters are optional. The idea is that the helper could be also used by simpler ICs which do not provide status register(s) which can be used to check if error is still active. ICs which do not have such status register can simply omit the 'renable' callback (and retry-counts etc) - and helper assumes the situation is Ok and re-enables IRQ after given time period. If problem persists the handler is ran again and another notification is sent - but at least the delay allows processor to avoid IRQ loop. Patch 7 takes this notification support in use at BD9576MUF. Patch 8 is related to MFD change which is not really related to the RFC here. It was added to this series in order to avoid potential conflicts. Patch 9 adds a maintainers entry. Changelog v10-RESEND: - rebased on v5.13-rc4 Changelog v10: - rebased on v5.13-rc2 - Move rdev_*() print macros to the internal.h and use rdev_dbg() from irq_helpers.c - Export rdev_get_name() and move it from coupler.h to driver.h for others to use. (It was already in coupler.h but not exported - usage was limited and coupler.h does not sound like optimal place as rdev_name is not only used by coupled regulators) - Send all regulator notifications from irq_helpers.c at one OR'd event for the sake of simplicity. For BD9576 this does not matter as it has own IRQ for each event case. Header defining events says they may be OR'd. - Change WARN() at protection shutdown to pr_emerg as suggested by Petr. Changelog v9: - rebases on v5.13-rc1 - Update thermal documentation - Fix regulator notification event number Changelog v8: - split shutdown API adding and thermal core taking it in use to own patches. - replace the spinlock with atomic when ensuring the emergency shutdown is only called once. Changelog v7: general: - rebased on v5.12-rc7 - new patch for refactoring the hw-failure reboot logic out of thermal_core.c for others to use. notification helpers: - fix regulator error_flags query - grammar/typos - do not BUG() but attempt to shut-down the system - use BITS_PER_TYPE() Changelog v6: Add MAINTAINERS entry Changes to IRQ notifiers - move devm functions to drivers/regulator/devres.c - drop irq validity check - use devm_add_action_or_reset() - fix styling issues - fix kerneldocs Changelog v5: - Fix the badly formatted pr_emerg() call. Changelog v4: - rebased on v5.12-rc6 - dropped RFC - fix external FET DT-binding. - improve prints for cases when expecting HW failure. - styling and typos Changelog v3: Regulator core: - Fix dangling pointer access at regulator_irq_helper() stpmic1_regulator: - fix function prototype (compile error) bd9576-regulator: - Update over current limits to what was given in new data-sheet (REV00K) - Allow over-current monitoring without external FET. Set limits to values given in data-sheet (REV00K). Changelog v2: Generic: - rebase on v5.12-rc2 + BD9576 series - Split devm variant of delayed wq to own series Regulator framework: - Provide non devm variant of IRQ notification helpers - shorten dt-property names as suggested by Rob - unconditionally call map_event in IRQ handling and require it to be populated BD9576 regulators: - change the FET resistance property to micro-ohms - fix voltage computation in OC limit setting -- Matti Vaittinen (11): dt_bindings: Add protection limit properties reboot: Add hardware protection power-off thermal: Use generic HW-protection shutdown API regulator: add warning flags regulator: move rdev_print helpers to internal.h regulator: IRQ based event/error notification helpers regulator: add property parsing and callbacks to set protection limits dt-bindings: regulator: bd9576 add FET ON-resistance for OCW regulator: bd9576: Support error reporting regulator: bd9576: Fix the driver name in id table MAINTAINERS: Add reviewer for regulator irq_helpers .../bindings/regulator/regulator.yaml | 82 ++ .../regulator/rohm,bd9576-regulator.yaml | 6 + .../driver-api/thermal/sysfs-api.rst | 24 +- MAINTAINERS | 4 + drivers/regulator/Makefile | 2 +- drivers/regulator/bd9576-regulator.c | 1054 +++++++++++++++-- drivers/regulator/core.c | 163 ++- drivers/regulator/devres.c | 52 + drivers/regulator/internal.h | 11 + drivers/regulator/irq_helpers.c | 397 +++++++ drivers/regulator/of_regulator.c | 58 + drivers/regulator/qcom-labibb-regulator.c | 10 +- drivers/regulator/qcom_spmi-regulator.c | 6 +- drivers/regulator/stpmic1_regulator.c | 20 +- drivers/thermal/thermal_core.c | 63 +- include/linux/reboot.h | 1 + include/linux/regulator/consumer.h | 14 + include/linux/regulator/coupler.h | 5 - include/linux/regulator/driver.h | 186 ++- include/linux/regulator/machine.h | 26 + kernel/reboot.c | 79 ++ 21 files changed, 2030 insertions(+), 233 deletions(-) create mode 100644 drivers/regulator/irq_helpers.c base-commit: 8124c8a6b35386f73523d27eacb71b5364a68c4c