mbox series

[net-next,0/2] Support ethtool ntuple rule count change

Message ID 1623847882-16744-1-git-send-email-sgoutham@marvell.com
Headers show
Series Support ethtool ntuple rule count change | expand

Message

Sunil Kovvuri Goutham June 16, 2021, 12:51 p.m. UTC
From: Sunil Goutham <sgoutham@marvell.com>

Some NICs share resources like packet filters across
multiple interfaces they support. From HW point of view
it is possible to use all filters for a single interface.
This 2 patch series adds support to modify ntuple rule
count for OcteonTx2 netdev.

Sunil Goutham (2):
  net: ethtool: Support setting ntuple rule count
  octeontx2-pf: Support setting ntuple rule count

 .../ethernet/marvell/octeontx2/nic/otx2_common.h   |  1 +
 .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c  |  3 +++
 .../ethernet/marvell/octeontx2/nic/otx2_flows.c    | 27 ++++++++++++++++++++--
 include/uapi/linux/ethtool.h                       |  1 +
 net/ethtool/ioctl.c                                |  1 +
 5 files changed, 31 insertions(+), 2 deletions(-)

Comments

Jakub Kicinski June 16, 2021, 5:57 p.m. UTC | #1
On Wed, 16 Jun 2021 18:21:21 +0530 sgoutham@marvell.com wrote:
> From: Sunil Goutham <sgoutham@marvell.com>
> 
> Some NICs share resources like packet filters across
> multiple interfaces they support. From HW point of view
> it is possible to use all filters for a single interface.
> Currently ethtool doesn't support modifying filter count so
> that user can allocate more filters to a interface and less
> to others. This patch adds ETHTOOL_SRXCLSRLCNT ioctl command
> for modifying filter count.
> 
> example command:
> ./ethtool -U eth0 rule-count 256

man devlink-resource ?
Sunil Kovvuri Goutham June 17, 2021, 1:16 p.m. UTC | #2
> -----Original Message-----

> From: Jakub Kicinski <kuba@kernel.org>

> Sent: Wednesday, June 16, 2021 11:28 PM

> To: Sunil Kovvuri Goutham <sgoutham@marvell.com>

> Cc: davem@davemloft.net; netdev@vger.kernel.org

> Subject: [EXT] Re: [PATCH net-next 1/2] net: ethtool: Support setting ntuple

> rule count

> 

> External Email

> 

> ----------------------------------------------------------------------

> On Wed, 16 Jun 2021 18:21:21 +0530 sgoutham@marvell.com wrote:

> > From: Sunil Goutham <sgoutham@marvell.com>

> >

> > Some NICs share resources like packet filters across multiple

> > interfaces they support. From HW point of view it is possible to use

> > all filters for a single interface.

> > Currently ethtool doesn't support modifying filter count so that user

> > can allocate more filters to a interface and less to others. This

> > patch adds ETHTOOL_SRXCLSRLCNT ioctl command for modifying filter

> > count.

> >

> > example command:

> > ./ethtool -U eth0 rule-count 256

> 

> man devlink-resource ?


Since ntuple rule insert and delete are part of ethtool, I thought having this config also in
ethtool will make user life easy ie all ntuple related stuff within one tool.

Thanks,
Sunil.
Sunil Kovvuri Goutham June 22, 2021, 5:34 p.m. UTC | #3
> -----Original Message-----

> From: Sunil Kovvuri Goutham

> Sent: Thursday, June 17, 2021 6:46 PM

> To: Jakub Kicinski <kuba@kernel.org>

> Cc: davem@davemloft.net; netdev@vger.kernel.org

> Subject: RE: [EXT] Re: [PATCH net-next 1/2] net: ethtool: Support setting

> ntuple rule count

> 

> 

> 

> > -----Original Message-----

> > From: Jakub Kicinski <kuba@kernel.org>

> > Sent: Wednesday, June 16, 2021 11:28 PM

> > To: Sunil Kovvuri Goutham <sgoutham@marvell.com>

> > Cc: davem@davemloft.net; netdev@vger.kernel.org

> > Subject: [EXT] Re: [PATCH net-next 1/2] net: ethtool: Support setting

> > ntuple rule count

> >

> > External Email

> >

> > ----------------------------------------------------------------------

> > On Wed, 16 Jun 2021 18:21:21 +0530 sgoutham@marvell.com wrote:

> > > From: Sunil Goutham <sgoutham@marvell.com>

> > >

> > > Some NICs share resources like packet filters across multiple

> > > interfaces they support. From HW point of view it is possible to use

> > > all filters for a single interface.

> > > Currently ethtool doesn't support modifying filter count so that

> > > user can allocate more filters to a interface and less to others.

> > > This patch adds ETHTOOL_SRXCLSRLCNT ioctl command for modifying

> > > filter count.

> > >

> > > example command:

> > > ./ethtool -U eth0 rule-count 256

> >

> > man devlink-resource ?

> 

> Since ntuple rule insert and delete are part of ethtool, I thought having this

> config also in ethtool will make user life easy ie all ntuple related stuff within

> one tool.

> 

> Thanks,

> Sunil.


Any further feedback or objections to these change ?

Thanks,
Sunil.