| Message ID | 20210606222817.12388-6-digetx@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,1/5] soc/tegra: fuse: Add stubs needed for compile testing | expand |
Hi Dmitry,
I love your patch! Yet something to improve:
[auto build test ERROR on tegra/for-next]
[also build test ERROR on next-20210615]
[cannot apply to pm/linux-next daniel.lezcano/clockevents/next v5.13-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/Compile-test-NVIDIA-Tegra-CPUIDLE-driver/20210607-063217
base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm-randconfig-r005-20210616 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/53a9ab1dfd605ffae44d67f01a07a18b8ecbb1be
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Osipenko/Compile-test-NVIDIA-Tegra-CPUIDLE-driver/20210607-063217
git checkout 53a9ab1dfd605ffae44d67f01a07a18b8ecbb1be
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arm-linux-gnueabi-ld: arch/arm/kernel/sleep.o: in function `__cpu_suspend':
>> (.text+0x68): undefined reference to `cpu_sa110_suspend_size'
arm-linux-gnueabi-ld: arch/arm/kernel/suspend.o: in function `__cpu_suspend_save':
>> suspend.c:(.text+0x118): undefined reference to `cpu_sa110_do_suspend'
>> arm-linux-gnueabi-ld: suspend.c:(.text+0x13c): undefined reference to `cpu_sa110_do_resume'
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on ARCH_SUSPEND_POSSIBLE
Selected by
- ARM_TEGRA_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_TEGRA || COMPILE_TEST && !ARM64
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
16.06.2021 10:37, kernel test robot пишет: > Hi Dmitry, > > I love your patch! Yet something to improve: > > [auto build test ERROR on tegra/for-next] > [also build test ERROR on next-20210615] > [cannot apply to pm/linux-next daniel.lezcano/clockevents/next v5.13-rc6] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/Compile-test-NVIDIA-Tegra-CPUIDLE-driver/20210607-063217 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next > config: arm-randconfig-r005-20210616 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/53a9ab1dfd605ffae44d67f01a07a18b8ecbb1be > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Dmitry-Osipenko/Compile-test-NVIDIA-Tegra-CPUIDLE-driver/20210607-063217 > git checkout 53a9ab1dfd605ffae44d67f01a07a18b8ecbb1be > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > arm-linux-gnueabi-ld: arch/arm/kernel/sleep.o: in function `__cpu_suspend': >>> (.text+0x68): undefined reference to `cpu_sa110_suspend_size' > arm-linux-gnueabi-ld: arch/arm/kernel/suspend.o: in function `__cpu_suspend_save': >>> suspend.c:(.text+0x118): undefined reference to `cpu_sa110_do_suspend' >>> arm-linux-gnueabi-ld: suspend.c:(.text+0x13c): undefined reference to `cpu_sa110_do_resume' I can't find where cpu_sa110_do_resume is specified in kernel. > Kconfig warnings: (for reference only) > WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND > Depends on ARCH_SUSPEND_POSSIBLE > Selected by > - ARM_TEGRA_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_TEGRA || COMPILE_TEST && !ARM64 There are other Kconfig.arm entries that are compile-tested and select ARM_CPU_SUSPEND. Do they get the same warning? Should I do something about it?
16.06.2021 22:24, Dmitry Osipenko пишет: > 16.06.2021 10:37, kernel test robot пишет: >> Hi Dmitry, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on tegra/for-next] >> [also build test ERROR on next-20210615] >> [cannot apply to pm/linux-next daniel.lezcano/clockevents/next v5.13-rc6] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/Compile-test-NVIDIA-Tegra-CPUIDLE-driver/20210607-063217 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next >> config: arm-randconfig-r005-20210616 (attached as .config) >> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://github.com/0day-ci/linux/commit/53a9ab1dfd605ffae44d67f01a07a18b8ecbb1be >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Dmitry-Osipenko/Compile-test-NVIDIA-Tegra-CPUIDLE-driver/20210607-063217 >> git checkout 53a9ab1dfd605ffae44d67f01a07a18b8ecbb1be >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All errors (new ones prefixed by >>): >> >> arm-linux-gnueabi-ld: arch/arm/kernel/sleep.o: in function `__cpu_suspend': >>>> (.text+0x68): undefined reference to `cpu_sa110_suspend_size' >> arm-linux-gnueabi-ld: arch/arm/kernel/suspend.o: in function `__cpu_suspend_save': >>>> suspend.c:(.text+0x118): undefined reference to `cpu_sa110_do_suspend' >>>> arm-linux-gnueabi-ld: suspend.c:(.text+0x13c): undefined reference to `cpu_sa110_do_resume' > > I can't find where cpu_sa110_do_resume is specified in kernel. > >> Kconfig warnings: (for reference only) >> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND >> Depends on ARCH_SUSPEND_POSSIBLE >> Selected by >> - ARM_TEGRA_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_TEGRA || COMPILE_TEST && !ARM64 > > There are other Kconfig.arm entries that are compile-tested and select > ARM_CPU_SUSPEND. Do they get the same warning? Should I do something > about it? Although, I see now that the other entries have dependencies which should protect them indirectly from this warning. Perhaps adding dependency on MMU, like QCOM driver does it, should help. I'll fix it in the next version.
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm index 334f83e56120..98f8ee6b3552 100644 --- a/drivers/cpuidle/Kconfig.arm +++ b/drivers/cpuidle/Kconfig.arm @@ -99,7 +99,7 @@ config ARM_MVEBU_V7_CPUIDLE config ARM_TEGRA_CPUIDLE bool "CPU Idle Driver for NVIDIA Tegra SoCs" - depends on ARCH_TEGRA && !ARM64 + depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND help
Enable compile testing of tegra-cpuidle driver. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/cpuidle/Kconfig.arm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)