| Message ID | 20210614130118.20395-1-oleksandr.mazur@plvision.eu |
|---|---|
| Headers | show |
| Series | Marvell Prestera driver implementation of devlink functionality. | expand |
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 14 Jun 2021 16:01:11 +0300 you wrote: > This patch series implement Prestera Switchdev driver devlink traps, > that are registered within the driver, as well as extend current devlink > functionality by adding new hard drop statistics counter, that could be > retrieved on-demand: the counter shows number of packets that have been > dropped by the underlying device and haven't been passed to the devlink > subsystem. > > [...] Here is the summary with links: - [net-next,v2,1/7] net: core: devlink: add dropped stats traps field https://git.kernel.org/netdev/net-next/c/ddee9dbc3d7a - [net-next,v2,2/7] testing: selftests: net: forwarding: add devlink-required functionality to test (hard) dropped stats field https://git.kernel.org/netdev/net-next/c/53f1bd6b2819 - [net-next,v2,3/7] drivers: net: netdevsim: add devlink trap_drop_counter_get implementation https://git.kernel.org/netdev/net-next/c/a7b3527a43fe - [net-next,v2,4/7] testing: selftests: drivers: net: netdevsim: devlink: add test case for hard drop statistics https://git.kernel.org/netdev/net-next/c/7a4f54798a53 - [net-next,v2,5/7] net: marvell: prestera: devlink: add traps/groups implementation https://git.kernel.org/netdev/net-next/c/0a9003f45e91 - [net-next,v2,6/7] net: marvell: prestera: devlink: add traps with DROP action https://git.kernel.org/netdev/net-next/c/a80cf955c9e5 - [net-next,v2,7/7] documentation: networking: devlink: add prestera switched driver Documentation https://git.kernel.org/netdev/net-next/c/66826c43e63d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On Mon, Jun 14, 2021 at 04:01:14PM +0300, Oleksandr Mazur wrote: > + debugfs_create_bool("fail_trap_counter_get", 0600, The test is doing: echo "y"> $DEBUGFS_DIR/fail_trap_drop_counter_get And fails with: ./devlink_trap.sh: line 169: /sys/kernel/debug/netdevsim/netdevsim1337//fail_trap_drop_counter_get: Permission denied Please fix netdevsim to instantiate the correct file and avoid submitting new tests without running them first. > + nsim_dev->ddir, > + &nsim_dev->fail_trap_counter_get); > nsim_udp_tunnels_debugfs_create(nsim_dev); > return 0;
Subject: Re: [PATCH net-next v2 3/7] drivers: net: netdevsim: add devlink trap_drop_counter_get implementation > On Mon, Jun 14, 2021 at 04:01:14PM +0300, Oleksandr Mazur wrote: > + debugfs_create_bool("fail_trap_counter_get", 0600, > The test is doing: > echo "y"> $DEBUGFS_DIR/fail_trap_drop_counter_get > And fails with: > ./devlink_trap.sh: line 169: /sys/kernel/debug/netdevsim/netdevsim1337//fail_trap_drop_counter_get: Permission denied > Please fix netdevsim to instantiate the correct file and avoid submitting new tests without running them first. Sorry for that. I've actually run the test, but the problem is during patch preparation the naming convention for the counter itself changed (and i've missed the debugfs file name to get changed as well), and i've run the test before it was changed. I will send the fix, thank you.
This patch series implement Prestera Switchdev driver devlink traps, that are registered within the driver, as well as extend current devlink functionality by adding new hard drop statistics counter, that could be retrieved on-demand: the counter shows number of packets that have been dropped by the underlying device and haven't been passed to the devlink subsystem. The core prestera-devlink functionality is implemented in the prestera_devlink.c. The patch series also extends the existing devlink kernel API: - devlink: add trap_drop_counter_get callback for driver to register - make it possible to keep track of how many packets have been dropped (hard) by the switch device, before the packets even made it to the devlink subsystem (e.g. dropped due to RXDMA buffer overflow). The core features that extend current functionality of prestera Switchdev driver: - add logic for driver traps and drops registration (also traps with DROP action). - add documentation for prestera driver traps and drops group. PATCH v2: 1) Rebase whole series on top of latest mater; 2) Remove storm control-related patches, as they're out of devlink scope; Oleksandr Mazur (7): net: core: devlink: add dropped stats traps field testing: selftests: net: forwarding: add devlink-required functionality to test (hard) dropped stats field drivers: net: netdevsim: add devlink trap_drop_counter_get implementation testing: selftests: drivers: net: netdevsim: devlink: add test case for hard drop statistics net: marvell: prestera: devlink: add traps/groups implementation net: marvell: prestera: devlink: add traps with DROP action documentation: networking: devlink: add prestera switched driver Documentation Documentation/networking/devlink/prestera.rst | 141 +++++ .../net/ethernet/marvell/prestera/prestera.h | 2 + .../marvell/prestera/prestera_devlink.c | 530 +++++++++++++++++- .../marvell/prestera/prestera_devlink.h | 3 + .../ethernet/marvell/prestera/prestera_dsa.c | 3 + .../ethernet/marvell/prestera/prestera_dsa.h | 1 + .../ethernet/marvell/prestera/prestera_hw.c | 35 ++ .../ethernet/marvell/prestera/prestera_hw.h | 11 + .../ethernet/marvell/prestera/prestera_rxtx.c | 7 +- drivers/net/netdevsim/dev.c | 22 + drivers/net/netdevsim/netdevsim.h | 1 + include/net/devlink.h | 10 + net/core/devlink.c | 53 +- .../drivers/net/netdevsim/devlink_trap.sh | 10 + .../selftests/net/forwarding/devlink_lib.sh | 26 + 15 files changed, 848 insertions(+), 7 deletions(-) create mode 100644 Documentation/networking/devlink/prestera.rst