Message ID | 20210607111837.31074-1-jon.lin@rock-chips.com |
---|---|
Headers | show |
Series | Support ROCKCHIP SPI new feature | expand |
On Mon, 07 Jun 2021 19:18:32 +0800, Jon Lin wrote: > The description below will be used for rv1126.dtsi or compatible one in > the future > > Signed-off-by: Jon Lin <jon.lin@rock-chips.com> > --- > > Changes in v6: > - Consider to compatibility, the "rockchip,rk3568-spi" is removed in > Series-changes v5, so the commit massage should also remove the > corresponding information > > Changes in v5: > - Change to leave one compatible id rv1126, and rk3568 is compatible > with rv1126 > > Changes in v4: > - Adjust the order patches > - Simply commit massage like redundancy "application" content > > Changes in v3: > - Fix compile error which is find by Sascha in [v2,2/8] > > Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
Hi Rob, Similar to the Rockchip SFC discussion this compatible does currently not add any data or difference to the driver. Therefore a simple fallback string will do for now. That in the past that was not strictly enforced, so be it. Could you have a look at it? Kind regards, Johan Jonker https://lore.kernel.org/linux-rockchip/20210607063448.29589-1-jon.lin@rock-chips.com/T/#e202225dbe50829069becd2915267124f379bf2fe - rockchip,rk3368-spi - rockchip,rk3399-spi - rockchip,rv1126-spi - const: rockchip,rk3066-spi On 6/10/21 6:06 PM, Rob Herring wrote: > On Mon, 07 Jun 2021 19:18:32 +0800, Jon Lin wrote: >> The description below will be used for rv1126.dtsi or compatible one in >> the future >> >> Signed-off-by: Jon Lin <jon.lin@rock-chips.com> >> --- >> >> Changes in v6: >> - Consider to compatibility, the "rockchip,rk3568-spi" is removed in >> Series-changes v5, so the commit massage should also remove the >> corresponding information >> >> Changes in v5: >> - Change to leave one compatible id rv1126, and rk3568 is compatible >> with rv1126 >> >> Changes in v4: >> - Adjust the order patches >> - Simply commit massage like redundancy "application" content >> >> Changes in v3: >> - Fix compile error which is find by Sascha in [v2,2/8] >> >> Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 + >> 1 file changed, 1 insertion(+) >> > > Acked-by: Rob Herring <robh@kernel.org> > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip >
Changes in v7: - Fall back "rockchip,rv1126-spi" to "rockchip,rk3066-spi" Changes in v6: - Consider to compatibility, the "rockchip,rk3568-spi" is removed in Series-changes v5, so the commit massage should also remove the corresponding information Changes in v5: - Change to leave one compatible id rv1126, and rk3568 is compatible with rv1126 Changes in v4: - Adjust the order patches - Simply commit massage like redundancy "application" content Changes in v3: - Fix compile error which is find by Sascha in [v2,2/8] Jon Lin (6): dt-bindings: spi: spi-rockchip: add description for rv1126 spi: rockchip: add compatible string for rv1126 spi: rockchip: Set rx_fifo interrupt waterline base on transfer item spi: rockchip: Wait for STB status in slave mode tx_xfer spi: rockchip: Support cs-gpio spi: rockchip: Support SPI_CS_HIGH .../devicetree/bindings/spi/spi-rockchip.yaml | 1 + drivers/spi/spi-rockchip.c | 95 +++++++++++++++---- 2 files changed, 80 insertions(+), 16 deletions(-)
On Mon, Jun 14, 2021 at 9:26 PM Jon Lin <jon.lin@rock-chips.com> wrote: > > The description below will be used for rv1126.dtsi or compatible one in > the future > > Signed-off-by: Jon Lin <jon.lin@rock-chips.com> > --- > > Changes in v7: > - Fall back "rockchip,rv1126-spi" to "rockchip,rk3066-spi" > > Changes in v6: > - Consider to compatibility, the "rockchip,rk3568-spi" is removed in > Series-changes v5, so the commit massage should also remove the > corresponding information > > Changes in v5: > - Change to leave one compatible id rv1126, and rk3568 is compatible > with rv1126 > > Changes in v4: > - Adjust the order patches > - Simply commit massage like redundancy "application" content > > Changes in v3: > - Fix compile error which is find by Sascha in [v2,2/8] > > Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org>