mbox series

[0/3] enable ISH DMA on EHL platform

Message ID 1623306114-19208-1-git-send-email-even.xu@intel.com
Headers show
Series enable ISH DMA on EHL platform | expand

Message

Even Xu June 10, 2021, 6:21 a.m. UTC
These patch set are used for enabling ISH DMA on EHL platform.

During ISH DMA enabling, some platforms (such as EHL) don't
support cache snooping, bus driver (ishtp) has to involve
a new callback, dma_no_cache_snooping(), in hardware layer (ipc)
to get hardware DMA capability.

When do cache flush, clflush_cache_range() API is used on X86
which isn't supported by all other archs (such as ARM).
Considering ISH only exists on Intel platforms, adding ISH
depending on X86 in Kconfig to avoid build warnings or errors
on other archs.

Even Xu (3):
  hid: intel-ish-hid: Set ISH driver depends on x86
  hid: intel-ish-hid: ishtp: Add dma_no_cache_snooping() callback
  hid: intel-ish-hid: ipc: Specify that EHL no cache snooping

 drivers/hid/intel-ish-hid/Kconfig           |  1 +
 drivers/hid/intel-ish-hid/ipc/ipc.c         | 26 +++++++++++++++++++++++++-
 drivers/hid/intel-ish-hid/ishtp/client.c    | 18 ++++++++++++++++++
 drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h |  1 +
 4 files changed, 45 insertions(+), 1 deletion(-)

Comments

Jiri Kosina June 14, 2021, 1:55 p.m. UTC | #1
On Thu, 10 Jun 2021, Even Xu wrote:

> These patch set are used for enabling ISH DMA on EHL platform.

> 

> During ISH DMA enabling, some platforms (such as EHL) don't

> support cache snooping, bus driver (ishtp) has to involve

> a new callback, dma_no_cache_snooping(), in hardware layer (ipc)

> to get hardware DMA capability.

> 

> When do cache flush, clflush_cache_range() API is used on X86

> which isn't supported by all other archs (such as ARM).

> Considering ISH only exists on Intel platforms, adding ISH

> depending on X86 in Kconfig to avoid build warnings or errors

> on other archs.

> 

> Even Xu (3):

>   hid: intel-ish-hid: Set ISH driver depends on x86

>   hid: intel-ish-hid: ishtp: Add dma_no_cache_snooping() callback

>   hid: intel-ish-hid: ipc: Specify that EHL no cache snooping

> 

>  drivers/hid/intel-ish-hid/Kconfig           |  1 +

>  drivers/hid/intel-ish-hid/ipc/ipc.c         | 26 +++++++++++++++++++++++++-

>  drivers/hid/intel-ish-hid/ishtp/client.c    | 18 ++++++++++++++++++

>  drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h |  1 +

>  4 files changed, 45 insertions(+), 1 deletion(-)


Now queued in for-5.14/intel-ish, thanks.

-- 
Jiri Kosina
SUSE Labs
Even Xu June 15, 2021, 1:21 a.m. UTC | #2
Got it, Thanks Jiri!

Best Regards,
Even Xu

-----Original Message-----
From: Jiri Kosina <jikos@kernel.org> 

Sent: Monday, June 14, 2021 9:56 PM
To: Xu, Even <even.xu@intel.com>
Cc: srinivas.pandruvada@linux.intel.com; benjamin.tissoires@redhat.com; linux-input@vger.kernel.org
Subject: Re: [PATCH 0/3] enable ISH DMA on EHL platform

On Thu, 10 Jun 2021, Even Xu wrote:

> These patch set are used for enabling ISH DMA on EHL platform.

> 

> During ISH DMA enabling, some platforms (such as EHL) don't support 

> cache snooping, bus driver (ishtp) has to involve a new callback, 

> dma_no_cache_snooping(), in hardware layer (ipc) to get hardware DMA 

> capability.

> 

> When do cache flush, clflush_cache_range() API is used on X86 which 

> isn't supported by all other archs (such as ARM).

> Considering ISH only exists on Intel platforms, adding ISH depending 

> on X86 in Kconfig to avoid build warnings or errors on other archs.

> 

> Even Xu (3):

>   hid: intel-ish-hid: Set ISH driver depends on x86

>   hid: intel-ish-hid: ishtp: Add dma_no_cache_snooping() callback

>   hid: intel-ish-hid: ipc: Specify that EHL no cache snooping

> 

>  drivers/hid/intel-ish-hid/Kconfig           |  1 +

>  drivers/hid/intel-ish-hid/ipc/ipc.c         | 26 +++++++++++++++++++++++++-

>  drivers/hid/intel-ish-hid/ishtp/client.c    | 18 ++++++++++++++++++

>  drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h |  1 +

>  4 files changed, 45 insertions(+), 1 deletion(-)


Now queued in for-5.14/intel-ish, thanks.

--
Jiri Kosina
SUSE Labs