| Message ID | fda1bc3516ac98084089b5565b486a0a41b3a62c.1623315732.git.geert+renesas@glider.be |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: renesas: Add support for R Car H3e 2G-and M3e-2G | expand |
Hi Geert, Thank you for the patch. On Thu, Jun 10, 2021 at 11:37:20AM +0200, Geert Uytterhoeven wrote: > Add support for the Renesas Salvator-X 2nd version development > board equipped with an R-Car H3e-2G SiP. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > arch/arm64/boot/dts/renesas/Makefile | 2 + > .../boot/dts/renesas/r8a779m1-salvator-xs.dts | 53 +++++++++++++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts > > diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile > index f2de2fa0c8b890fb..5a689a1d10821f1d 100644 > --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -62,3 +62,5 @@ dtb-$(CONFIG_ARCH_R8A77990) += r8a77990-ebisu.dtb > dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb > > dtb-$(CONFIG_ARCH_R8A779A0) += r8a779a0-falcon.dtb > + > +dtb-$(CONFIG_ARCH_R8A77951) += r8a779m1-salvator-xs.dtb How about preserving the alphabetical order of the Kconfig symbols ? Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > diff --git a/arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts > new file mode 100644 > index 0000000000000000..084b75b046802339 > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts > @@ -0,0 +1,53 @@ > +// SPDX-License-Identifier: (GPL-2.0 or MIT) > +/* > + * Device Tree Source for the Salvator-X 2nd version board with R-Car H3e-2G > + * > + * Copyright (C) 2021 Glider bv > + * > + * Based on r8a77951-salvator-xs.dts > + * Copyright (C) 2015-2017 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +#include "r8a779m1.dtsi" > +#include "salvator-xs.dtsi" > + > +/ { > + model = "Renesas Salvator-X 2nd version board based on r8a779m1"; > + compatible = "renesas,salvator-xs", "renesas,r8a779m1", > + "renesas,r8a7795"; > + > + memory@48000000 { > + device_type = "memory"; > + /* first 128MB is reserved for secure area. */ > + reg = <0x0 0x48000000 0x0 0x38000000>; > + }; > + > + memory@500000000 { > + device_type = "memory"; > + reg = <0x5 0x00000000 0x0 0x40000000>; > + }; > + > + memory@600000000 { > + device_type = "memory"; > + reg = <0x6 0x00000000 0x0 0x40000000>; > + }; > + > + memory@700000000 { > + device_type = "memory"; > + reg = <0x7 0x00000000 0x0 0x40000000>; > + }; > +}; > + > +&du { > + clocks = <&cpg CPG_MOD 724>, > + <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 722>, > + <&cpg CPG_MOD 721>, > + <&versaclock6 1>, > + <&x21_clk>, > + <&x22_clk>, > + <&versaclock6 2>; > + clock-names = "du.0", "du.1", "du.2", "du.3", > + "dclkin.0", "dclkin.1", "dclkin.2", "dclkin.3"; > +}; -- Regards, Laurent Pinchart
Hi Laurent, On Mon, Jun 14, 2021 at 8:46 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thu, Jun 10, 2021 at 11:37:20AM +0200, Geert Uytterhoeven wrote: > > Add support for the Renesas Salvator-X 2nd version development > > board equipped with an R-Car H3e-2G SiP. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- a/arch/arm64/boot/dts/renesas/Makefile > > +++ b/arch/arm64/boot/dts/renesas/Makefile > > @@ -62,3 +62,5 @@ dtb-$(CONFIG_ARCH_R8A77990) += r8a77990-ebisu.dtb > > dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb > > > > dtb-$(CONFIG_ARCH_R8A779A0) += r8a779a0-falcon.dtb > > + > > +dtb-$(CONFIG_ARCH_R8A77951) += r8a779m1-salvator-xs.dtb > > How about preserving the alphabetical order of the Kconfig symbols ? At the expense of breaking alphabetical order of the DTB file names? I agree both make sense. Do we need a vote? ;-) > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, June 15, 2021 4:34 AM > > Hi Laurent, > > On Mon, Jun 14, 2021 at 8:46 PM Laurent Pinchart wrote: > > On Thu, Jun 10, 2021 at 11:37:20AM +0200, Geert Uytterhoeven wrote: > > > Add support for the Renesas Salvator-X 2nd version development > > > board equipped with an R-Car H3e-2G SiP. > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- a/arch/arm64/boot/dts/renesas/Makefile > > > +++ b/arch/arm64/boot/dts/renesas/Makefile > > > @@ -62,3 +62,5 @@ dtb-$(CONFIG_ARCH_R8A77990) += r8a77990-ebisu.dtb > > > dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb > > > > > > dtb-$(CONFIG_ARCH_R8A779A0) += r8a779a0-falcon.dtb > > > + > > > +dtb-$(CONFIG_ARCH_R8A77951) += r8a779m1-salvator-xs.dtb > > > > How about preserving the alphabetical order of the Kconfig symbols ? > > At the expense of breaking alphabetical order of the DTB file names? > > I agree both make sense. Do we need a vote? ;-) I prefer the alphabetical order of the DTB file names :) Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index f2de2fa0c8b890fb..5a689a1d10821f1d 100644 --- a/arch/arm64/boot/dts/renesas/Makefile +++ b/arch/arm64/boot/dts/renesas/Makefile @@ -62,3 +62,5 @@ dtb-$(CONFIG_ARCH_R8A77990) += r8a77990-ebisu.dtb dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb dtb-$(CONFIG_ARCH_R8A779A0) += r8a779a0-falcon.dtb + +dtb-$(CONFIG_ARCH_R8A77951) += r8a779m1-salvator-xs.dtb diff --git a/arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts new file mode 100644 index 0000000000000000..084b75b046802339 --- /dev/null +++ b/arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts @@ -0,0 +1,53 @@ +// SPDX-License-Identifier: (GPL-2.0 or MIT) +/* + * Device Tree Source for the Salvator-X 2nd version board with R-Car H3e-2G + * + * Copyright (C) 2021 Glider bv + * + * Based on r8a77951-salvator-xs.dts + * Copyright (C) 2015-2017 Renesas Electronics Corp. + */ + +/dts-v1/; +#include "r8a779m1.dtsi" +#include "salvator-xs.dtsi" + +/ { + model = "Renesas Salvator-X 2nd version board based on r8a779m1"; + compatible = "renesas,salvator-xs", "renesas,r8a779m1", + "renesas,r8a7795"; + + memory@48000000 { + device_type = "memory"; + /* first 128MB is reserved for secure area. */ + reg = <0x0 0x48000000 0x0 0x38000000>; + }; + + memory@500000000 { + device_type = "memory"; + reg = <0x5 0x00000000 0x0 0x40000000>; + }; + + memory@600000000 { + device_type = "memory"; + reg = <0x6 0x00000000 0x0 0x40000000>; + }; + + memory@700000000 { + device_type = "memory"; + reg = <0x7 0x00000000 0x0 0x40000000>; + }; +}; + +&du { + clocks = <&cpg CPG_MOD 724>, + <&cpg CPG_MOD 723>, + <&cpg CPG_MOD 722>, + <&cpg CPG_MOD 721>, + <&versaclock6 1>, + <&x21_clk>, + <&x22_clk>, + <&versaclock6 2>; + clock-names = "du.0", "du.1", "du.2", "du.3", + "dclkin.0", "dclkin.1", "dclkin.2", "dclkin.3"; +};
Add support for the Renesas Salvator-X 2nd version development board equipped with an R-Car H3e-2G SiP. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm64/boot/dts/renesas/Makefile | 2 + .../boot/dts/renesas/r8a779m1-salvator-xs.dts | 53 +++++++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 arch/arm64/boot/dts/renesas/r8a779m1-salvator-xs.dts