| Message ID | 20210610214438.3161140-1-trix@redhat.com |
|---|---|
| Headers | show |
| Series | check Makefile and Kconfigs for SPDX tag | expand |
On Thu, 2021-06-10 at 14:44 -0700, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > Both Makefiles and Kconfigs should carry an SPDX tag. > Something like > # SPDX-License-Identifier: GPL-2.0-only > > Add a matcher to existing check > > Signed-off-by: Tom Rix <trix@redhat.com> Seems fine, thanks. There's a Makefile with two tags that could be updated too. --- drivers/staging/media/atomisp/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/atomisp/Makefile b/drivers/staging/media/atomisp/Makefile index 51498b2e85b8f..cee03e31f420d 100644 --- a/drivers/staging/media/atomisp/Makefile +++ b/drivers/staging/media/atomisp/Makefile @@ -11,7 +11,6 @@ DEFINES += -DDEBUG atomisp = $(srctree)/drivers/staging/media/atomisp/ -# SPDX-License-Identifier: GPL-2.0 atomisp-objs += \ pci/atomisp_acc.o \ pci/atomisp_cmd.o \
On Thu, 10 Jun 2021 14:44:36 -0700 trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > checkpatch looks for SPDX-License-Identifier. > Remove the extra spaces. > > Signed-off-by: Tom Rix <trix@redhat.com> Applied this one to the togreg branch of iio.git (initially pushed out as testing to let 0-day have first poke at it). Thanks, Jonathan > --- > drivers/iio/common/scmi_sensors/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/common/scmi_sensors/Makefile b/drivers/iio/common/scmi_sensors/Makefile > index f13140a2575a4..645e0fce1a739 100644 > --- a/drivers/iio/common/scmi_sensors/Makefile > +++ b/drivers/iio/common/scmi_sensors/Makefile > @@ -1,4 +1,4 @@ > -# SPDX - License - Identifier : GPL - 2.0 - only > +# SPDX-License-Identifier: GPL-2.0-only > # > # Makefile for the IIO over SCMI > #
On Thu, Jun 10, 2021 at 02:44:34PM -0700, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > checkpatch looks for SPDX-License-Identifier. > So change the '_' to '-' > > Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Stafford Horne <shorne@gmail.com> > --- > drivers/soc/litex/Kconfig | 2 +- > drivers/soc/litex/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/litex/Kconfig b/drivers/soc/litex/Kconfig > index e7011d665b151..c03b1f816cc08 100644 > --- a/drivers/soc/litex/Kconfig > +++ b/drivers/soc/litex/Kconfig > @@ -1,4 +1,4 @@ > -# SPDX-License_Identifier: GPL-2.0 > +# SPDX-License-Identifier: GPL-2.0 > > menu "Enable LiteX SoC Builder specific drivers" > > diff --git a/drivers/soc/litex/Makefile b/drivers/soc/litex/Makefile > index 98ff7325b1c07..aeae1f4165a70 100644 > --- a/drivers/soc/litex/Makefile > +++ b/drivers/soc/litex/Makefile > @@ -1,3 +1,3 @@ > -# SPDX-License_Identifier: GPL-2.0 > +# SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_LITEX_SOC_CONTROLLER) += litex_soc_ctrl.o > -- > 2.26.3 >
From: Tom Rix <trix@redhat.com> A followup to https://lore.kernel.org/linux-fpga/YMD2yxtsQN16MoPA@kroah.com/ So I do not repeat this problem, add a SPDX checker for Makefiles and Kconfigs to checkpatch. Then treewide fix the malformed Makefiles and Kconfigs. Those missing tags are numerous. Kconfig has 46 Makefile has 141 Run checkpatch generally over the dirs with Makefile or Kconfig problems to check nothing broke in checkpatch. Fix the few problems turned up Tom Rix (7): checkpatch: check Makefiles and Kconfigs for SPDX tag mei: hdcp: SPDX tag should be the first line drivers/soc/litex: fix spelling of SPDX tag MIPS: Loongson64: fix spelling of SPDX tag iio/scmi: fix spelling of SPDX tag mt76: add a space between comment char and SPDX tag mt76: use SPDX header file comment style arch/mips/boot/dts/loongson/Makefile | 2 +- drivers/iio/common/scmi_sensors/Makefile | 2 +- drivers/misc/mei/hdcp/Kconfig | 1 - drivers/net/wireless/mediatek/mt76/mt7615/Makefile | 2 +- drivers/net/wireless/mediatek/mt76/mt7615/sdio.h | 2 +- drivers/net/wireless/mediatek/mt76/mt7915/Makefile | 2 +- drivers/net/wireless/mediatek/mt76/mt7915/testmode.h | 2 +- drivers/net/wireless/mediatek/mt76/mt7921/Makefile | 2 +- drivers/soc/litex/Kconfig | 2 +- drivers/soc/litex/Makefile | 2 +- scripts/checkpatch.pl | 2 +- 11 files changed, 10 insertions(+), 11 deletions(-)