| Message ID | 20210316162643.2442885-1-geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | [v5] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: | expand |
Hi All, On 16/03/21 17:26, Geert Uytterhoeven wrote: > - Remove unneeded references for "idt,xtal-load-femtofarads" and > "idt,slew-percent", as vendor specific properties having a standard > unit suffix don't need a type, > - Add missing "additionalProperties: false" for subnodes, to catch > typos in properties, > - Fix property names in example. > > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> > Reviewed-by: Rob Herring <robh@kernel.org> > Acked-by: Stephen Boyd <sboyd@kernel.org> This patch seems to have gone MIA. It really should be applied. Geert, would you please rebase&resend in case it does not not apply anymore? (or tell me if you prefer me to take it over) > --- > This depends on dt-schema v2021.2.1. > > v4: > - Add Reviewed-by, Acked-by, > > v3: > - Drop references for "idt,voltage-microvolt" and "idt,slew-percent", > > v2: > - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0 > ('clk: vc5: Use "idt,voltage-microvolt" instead of > "idt,voltage-microvolts"'), > - Drop reference to clock.yaml, which is already applied > unconditionally, > - Drop removal of allOf around if condition, as it is unnecessary > churn. > > squash! dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: heh, should be removed, but is's after --- so not a big deal. -- Luca
Hi Luca, On Wed, Jun 9, 2021 at 10:56 PM Luca Ceresoli <luca@lucaceresoli.net> wrote: > On 16/03/21 17:26, Geert Uytterhoeven wrote: > > - Remove unneeded references for "idt,xtal-load-femtofarads" and > > "idt,slew-percent", as vendor specific properties having a standard > > unit suffix don't need a type, > > - Add missing "additionalProperties: false" for subnodes, to catch > > typos in properties, > > - Fix property names in example. > > > > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > This patch seems to have gone MIA. It really should be applied. Geert, > would you please rebase&resend in case it does not not apply anymore? > (or tell me if you prefer me to take it over) Send v6 (patch got smaller again ;-) > > > --- > > This depends on dt-schema v2021.2.1. > > > > v4: > > - Add Reviewed-by, Acked-by, > > > > v3: > > - Drop references for "idt,voltage-microvolt" and "idt,slew-percent", > > > > v2: > > - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0 > > ('clk: vc5: Use "idt,voltage-microvolt" instead of > > "idt,voltage-microvolts"'), > > - Drop reference to clock.yaml, which is already applied > > unconditionally, > > - Drop removal of allOf around if condition, as it is unnecessary > > churn. > > > > squash! dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: > > heh, should be removed, but is's after --- so not a big deal. Yeah, silly rebase mistake (I apply fixes with changelogs with --squash). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml index c268debe5b8d58cd..434212320c9aa7ab 100644 --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml @@ -60,7 +60,6 @@ properties: maxItems: 2 idt,xtal-load-femtofarads: - $ref: /schemas/types.yaml#/definitions/uint32 minimum: 9000 maximum: 22760 description: Optional load capacitor for XTAL1 and XTAL2 @@ -84,9 +83,10 @@ patternProperties: enum: [ 1800000, 2500000, 3300000 ] idt,slew-percent: description: The Slew rate control for CMOS single-ended. - $ref: /schemas/types.yaml#/definitions/uint32 enum: [ 80, 85, 90, 100 ] + additionalProperties: false + required: - compatible - reg @@ -141,13 +141,13 @@ examples: clock-names = "xin"; OUT1 { - idt,drive-mode = <VC5_CMOSD>; - idt,voltage-microvolts = <1800000>; + idt,mode = <VC5_CMOSD>; + idt,voltage-microvolt = <1800000>; idt,slew-percent = <80>; }; OUT4 { - idt,drive-mode = <VC5_LVDS>; + idt,mode = <VC5_LVDS>; }; }; };
- Remove unneeded references for "idt,xtal-load-femtofarads" and "idt,slew-percent", as vendor specific properties having a standard unit suffix don't need a type, - Add missing "additionalProperties: false" for subnodes, to catch typos in properties, - Fix property names in example. Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> Reviewed-by: Rob Herring <robh@kernel.org> Acked-by: Stephen Boyd <sboyd@kernel.org> --- This depends on dt-schema v2021.2.1. v4: - Add Reviewed-by, Acked-by, v3: - Drop references for "idt,voltage-microvolt" and "idt,slew-percent", v2: - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0 ('clk: vc5: Use "idt,voltage-microvolt" instead of "idt,voltage-microvolts"'), - Drop reference to clock.yaml, which is already applied unconditionally, - Drop removal of allOf around if condition, as it is unnecessary churn. squash! dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: v5: - Drop reference for "idt,xtal-load-femtofarads", --- .../devicetree/bindings/clock/idt,versaclock5.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)