| Message ID | 20210607113840.15435-5-bhupesh.sharma@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: Add SA8155p-adp board DTS | expand |
On Mon, Jun 7, 2021 at 2:41 PM Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > SA8155p-adp board has two new regulator types - pmm8155au_1 and > pmm8155au_2. > > The output power management circuits in these regulators include: > - FTS510 smps, > - HFS510 smps, and > - LDO510 linear regulators ... > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Andy Gross <agross@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-gpio@vger.kernel.org > Cc: bhupesh.linux@gmail.com Use --cc or similar option when run `git send-email`, no need to pollute the commit message with these. ... > +static const struct rpmh_vreg_init_data pmm8155au_1_vreg_data[] = { > + {}, Comma is not needed in the terminator line. > +};
On Mon 07 Jun 07:30 CDT 2021, Bhupesh Sharma wrote: > On Mon, 7 Jun 2021 at 17:39, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > > > On Mon, Jun 7, 2021 at 2:41 PM Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > > > > > SA8155p-adp board has two new regulator types - pmm8155au_1 and > > > pmm8155au_2. > > > > > > The output power management circuits in these regulators include: > > > - FTS510 smps, > > > - HFS510 smps, and > > > - LDO510 linear regulators > > > > ... > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Liam Girdwood <lgirdwood@gmail.com> > > > Cc: Mark Brown <broonie@kernel.org> > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Cc: Vinod Koul <vkoul@kernel.org> > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Andy Gross <agross@kernel.org> > > > Cc: devicetree@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > > Cc: linux-gpio@vger.kernel.org > > > Cc: bhupesh.linux@gmail.com > > > > Use --cc or similar option when run `git send-email`, no need to > > pollute the commit message with these. > > It's just a matter of preference IMO. I prefer to use a Cc list > here. > The Cc list in the commit message will be committed to the git history and there it carries the information that you specifically made sure that these people saw the patch. So please limit the use to that purpose. > > > +static const struct rpmh_vreg_init_data pmm8155au_1_vreg_data[] = { > > > > > > > + {}, > > > > Comma is not needed in the terminator line. > > Hmm.. it's similar to the syntax already used at several places in this file. > See ' struct rpmh_vreg_init_data pm8150l_vreg_data[] ' for example. > > Unless there is an obvious issue with it, let's use the same to keep > things similar from a syntax p-o-v. > Those other places shouldn't use the ',' either, so please help set a better precedence. Thanks, Bjorn > Thanks, > Bhupesh > > > > > > +}; > > > > -- > > With Best Regards, > > Andy Shevchenko
On Mon, 14 Jun 2021 at 21:47, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Mon 07 Jun 07:30 CDT 2021, Bhupesh Sharma wrote: > > > On Mon, 7 Jun 2021 at 17:39, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > > > > > On Mon, Jun 7, 2021 at 2:41 PM Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > > > > > > > SA8155p-adp board has two new regulator types - pmm8155au_1 and > > > > pmm8155au_2. > > > > > > > > The output power management circuits in these regulators include: > > > > - FTS510 smps, > > > > - HFS510 smps, and > > > > - LDO510 linear regulators > > > > > > ... > > > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > > Cc: Liam Girdwood <lgirdwood@gmail.com> > > > > Cc: Mark Brown <broonie@kernel.org> > > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > Cc: Vinod Koul <vkoul@kernel.org> > > > > Cc: Rob Herring <robh+dt@kernel.org> > > > > Cc: Andy Gross <agross@kernel.org> > > > > Cc: devicetree@vger.kernel.org > > > > Cc: linux-kernel@vger.kernel.org > > > > Cc: linux-gpio@vger.kernel.org > > > > Cc: bhupesh.linux@gmail.com > > > > > > Use --cc or similar option when run `git send-email`, no need to > > > pollute the commit message with these. > > > > It's just a matter of preference IMO. I prefer to use a Cc list > > here. > > > > The Cc list in the commit message will be committed to the git history > and there it carries the information that you specifically made sure > that these people saw the patch. So please limit the use to that > purpose. I understand, but different maintainers like different formats here. Infact, there are suggestions not to use --cc as some opens-source lists are known to drop folks from Cc list accidentally (mentioned via --cc) , so some folks prefer the git log to contain the Cc list instead. But I can trim the same for v2. > > > > +static const struct rpmh_vreg_init_data pmm8155au_1_vreg_data[] = { > > > > > > > > > > + {}, > > > > > > Comma is not needed in the terminator line. > > > > Hmm.. it's similar to the syntax already used at several places in this file. > > See ' struct rpmh_vreg_init_data pm8150l_vreg_data[] ' for example. > > > > Unless there is an obvious issue with it, let's use the same to keep > > things similar from a syntax p-o-v. > > > > Those other places shouldn't use the ',' either, so please help set a > better precedence. Sure, I will send that out as a separate clean-up patch. Regards, Bhupesh
diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c index 22fec370fa61..d0a3c6527568 100644 --- a/drivers/regulator/qcom-rpmh-regulator.c +++ b/drivers/regulator/qcom-rpmh-regulator.c @@ -883,6 +883,70 @@ static const struct rpmh_vreg_init_data pm8150l_vreg_data[] = { {}, }; +static const struct rpmh_vreg_init_data pmm8155au_1_vreg_data[] = { + RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"), + RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"), + RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps510, "vdd-s3"), + RPMH_VREG("smps4", "smp%s4", &pmic5_hfsmps510, "vdd-s4"), + RPMH_VREG("smps5", "smp%s5", &pmic5_hfsmps510, "vdd-s5"), + RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps510, "vdd-s6"), + RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps510, "vdd-s7"), + RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps510, "vdd-s8"), + RPMH_VREG("smps9", "smp%s9", &pmic5_ftsmps510, "vdd-s9"), + RPMH_VREG("smps10", "smp%s10", &pmic5_ftsmps510, "vdd-s10"), + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1-l8-l11"), + RPMH_VREG("ldo2", "ldo%s2", &pmic5_pldo, "vdd-l2-l10"), + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + RPMH_VREG("ldo5", "ldo%s5", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + RPMH_VREG("ldo6", "ldo%s6", &pmic5_nldo, "vdd-l6-l9"), + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo8", "ldo%s8", &pmic5_nldo, "vdd-l1-l8-l11"), + RPMH_VREG("ldo9", "ldo%s9", &pmic5_nldo, "vdd-l6-l9"), + RPMH_VREG("ldo10", "ldo%s10", &pmic5_pldo, "vdd-l2-l10"), + RPMH_VREG("ldo11", "ldo%s11", &pmic5_nldo, "vdd-l1-l8-l11"), + RPMH_VREG("ldo12", "ldo%s12", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l13-l16-l17"), + RPMH_VREG("ldo14", "ldo%s14", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo15", "ldo%s15", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo16", "ldo%s16", &pmic5_pldo, "vdd-l13-l16-l17"), + RPMH_VREG("ldo17", "ldo%s17", &pmic5_pldo, "vdd-l13-l16-l17"), + RPMH_VREG("ldo18", "ldo%s18", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + {}, +}; + +static const struct rpmh_vreg_init_data pmm8155au_2_vreg_data[] = { + RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"), + RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"), + RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps510, "vdd-s3"), + RPMH_VREG("smps4", "smp%s4", &pmic5_hfsmps510, "vdd-s4"), + RPMH_VREG("smps5", "smp%s5", &pmic5_hfsmps510, "vdd-s5"), + RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps510, "vdd-s6"), + RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps510, "vdd-s7"), + RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps510, "vdd-s8"), + RPMH_VREG("smps9", "smp%s9", &pmic5_ftsmps510, "vdd-s9"), + RPMH_VREG("smps10", "smp%s10", &pmic5_ftsmps510, "vdd-s10"), + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1-l8-l11"), + RPMH_VREG("ldo2", "ldo%s2", &pmic5_pldo, "vdd-l2-l10"), + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + RPMH_VREG("ldo5", "ldo%s5", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + RPMH_VREG("ldo6", "ldo%s6", &pmic5_nldo, "vdd-l6-l9"), + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo8", "ldo%s8", &pmic5_nldo, "vdd-l1-l8-l11"), + RPMH_VREG("ldo9", "ldo%s9", &pmic5_nldo, "vdd-l6-l9"), + RPMH_VREG("ldo10", "ldo%s10", &pmic5_pldo, "vdd-l2-l10"), + RPMH_VREG("ldo11", "ldo%s11", &pmic5_nldo, "vdd-l1-l8-l11"), + RPMH_VREG("ldo12", "ldo%s12", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l13-l16-l17"), + RPMH_VREG("ldo14", "ldo%s14", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo15", "ldo%s15", &pmic5_pldo_lv, "vdd-l7-l12-l14-l15"), + RPMH_VREG("ldo16", "ldo%s16", &pmic5_pldo, "vdd-l13-l16-l17"), + RPMH_VREG("ldo17", "ldo%s17", &pmic5_pldo, "vdd-l13-l16-l17"), + RPMH_VREG("ldo18", "ldo%s18", &pmic5_nldo, "vdd-l3-l4-l5-l18"), + {}, +}; + static const struct rpmh_vreg_init_data pm8350_vreg_data[] = { RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps510, "vdd-s1"), RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps510, "vdd-s2"), @@ -1143,6 +1207,14 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = { .compatible = "qcom,pm8150l-rpmh-regulators", .data = pm8150l_vreg_data, }, + { + .compatible = "qcom,pmm8155au-1-rpmh-regulators", + .data = pmm8155au_1_vreg_data, + }, + { + .compatible = "qcom,pmm8155au-2-rpmh-regulators", + .data = pmm8155au_2_vreg_data, + }, { .compatible = "qcom,pm8350-rpmh-regulators", .data = pm8350_vreg_data,
SA8155p-adp board has two new regulator types - pmm8155au_1 and pmm8155au_2. The output power management circuits in these regulators include: - FTS510 smps, - HFS510 smps, and - LDO510 linear regulators Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Andy Gross <agross@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: bhupesh.linux@gmail.com Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- drivers/regulator/qcom-rpmh-regulator.c | 72 +++++++++++++++++++++++++ 1 file changed, 72 insertions(+)