mbox series

[v2,0/3] Add watchdog for Mstar SoCs

Message ID 20210530072645.10379-1-romain.perier@gmail.com
Headers show
Series Add watchdog for Mstar SoCs | expand

Message

Romain Perier May 30, 2021, 7:26 a.m. UTC
This patches series adds a new driver for the watchdog found in the Mstar
MSC313e SoCs and newer. It adds a basic watchdog driver, the
corresponding devicetree bindings and its documentation.

This work has been co-developed with Daniel Palmer.

Changes since v1:
- Dropped "depends OF" from Kconfig (not required)
- Dropped unneeded include files
- Re-ordered include files
- Compute timeout_max dynamically from the probe function to avoid
  an overflow in _start().


Daniel Palmer (1):
  watchdog: Add Mstar MSC313e WDT driver

Romain Perier (2):
  Documentation: watchdog: Add Mstar MSC313e WDT devicetree bindings
    documentation
  ARM: dts: mstar: Add watchdog device_node definition

 .../bindings/watchdog/msc313e-wdt.yaml        |  40 +++++
 MAINTAINERS                                   |   1 +
 arch/arm/boot/dts/mstar-v7.dtsi               |  14 ++
 drivers/watchdog/Kconfig                      |  12 ++
 drivers/watchdog/Makefile                     |   1 +
 drivers/watchdog/msc313e_wdt.c                | 166 ++++++++++++++++++
 6 files changed, 234 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml
 create mode 100644 drivers/watchdog/msc313e_wdt.c

Comments

Rob Herring (Arm) June 4, 2021, 9:30 p.m. UTC | #1
On Sun, May 30, 2021 at 09:26:43AM +0200, Romain Perier wrote:
> This adds the documentation for the devicetree bindings of the Mstar

> MSC313e watchdog driver, found from MSC313e SoCs and newer.


'dt-bindings: watchdog: ...' for the subject.

> 

> Signed-off-by: Romain Perier <romain.perier@gmail.com>

> ---

>  .../bindings/watchdog/msc313e-wdt.yaml        | 40 +++++++++++++++++++


mstar,msc313e-wdt.yaml

>  1 file changed, 40 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml

> 

> diff --git a/Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml b/Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml

> new file mode 100644

> index 000000000000..70b8e1be5e8e

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml

> @@ -0,0 +1,40 @@

> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/watchdog/msc313e-wdt.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: MStar Watchdog Device Tree Bindings

> +

> +maintainers:

> +  - Daniel Palmer <daniel@0x0f.com>

> +  - Romain Perier <romain.perier@gmail.com>

> +

> +allOf:

> +  - $ref: watchdog.yaml#

> +

> +properties:

> +  compatible:

> +    enum:

> +      - mstar,msc313e-wdt

> +

> +  reg:

> +    maxItems: 1

> +

> +  clocks:

> +    maxItems: 1

> +

> +required:

> +  - compatible

> +  - clocks

> +  - reg

> +

> +unevaluatedProperties: false

> +

> +examples:

> +  - |

> +    watchdog: watchdog@6000 {


Drop unused labels.

> +        compatible = "mstar,msc313e-wdt";

> +        reg = <0x6000 0x1f>;

> +        clocks = <&xtal_div2>;

> +    };

> -- 

> 2.30.2
Romain Perier June 5, 2021, 4:54 p.m. UTC | #2
Le ven. 4 juin 2021 à 23:30, Rob Herring <robh@kernel.org> a écrit :
>

> On Sun, May 30, 2021 at 09:26:43AM +0200, Romain Perier wrote:

> > This adds the documentation for the devicetree bindings of the Mstar

> > MSC313e watchdog driver, found from MSC313e SoCs and newer.

>

> 'dt-bindings: watchdog: ...' for the subject.

>

> >

> > Signed-off-by: Romain Perier <romain.perier@gmail.com>

> > ---

> >  .../bindings/watchdog/msc313e-wdt.yaml        | 40 +++++++++++++++++++

>

> mstar,msc313e-wdt.yaml

>

> >  1 file changed, 40 insertions(+)

> >  create mode 100644 Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml

> >

> > diff --git a/Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml b/Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml

> > new file mode 100644

> > index 000000000000..70b8e1be5e8e

> > --- /dev/null

> > +++ b/Documentation/devicetree/bindings/watchdog/msc313e-wdt.yaml

> > @@ -0,0 +1,40 @@

> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> > +%YAML 1.2

> > +---

> > +$id: http://devicetree.org/schemas/watchdog/msc313e-wdt.yaml#

> > +$schema: http://devicetree.org/meta-schemas/core.yaml#

> > +

> > +title: MStar Watchdog Device Tree Bindings

> > +

> > +maintainers:

> > +  - Daniel Palmer <daniel@0x0f.com>

> > +  - Romain Perier <romain.perier@gmail.com>

> > +

> > +allOf:

> > +  - $ref: watchdog.yaml#

> > +

> > +properties:

> > +  compatible:

> > +    enum:

> > +      - mstar,msc313e-wdt

> > +

> > +  reg:

> > +    maxItems: 1

> > +

> > +  clocks:

> > +    maxItems: 1

> > +

> > +required:

> > +  - compatible

> > +  - clocks

> > +  - reg

> > +

> > +unevaluatedProperties: false

> > +

> > +examples:

> > +  - |

> > +    watchdog: watchdog@6000 {

>

> Drop unused labels.

>

> > +        compatible = "mstar,msc313e-wdt";

> > +        reg = <0x6000 0x1f>;

> > +        clocks = <&xtal_div2>;

> > +    };

> > --

> > 2.30.2


Hi,

Ok I will send a v3

Regards,
Romain