mbox series

[0/2] Make ampdu tx work correctly

Message ID 20210531090254.86830-1-chris.chiu@canonical.com
Headers show
Series Make ampdu tx work correctly | expand

Message

Chris Chiu May 31, 2021, 9:02 a.m. UTC
From: Chris Chiu <chris.chiu@canonical.com>

The rtl8xxxu is the driver based on mac80211 framework, but the
ampdu tx is never working. Fix the ampdu_action and the hw capability
to enable the ampdu tx.

Chris Chiu (2):
  rtl8xxxu: unset the hw capability HAS_RATE_CONTROL
  rtl8xxxu: Fix ampdu_action to get block ack session work

 .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h  |  1 +
 .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 28 ++++++++++++-------
 2 files changed, 19 insertions(+), 10 deletions(-)

Comments

Kalle Valo June 3, 2021, 9:51 a.m. UTC | #1
chris.chiu@canonical.com writes:

> From: Chris Chiu <chris.chiu@canonical.com>

>

> The HAS_RATE_CONTROL hw capability needs to be unset for the rate

> control of mac80211 to work. Since the ieee80211_start_tx_ba_session

> is started by the method .get_rate of rate_control_ops. We need to

> unset it so the ampdu can be handled by mac80211.


The commit log is not really describing in detail _why_ you are doing
this. Switching the rate control from hardware/firmware to mac80211 is a
major change and I want to see a good explanation why this is the right
thing to do and does not cause any regressions.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches