| Message ID | 20210529001902.468060-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 3ee236296a4093a6c9967647ed6f640a81ae9f25 |
| Headers | show |
| Series | power: supply: smb347-charger: Drop unused include | expand |
29.05.2021 03:19, Linus Walleij пишет: > This driver is including the legacy GPIO header <linux/gpio.h> > but not using any symbols from it. Delete the include. > > Cc: David Heidelberg <david@ixit.cz> > Cc: Dmitry Osipenko <digetx@gmail.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/power/supply/smb347-charger.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c > index 3376f42d46c3..df240420f2de 100644 > --- a/drivers/power/supply/smb347-charger.c > +++ b/drivers/power/supply/smb347-charger.c > @@ -10,7 +10,6 @@ > > #include <linux/delay.h> > #include <linux/err.h> > -#include <linux/gpio.h> > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/init.h> > Good catch, GPIO usage was gone with the removal of legacy platform data from the driver, which Sebastian did not so long time ago. Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: David Heidelberg <david@ixit.cz> Best regards David Heidelberg On Sat, May 29 2021 at 02:19:02 +0200, Linus Walleij <linus.walleij@linaro.org> wrote: > This driver is including the legacy GPIO header <linux/gpio.h> > but not using any symbols from it. Delete the include. > > Cc: David Heidelberg <david@ixit.cz> > Cc: Dmitry Osipenko <digetx@gmail.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/power/supply/smb347-charger.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/power/supply/smb347-charger.c > b/drivers/power/supply/smb347-charger.c > index 3376f42d46c3..df240420f2de 100644 > --- a/drivers/power/supply/smb347-charger.c > +++ b/drivers/power/supply/smb347-charger.c > @@ -10,7 +10,6 @@ > > #include <linux/delay.h> > #include <linux/err.h> > -#include <linux/gpio.h> > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/init.h> > -- > 2.31.1 >
Hi, On Sat, May 29, 2021 at 02:19:02AM +0200, Linus Walleij wrote: > This driver is including the legacy GPIO header <linux/gpio.h> > but not using any symbols from it. Delete the include. > > Cc: David Heidelberg <david@ixit.cz> > Cc: Dmitry Osipenko <digetx@gmail.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- Thanks, queued. -- Sebastian > drivers/power/supply/smb347-charger.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c > index 3376f42d46c3..df240420f2de 100644 > --- a/drivers/power/supply/smb347-charger.c > +++ b/drivers/power/supply/smb347-charger.c > @@ -10,7 +10,6 @@ > > #include <linux/delay.h> > #include <linux/err.h> > -#include <linux/gpio.h> > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/init.h> > -- > 2.31.1 >
diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c index 3376f42d46c3..df240420f2de 100644 --- a/drivers/power/supply/smb347-charger.c +++ b/drivers/power/supply/smb347-charger.c @@ -10,7 +10,6 @@ #include <linux/delay.h> #include <linux/err.h> -#include <linux/gpio.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/init.h>
This driver is including the legacy GPIO header <linux/gpio.h> but not using any symbols from it. Delete the include. Cc: David Heidelberg <david@ixit.cz> Cc: Dmitry Osipenko <digetx@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/power/supply/smb347-charger.c | 1 - 1 file changed, 1 deletion(-) -- 2.31.1