| Message ID | 20210528090629.1800173-15-lee.jones@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Rid W=1 warnings from LED | expand |
Hi! > Needs updating by the author to re-promote. > > Fixes the following W=1 kernel build warning(s): > > drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'boost_ctrl' not described in 'lm3692x_led' > drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'brightness_ctrl' not described in 'lm3692x_led' > drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'enabled' not described in 'lm3692x_led' > I'm not taking this one. I wanted to take the rest, but "leds: tlc591xx: fix return value check in tlc591xx_probe()" did not apply. I took the rest. Thanks and best regards, Pavel -- http://www.livejournal.com/~pavelmachek
On Fri, 28 May 2021, Pavel Machek wrote: > Hi! > > > Needs updating by the author to re-promote. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'boost_ctrl' not described in 'lm3692x_led' > > drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'brightness_ctrl' not described in 'lm3692x_led' > > drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'enabled' not described in 'lm3692x_led' > > > > I'm not taking this one. You didn't say why. > I wanted to take the rest, but "leds: > tlc591xx: fix return value check in tlc591xx_probe()" did not apply. I will rebase on today's -next and resubmit. > I took the rest. Thank you. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c index a2ab6bd5de111..f386766b2c4c1 100644 --- a/drivers/leds/leds-lm3692x.c +++ b/drivers/leds/leds-lm3692x.c @@ -95,7 +95,7 @@ #define LM3692X_FAULT_FLAG_SHRT BIT(3) #define LM3692X_FAULT_FLAG_OPEN BIT(4) -/** +/* * struct lm3692x_led * @lock: Lock for reading/writing the device * @client: Pointer to the I2C client
Needs updating by the author to re-promote. Fixes the following W=1 kernel build warning(s): drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'boost_ctrl' not described in 'lm3692x_led' drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'brightness_ctrl' not described in 'lm3692x_led' drivers/leds/leds-lm3692x.c:121: warning: Function parameter or member 'enabled' not described in 'lm3692x_led' Cc: Pavel Machek <pavel@ucw.cz> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Dan Murphy <dmurphy@ti.com> Cc: linux-leds@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/leds/leds-lm3692x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1