mbox series

[0/6] dt-bindings: i2c: renesas: Convert to json-schema

Message ID cover.1620138454.git.geert+renesas@glider.be
Headers show
Series dt-bindings: i2c: renesas: Convert to json-schema | expand

Message

Geert Uytterhoeven May 4, 2021, 2:51 p.m. UTC 
Hi all,

This patch series converts the DT bindings for the various I2C
controllers found in Renesas SoCs to json-schema, after a small cleanup
to ease the conversion.

The trickiest part is the conversion for renesas,iic, as it's not clear
to me which IIC instances have the automatic transmission registers and
which don't.  Whatever the outcome, passing validation for this variant
will require DTS changes.

Thanks for your comments!

Geert Uytterhoeven (6):
  i2c: rcar: Drop "renesas,i2c-rcar"
  dt-bindings: i2c: renesas,i2c: Drop "renesas,i2c-rcar"
  dt-bindings: i2c: renesas,i2c: Convert to json-schema
  [RFC] dt-bindings: i2c: renesas,iic: Convert to json-schema
  dt-bindings: i2c: renesas,riic: Convert to json-schema
  dt-bindings: i2c: renesas,iic-emev2: Convert to json-schema

 .../devicetree/bindings/i2c/renesas,i2c.txt   |  67 --------
 .../bindings/i2c/renesas,iic-emev2.txt        |  22 ---
 .../bindings/i2c/renesas,iic-emev2.yaml       |  54 ++++++
 .../devicetree/bindings/i2c/renesas,iic.txt   |  72 --------
 .../bindings/i2c/renesas,rcar-i2c.yaml        | 158 +++++++++++++++++
 .../devicetree/bindings/i2c/renesas,riic.txt  |  32 ----
 .../devicetree/bindings/i2c/renesas,riic.yaml |  83 +++++++++
 .../bindings/i2c/renesas,rmobile-iic.yaml     | 160 ++++++++++++++++++
 MAINTAINERS                                   |   8 +-
 drivers/i2c/busses/i2c-rcar.c                 |   1 -
 10 files changed, 459 insertions(+), 198 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/renesas,i2c.txt
 delete mode 100644 Documentation/devicetree/bindings/i2c/renesas,iic-emev2.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/renesas,iic-emev2.yaml
 delete mode 100644 Documentation/devicetree/bindings/i2c/renesas,iic.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
 delete mode 100644 Documentation/devicetree/bindings/i2c/renesas,riic.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/renesas,riic.yaml
 create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rmobile-iic.yaml

Comments

Rob Herring May 4, 2021, 2:42 p.m. UTC | #1 
On Tue, May 4, 2021 at 9:36 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>         Hi all,
>
> This patch series converts the DT bindings for the various I2C
> controllers found in Renesas SoCs to json-schema, after a small cleanup
> to ease the conversion.

You missed the DT list. Can you resend please.

Rob
Wolfram Sang May 5, 2021, 7:18 a.m. UTC | #2 
On Tue, May 04, 2021 at 04:35:53PM +0200, Geert Uytterhoeven wrote:
> The compatible value "renesas,i2c-rcar" was deprecated in commit

> ad4a8dc3fec6485b ("i2c: rcar: Add per-Generation fallback bindings"),

> and never had any users in upstream Linux.  Drop its match entry from

> the driver.

> 

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>


If there were never upstream users, I also think we can remove it.
Still, I'd feel better with an ack from Rob.

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Geert Uytterhoeven May 7, 2021, 6:56 a.m. UTC | #3 
Hi Rob,

On Thu, May 6, 2021 at 10:56 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, May 04, 2021 at 04:51:12PM +0200, Geert Uytterhoeven wrote:
> > Convert the Renesas RZ/A I2C Bus Interface (RIIC) Device Tree binding
> > documentation to json-schema.
> >
> > Document missing properties.
> > Update the example to match reality.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml

> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
>
> Don't need oneOf here with only 1 entry. Otherwise,

Thanks, dropping for v2.

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang May 28, 2021, 7:55 a.m. UTC | #4 
On Tue, May 04, 2021 at 04:35:53PM +0200, Geert Uytterhoeven wrote:
> The compatible value "renesas,i2c-rcar" was deprecated in commit

> ad4a8dc3fec6485b ("i2c: rcar: Add per-Generation fallback bindings"),

> and never had any users in upstream Linux.  Drop its match entry from

> the driver.

> 

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>


Applied to for-next, thanks!
Wolfram Sang May 28, 2021, 7:56 a.m. UTC | #5 
> > Don't need oneOf here with only 1 entry. Otherwise,

> 

> Thanks, dropping for v2.


Waiting for v2 here.