mbox series

[v2,00/28] Convert floatx80 and float128 to FloatParts

Message ID 20210525150706.294968-1-richard.henderson@linaro.org
Headers show
Series Convert floatx80 and float128 to FloatParts | expand

Message

Richard Henderson May 25, 2021, 3:06 p.m. UTC 
Changes for v2:
  * Merged 48 of 72 patches.
  * Fixed minmax regression (david)
    Unfortunately, berkeley-testfloat-3 does not have minmax,
    and it didn't look trivial to add.  In the end I simply
    tested an aarch64 guest minmax operations.
  * New patch to perform int->float conversions using hardfloat
    if possible.  Our conversion to gitlab issues passed this
    enhancement request past my eyes again.


r~


Alex Bennée (1):
  tests/fp: Enable more tests

Richard Henderson (27):
  softfloat: Move round_to_uint_and_pack to softfloat-parts.c.inc
  softfloat: Move int_to_float to softfloat-parts.c.inc
  softfloat: Move uint_to_float to softfloat-parts.c.inc
  softfloat: Move minmax_flags to softfloat-parts.c.inc
  softfloat: Move compare_floats to softfloat-parts.c.inc
  softfloat: Move scalbn_decomposed to softfloat-parts.c.inc
  softfloat: Move sqrt_float to softfloat-parts.c.inc
  softfloat: Split out parts_uncanon_normal
  softfloat: Reduce FloatFmt
  softfloat: Introduce Floatx80RoundPrec
  softfloat: Adjust parts_uncanon_normal for floatx80
  tests/fp/fp-test: Reverse order of floatx80 precision tests
  softfloat: Convert floatx80_add/sub to FloatParts
  softfloat: Convert floatx80_mul to FloatParts
  softfloat: Convert floatx80_div to FloatParts
  softfloat: Convert floatx80_sqrt to FloatParts
  softfloat: Convert floatx80_round to FloatParts
  softfloat: Convert floatx80_round_to_int to FloatParts
  softfloat: Convert integer to floatx80 to FloatParts
  softfloat: Convert floatx80 float conversions to FloatParts
  softfloat: Convert floatx80 to integer to FloatParts
  softfloat: Convert floatx80_scalbn to FloatParts
  softfloat: Convert floatx80 compare to FloatParts
  softfloat: Convert float32_exp2 to FloatParts
  softfloat: Move floatN_log2 to softfloat-parts.c.inc
  softfloat: Convert modrem operations to FloatParts
  softfloat: Use hard-float for {u}int64_to_float{32,64}

 include/fpu/softfloat-helpers.h |    5 +-
 include/fpu/softfloat-macros.h  |   34 +
 include/fpu/softfloat-types.h   |   10 +-
 include/fpu/softfloat.h         |    4 +-
 fpu/softfloat.c                 | 4432 ++++++++-----------------------
 linux-user/arm/nwfpe/fpa11.c    |   41 +-
 target/i386/tcg/fpu_helper.c    |   79 +-
 target/m68k/fpu_helper.c        |   50 +-
 target/m68k/softfloat.c         |   90 +-
 tests/fp/fp-test-log2.c         |  118 +
 tests/fp/fp-test.c              |    9 +-
 fpu/softfloat-parts.c.inc       |  899 ++++++-
 fpu/softfloat-specialize.c.inc  |  340 ---
 tests/fp/wrap.c.inc             |    2 +-
 tests/fp/meson.build            |   27 +-
 15 files changed, 2245 insertions(+), 3895 deletions(-)
 create mode 100644 tests/fp/fp-test-log2.c

-- 
2.25.1

Comments

no-reply@patchew.org May 25, 2021, 4:51 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20210525150706.294968-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210525150706.294968-1-richard.henderson@linaro.org
Subject: [PATCH v2 00/28] Convert floatx80 and float128 to FloatParts

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   0dab1d3..92f8c6f  master     -> master
 - [tag update]      patchew/20210525134458.6675-1-peter.maydell@linaro.org -> patchew/20210525134458.6675-1-peter.maydell@linaro.org
 * [new tag]         patchew/20210525150706.294968-1-richard.henderson@linaro.org -> patchew/20210525150706.294968-1-richard.henderson@linaro.org
Switched to a new branch 'test'
0f077a6 softfloat: Use hard-float for {u}int64_to_float{32, 64}
abdc56a tests/fp: Enable more tests
90ebc91 softfloat: Convert modrem operations to FloatParts
5e7da03 softfloat: Move floatN_log2 to softfloat-parts.c.inc
618addc softfloat: Convert float32_exp2 to FloatParts
14dd687 softfloat: Convert floatx80 compare to FloatParts
6bce5a6 softfloat: Convert floatx80_scalbn to FloatParts
d97aad0 softfloat: Convert floatx80 to integer to FloatParts
2c98bf7 softfloat: Convert floatx80 float conversions to FloatParts
0aa9a19 softfloat: Convert integer to floatx80 to FloatParts
004e7d5 softfloat: Convert floatx80_round_to_int to FloatParts
8eb0f0f softfloat: Convert floatx80_round to FloatParts
4a12947 softfloat: Convert floatx80_sqrt to FloatParts
04b9728 softfloat: Convert floatx80_div to FloatParts
00a81f5 softfloat: Convert floatx80_mul to FloatParts
290458a softfloat: Convert floatx80_add/sub to FloatParts
b29bb0d tests/fp/fp-test: Reverse order of floatx80 precision tests
6799791 softfloat: Adjust parts_uncanon_normal for floatx80
788d0fa softfloat: Introduce Floatx80RoundPrec
ea9f90a softfloat: Reduce FloatFmt
8b7c749 softfloat: Split out parts_uncanon_normal
6e46f7a softfloat: Move sqrt_float to softfloat-parts.c.inc
53563e4 softfloat: Move scalbn_decomposed to softfloat-parts.c.inc
e5ea67c softfloat: Move compare_floats to softfloat-parts.c.inc
d03d501 softfloat: Move minmax_flags to softfloat-parts.c.inc
1db2bf4 softfloat: Move uint_to_float to softfloat-parts.c.inc
b37889b softfloat: Move int_to_float to softfloat-parts.c.inc
52b5170 softfloat: Move round_to_uint_and_pack to softfloat-parts.c.inc

=== OUTPUT BEGIN ===
1/28 Checking commit 52b5170f8ce8 (softfloat: Move round_to_uint_and_pack to softfloat-parts.c.inc)
2/28 Checking commit b37889badd97 (softfloat: Move int_to_float to softfloat-parts.c.inc)
3/28 Checking commit 1db2bf401a92 (softfloat: Move uint_to_float to softfloat-parts.c.inc)
4/28 Checking commit d03d501737a1 (softfloat: Move minmax_flags to softfloat-parts.c.inc)
5/28 Checking commit e5ea67cc47c6 (softfloat: Move compare_floats to softfloat-parts.c.inc)
6/28 Checking commit 53563e40e3d9 (softfloat: Move scalbn_decomposed to softfloat-parts.c.inc)
7/28 Checking commit 6e46f7a30760 (softfloat: Move sqrt_float to softfloat-parts.c.inc)
8/28 Checking commit 8b7c7497d507 (softfloat: Split out parts_uncanon_normal)
9/28 Checking commit ea9f90a27773 (softfloat: Reduce FloatFmt)
10/28 Checking commit 788d0fa8f439 (softfloat: Introduce Floatx80RoundPrec)
11/28 Checking commit 6799791547b9 (softfloat: Adjust parts_uncanon_normal for floatx80)
12/28 Checking commit b29bb0d96d17 (tests/fp/fp-test: Reverse order of floatx80 precision tests)
13/28 Checking commit 290458a828d1 (softfloat: Convert floatx80_add/sub to FloatParts)
14/28 Checking commit 00a81f53fca8 (softfloat: Convert floatx80_mul to FloatParts)
15/28 Checking commit 04b9728b5777 (softfloat: Convert floatx80_div to FloatParts)
16/28 Checking commit 4a12947235c9 (softfloat: Convert floatx80_sqrt to FloatParts)
17/28 Checking commit 8eb0f0fc3e41 (softfloat: Convert floatx80_round to FloatParts)
18/28 Checking commit 004e7d54510c (softfloat: Convert floatx80_round_to_int to FloatParts)
19/28 Checking commit 0aa9a1995443 (softfloat: Convert integer to floatx80 to FloatParts)
20/28 Checking commit 2c98bf75821a (softfloat: Convert floatx80 float conversions to FloatParts)
21/28 Checking commit d97aad065132 (softfloat: Convert floatx80 to integer to FloatParts)
22/28 Checking commit 6bce5a65cf2e (softfloat: Convert floatx80_scalbn to FloatParts)
23/28 Checking commit 14dd6876c863 (softfloat: Convert floatx80 compare to FloatParts)
24/28 Checking commit 618addc4c22e (softfloat: Convert float32_exp2 to FloatParts)
25/28 Checking commit 5e7da037f221 (softfloat: Move floatN_log2 to softfloat-parts.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#325: 
new file mode 100644

ERROR: trailing whitespace
#376: FILE: tests/fp/fp-test-log2.c:47:
+   $

total: 1 errors, 1 warnings, 410 lines checked

Patch 25/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

26/28 Checking commit 90ebc91bd99f (softfloat: Convert modrem operations to FloatParts)
27/28 Checking commit abdc56a22643 (tests/fp: Enable more tests)
28/28 Checking commit 0f077a672e45 (softfloat: Use hard-float for {u}int64_to_float{32, 64})
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210525150706.294968-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com