diff mbox series

[net-next,09/13] dt-bindings: net: dsa: sja1105: add compatible strings for SJA1110

Message ID 20210524232214.1378937-10-olteanv@gmail.com
State New
Headers show
Series Add NXP SJA1110 support to the sja1105 DSA driver | expand

Commit Message

Vladimir Oltean May 24, 2021, 11:22 p.m. UTC 
From: Vladimir Oltean <vladimir.oltean@nxp.com>

There are 4 variations of the SJA1110 switch which have a different set
of MII protocols supported per port. Document the compatible strings.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 Documentation/devicetree/bindings/net/dsa/sja1105.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Florian Fainelli May 25, 2021, 2:24 a.m. UTC | #1 
On 5/24/2021 4:22 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>

> 

> There are 4 variations of the SJA1110 switch which have a different set

> of MII protocols supported per port. Document the compatible strings.

> 

> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>


Time to YAMLify that binding?
-- 
Florian
Vladimir Oltean May 25, 2021, 11:57 a.m. UTC | #2 
On Mon, May 24, 2021 at 07:24:36PM -0700, Florian Fainelli wrote:
> On 5/24/2021 4:22 PM, Vladimir Oltean wrote:

> > From: Vladimir Oltean <vladimir.oltean@nxp.com>

> >

> > There are 4 variations of the SJA1110 switch which have a different set

> > of MII protocols supported per port. Document the compatible strings.

> >

> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

>

> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

>

> Time to YAMLify that binding?


I'm afraid that will sidetrack in another discussion about
sja1105,role-mac and sja1105,role-phy which I'm not prepared to have
right now. Those boolean properties are to my knowledge unused, so I
could remove them, but the phy-mode = "mii" + sja1105,role-phy would
have to be replaced with phy-mode = "revmii" and similarly, a new
phy-mode would have to be introduced for phy-mode = "revrmii" or
something.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/sja1105.txt b/Documentation/devicetree/bindings/net/dsa/sja1105.txt
index 13fd21074d48..7029ae92daef 100644
--- a/Documentation/devicetree/bindings/net/dsa/sja1105.txt
+++ b/Documentation/devicetree/bindings/net/dsa/sja1105.txt
@@ -11,6 +11,10 @@  Required properties:
 	- "nxp,sja1105q"
 	- "nxp,sja1105r"
 	- "nxp,sja1105s"
+	- "nxp,sja1110a"
+	- "nxp,sja1110b"
+	- "nxp,sja1110c"
+	- "nxp,sja1110d"
 
 	Although the device ID could be detected at runtime, explicit bindings
 	are required in order to be able to statically check their validity.