| Message ID | 1620636848-38909-1-git-send-email-tanghui20@huawei.com |
|---|---|
| State | Accepted |
| Commit | 2d016672528a592ada5188e53ac746e1b8b7a978 |
| Headers | show |
| Series | crypto: testmgr - fix initialization of 'secret_size' | expand |
On Mon, May 10, 2021 at 04:54:08PM +0800, Hui Tang wrote: > Actual data length of the 'secret' is not equal to the 'secret_size'. > > Since the 'curve_id' has removed in the 'secret', the 'secret_size' > should subtract the length of the 'curve_id'. > > Fixes: 6763f5ea2d9a(crypto: ecdh - move curve_id of ECDH from ...) > > Signed-off-by: Hui Tang <tanghui20@huawei.com> > --- > crypto/testmgr.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/crypto/testmgr.h b/crypto/testmgr.h index 34e4a3d..aead75d 100644 --- a/crypto/testmgr.h +++ b/crypto/testmgr.h @@ -2719,7 +2719,7 @@ static const struct kpp_testvec ecdh_p192_tv_template[] = { "\xf4\x57\xcc\x4f\x1f\x4e\x31\xcc" "\xe3\x40\x60\xc8\x06\x93\xc6\x2e" "\x99\x80\x81\x28\xaf\xc5\x51\x74", - .secret_size = 32, + .secret_size = 30, .b_public_size = 48, .expected_a_public_size = 48, .expected_ss_size = 24 @@ -2766,7 +2766,7 @@ static const struct kpp_testvec ecdh_p256_tv_template[] = { "\x9f\x4a\x38\xcc\xc0\x2c\x49\x2f" "\xb1\x32\xbb\xaf\x22\x61\xda\xcb" "\x6f\xdb\xa9\xaa\xfc\x77\x81\xf3", - .secret_size = 40, + .secret_size = 38, .b_public_size = 64, .expected_a_public_size = 64, .expected_ss_size = 32 @@ -2804,8 +2804,8 @@ static const struct kpp_testvec ecdh_p256_tv_template[] = { "\x37\x08\xcc\x40\x5e\x7a\xfd\x6a" "\x6a\x02\x6e\x41\x87\x68\x38\x77" "\xfa\xa9\x44\x43\x2d\xef\x09\xdf", - .secret_size = 8, - .b_secret_size = 40, + .secret_size = 6, + .b_secret_size = 38, .b_public_size = 64, .expected_a_public_size = 64, .expected_ss_size = 32,
Actual data length of the 'secret' is not equal to the 'secret_size'. Since the 'curve_id' has removed in the 'secret', the 'secret_size' should subtract the length of the 'curve_id'. Fixes: 6763f5ea2d9a(crypto: ecdh - move curve_id of ECDH from ...) Signed-off-by: Hui Tang <tanghui20@huawei.com> --- crypto/testmgr.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.8.1