| Message ID | 20210520121347.3467794-1-lee.jones@linaro.org |
|---|---|
| Headers | show |
| Series | Rid W=1 warnings from Char | expand |
On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (16): > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > char: random: Include header containing our prototypes > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > 'byte_reset_it' > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > char: agp: backend: Demote some non-conformant kernel-doc headers > char: agp: frontend: Include header file containing our prototypes > char: agp: via-agp: Remove unused variable 'current_size' > char: hpet: Remove unused variable 'm' > char: agp: generic: Place braces around optimised out function in if() > char: agp: uninorth-agp: Remove unused variable 'size' > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > char: mem: Provide local prototype for non-static function Thanks a lot! I've looked all the patches now and commented on patches 6 and 16. With my comments addressed Reviewed-by: Arnd Bergmann <arnd@arndb.de> Arnd
On Thu, 20 May 2021, Arnd Bergmann wrote: > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (16): > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > char: random: Include header containing our prototypes > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > 'byte_reset_it' > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > char: agp: backend: Demote some non-conformant kernel-doc headers > > char: agp: frontend: Include header file containing our prototypes > > char: agp: via-agp: Remove unused variable 'current_size' > > char: hpet: Remove unused variable 'm' > > char: agp: generic: Place braces around optimised out function in if() > > char: agp: uninorth-agp: Remove unused variable 'size' > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > char: mem: Provide local prototype for non-static function > > Thanks a lot! > > I've looked all the patches now and commented on patches 6 and 16. > With my comments addressed > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> Thanks Arnd. Would it be possible for the remaining 14 patches to be taken in please? I will work on the 2 Arnd commented on in due course and resubmit them independently. TIA. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > > > > > > Lee Jones (16): > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > char: random: Include header containing our prototypes > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > 'byte_reset_it' > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > char: agp: frontend: Include header file containing our prototypes > > > char: agp: via-agp: Remove unused variable 'current_size' > > > char: hpet: Remove unused variable 'm' > > > char: agp: generic: Place braces around optimised out function in if() > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > > char: mem: Provide local prototype for non-static function > > > > Thanks a lot! > > > > I've looked all the patches now and commented on patches 6 and 16. > > With my comments addressed > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > Thanks Arnd. > > Would it be possible for the remaining 14 patches to be taken in > please? I will work on the 2 Arnd commented on in due course and > resubmit them independently. Yes, I can queue them up, thanks. greg k-h
On Fri, May 21, 2021 at 09:42:29AM +0200, Greg Kroah-Hartman wrote: > On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > Lee Jones (16): > > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > > char: random: Include header containing our prototypes > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > > 'byte_reset_it' > > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > > char: agp: frontend: Include header file containing our prototypes > > > > char: agp: via-agp: Remove unused variable 'current_size' > > > > char: hpet: Remove unused variable 'm' > > > > char: agp: generic: Place braces around optimised out function in if() > > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > > > char: mem: Provide local prototype for non-static function > > > > > > Thanks a lot! > > > > > > I've looked all the patches now and commented on patches 6 and 16. > > > With my comments addressed > > > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > > > Thanks Arnd. > > > > Would it be possible for the remaining 14 patches to be taken in > > please? I will work on the 2 Arnd commented on in due course and > > resubmit them independently. > > Yes, I can queue them up, thanks. Wait, I can take the ones for code that I maintain, not for others. drivers/char/ is "fun" in that some subdirs have active trees/maintainers that are not me and Arnd so they go to Linus through other ways. I'll queue up the ones that I am "allowed" to and you will get the emails from that. thanks, greg k-h
On Fri, 21 May 2021, Greg Kroah-Hartman wrote: > On Fri, May 21, 2021 at 09:42:29AM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > > > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > > > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > niggly little warnings. > > > > > > > > > > Lee Jones (16): > > > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > > > char: random: Include header containing our prototypes > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > > > 'byte_reset_it' > > > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > > > char: agp: frontend: Include header file containing our prototypes > > > > > char: agp: via-agp: Remove unused variable 'current_size' > > > > > char: hpet: Remove unused variable 'm' > > > > > char: agp: generic: Place braces around optimised out function in if() > > > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > > > > char: mem: Provide local prototype for non-static function > > > > > > > > Thanks a lot! > > > > > > > > I've looked all the patches now and commented on patches 6 and 16. > > > > With my comments addressed > > > > > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > > > > > Thanks Arnd. > > > > > > Would it be possible for the remaining 14 patches to be taken in > > > please? I will work on the 2 Arnd commented on in due course and > > > resubmit them independently. > > > > Yes, I can queue them up, thanks. > > Wait, I can take the ones for code that I maintain, not for others. > drivers/char/ is "fun" in that some subdirs have active > trees/maintainers that are not me and Arnd so they go to Linus through > other ways. I'll queue up the ones that I am "allowed" to and you will > get the emails from that. Understood, thanks. Hopefully the other maintainers will be as on the ball as you are. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (16): char: pcmcia: cm4000_cs: Remove unused variable 'tmp' char: pcmcia: cm4040_cs: Remove unused variable 'uc' char: random: Include header containing our prototypes char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues char: applicom: Remove 3 unused variables 'ret' and 2 instances of 'byte_reset_it' char: tpm: tpm1-cmd: Fix a couple of misnamed functions char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours char: agp: backend: Demote some non-conformant kernel-doc headers char: agp: frontend: Include header file containing our prototypes char: agp: via-agp: Remove unused variable 'current_size' char: hpet: Remove unused variable 'm' char: agp: generic: Place braces around optimised out function in if() char: agp: uninorth-agp: Remove unused variable 'size' char: hw_random: pseries-rng: Demote non-conformant kernel-doc header char: mem: Provide local prototype for non-static function drivers/char/agp/backend.c | 4 +- drivers/char/agp/frontend.c | 1 + drivers/char/agp/generic.c | 3 +- drivers/char/agp/uninorth-agp.c | 3 -- drivers/char/agp/via-agp.c | 3 -- drivers/char/applicom.c | 10 ++-- drivers/char/hpet.c | 4 +- drivers/char/hw_random/pseries-rng.c | 2 +- drivers/char/mem.c | 2 + drivers/char/pcmcia/cm4000_cs.c | 3 +- drivers/char/pcmcia/cm4040_cs.c | 3 +- drivers/char/pcmcia/synclink_cs.c | 74 +++++++++++++++------------- drivers/char/random.c | 1 + drivers/char/tpm/tpm1-cmd.c | 4 +- drivers/char/tpm/tpm_ftpm_tee.c | 6 +-- 15 files changed, 60 insertions(+), 63 deletions(-) Cc: Arnd Bergmann <arnd@arndb.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Bob Picco <robert.picco@hp.com> Cc: Clemens Ladisch <clemens@ladisch.de> Cc: "C. Scott Ananian" <cananian@alumni.princeton.edu> Cc: "cs.c" <support.linux@omnikey.com> Cc: Dave Safford <safford@watson.ibm.com> Cc: David Airlie <airlied@linux.ie> Cc: dwmw2@infradead.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Harald Welte <laforge@gnumonks.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Jarkko Sakkinen <jarkko@kernel.org> Cc: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Jerome Glisse <j.glisse@gmail.com> Cc: Kanoj Sarcar <kanoj@sgi.com> Cc: Kylene Hall <kjhall@us.ibm.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Lijun Pan <ljp@linux.ibm.com> Cc: linux-crypto@vger.kernel.org Cc: linux-integrity@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Matt Mackall <mpm@selenic.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Michael Neuling <mikey@neuling.org> Cc: paulkf@microgate.com Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Huewe <peterhuewe@gmx.de> Cc: Reiner Sailer <sailer@watson.ibm.com> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Thirupathaiah Annapureddy <thiruan@microsoft.com> Cc: Tyrel Datwyler <tyreld@linux.ibm.com> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org> Cc: van Doorn <leendert@watson.ibm.com> -- 2.31.1