Message ID | 20210519033202.3245667-1-dqfext@gmail.com |
---|---|
Headers | show |
Series | MT7530 interrupt support | expand |
> +static void mtk_gephy_config_init(struct phy_device *phydev) > +{ > + /* Disable EEE */ > + phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); Is EEE broken on this PHY? Or is this just to get it into a defined state? Otherwise Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Thu, May 20, 2021 at 02:59:21AM +0200, Andrew Lunn wrote: > > +static void mtk_gephy_config_init(struct phy_device *phydev) > > +{ > > + /* Disable EEE */ > > + phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); > > Is EEE broken on this PHY? Or is this just to get it into a defined > state? As I said in commit message, the initialization (including EEE) is from the vendor driver. I have also tested it with EEE enabled by default on one of my APs, and got occasional link drops. > > Otherwise > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Andrew
On Thu, 2021-05-20 at 10:38 +0800, DENG Qingfang wrote: > On Thu, May 20, 2021 at 02:59:21AM +0200, Andrew Lunn wrote: > > > +static void mtk_gephy_config_init(struct phy_device *phydev) > > > +{ > > > + /* Disable EEE */ > > > + phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); > > > > Is EEE broken on this PHY? Or is this just to get it into a defined > > state? > > As I said in commit message, the initialization (including EEE) is > from the vendor driver. > I have also tested it with EEE enabled by default on one of my APs, > and got occasional link drops. > EEE of the 10-year-old MT7530 internal gephy has many IOT problems, so it is recommended to disable its EEE. EEE of the MT7531 internal gephy has been updated, but it is not yet widely used. Therefore, EEE is disabled in vendor driver. Landen > > Otherwise > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > > > Andrew
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 19 May 2021 11:31:58 +0800 you wrote: > Add support for MT7530 interrupt controller. > > DENG Qingfang (4): > net: phy: add MediaTek Gigabit Ethernet PHY driver > net: dsa: mt7530: add interrupt support > dt-bindings: net: dsa: add MT7530 interrupt controller binding > staging: mt7621-dts: enable MT7530 interrupt controller > > [...] Here is the summary with links: - [net-next,v2,1/4] net: phy: add MediaTek Gigabit Ethernet PHY driver https://git.kernel.org/netdev/net-next/c/e40d2cca0189 - [net-next,v2,2/4] net: dsa: mt7530: add interrupt support https://git.kernel.org/netdev/net-next/c/ba751e28d442 - [net-next,v2,3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding https://git.kernel.org/netdev/net-next/c/4006f986c091 - [net-next,v2,4/4] staging: mt7621-dts: enable MT7530 interrupt controller https://git.kernel.org/netdev/net-next/c/f494f0935ffb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html