mbox series

[0/5] crypto: add gemini/sl3516 crypto driver

Message ID 20210518151655.125153-1-clabbe@baylibre.com
Headers show
Series crypto: add gemini/sl3516 crypto driver | expand

Message

Corentin Labbe May 18, 2021, 3:16 p.m. UTC 
The gemini SL3516 SoC has a crypto IP.
This serie had support for it.

Corentin Labbe (5):
  db-dinding: crypto: Add DT bindings documentation for sl3516-ce
  crypto: Add sl3516 crypto engine
  ARM: dts: gemini: add crypto node
  ARM: gemini_config: enable sl3516-ce crypto
  MAINTAINERS: add gemini crypto sl3516-ce

 .../crypto/cortina,sl3516-crypto.yaml         |  50 ++
 MAINTAINERS                                   |   7 +
 arch/arm/boot/dts/gemini.dtsi                 |   8 +
 arch/arm/configs/gemini_defconfig             |   1 +
 drivers/crypto/Kconfig                        |  19 +
 drivers/crypto/Makefile                       |   1 +
 drivers/crypto/gemini/Makefile                |   2 +
 drivers/crypto/gemini/sl3516-ce-cipher.c      | 388 +++++++++++++
 drivers/crypto/gemini/sl3516-ce-core.c        | 535 ++++++++++++++++++
 drivers/crypto/gemini/sl3516-ce-rng.c         |  61 ++
 drivers/crypto/gemini/sl3516-ce.h             | 349 ++++++++++++
 11 files changed, 1421 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/cortina,sl3516-crypto.yaml
 create mode 100644 drivers/crypto/gemini/Makefile
 create mode 100644 drivers/crypto/gemini/sl3516-ce-cipher.c
 create mode 100644 drivers/crypto/gemini/sl3516-ce-core.c
 create mode 100644 drivers/crypto/gemini/sl3516-ce-rng.c
 create mode 100644 drivers/crypto/gemini/sl3516-ce.h

Comments

Eric Biggers May 19, 2021, 6:39 p.m. UTC | #1 
On Tue, May 18, 2021 at 03:16:50PM +0000, Corentin Labbe wrote:
> The gemini SL3516 SoC has a crypto IP.
> This serie had support for it.
> 

Please describe how this was tested.

- Eric
Rob Herring (Arm) May 20, 2021, 12:04 a.m. UTC | #2 
On Tue, May 18, 2021 at 11:38:38PM +0200, Linus Walleij wrote:
> On Tue, May 18, 2021 at 5:17 PM Corentin Labbe <clabbe@baylibre.com> wrote:
> 
> > This patch adds documentation for Device-Tree bindings for the
> > SL3516-ce cryptographic offloader driver.
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> 
> Apart from misspelled subject "db-binding" I don't see any problems
> so

And try not to say 'dt binding' twice in the subject and 'documentation' 
is redundant as that's all bindings.

> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> Yours,
> Linus Walleij
Corentin Labbe May 20, 2021, 11:39 a.m. UTC | #3 
Le Wed, May 19, 2021 at 11:39:23AM -0700, Eric Biggers a écrit :
> On Tue, May 18, 2021 at 03:16:50PM +0000, Corentin Labbe wrote:

> > The gemini SL3516 SoC has a crypto IP.

> > This serie had support for it.

> > 

> 

> Please describe how this was tested.


Sorry I forgot to write it.
It was tested with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y.
Furthermore, it survives hours and gigs of write/read to a luks2 using xts(ecb-aes-sl3516).

I forgot also to write on performance, which is quite good.
On a luks2 partition (2To with bs=4096), a fsck comes from 14m26(without CE) to 8m48(with CE).
So it is really usefull.

With bs=512, the performance is similar with software.

Regards