diff mbox series

[5.10,041/289] i2c: Add I2C_AQ_NO_REP_START adapter quirk

Message ID 20210517140306.584198139@linuxfoundation.org
State Superseded
Headers show
Series None | expand

Commit Message

Greg KH May 17, 2021, 1:59 p.m. UTC
From: Bence Csókás <bence98@sch.bme.hu>

[ Upstream commit aca01415e076aa96cca0f801f4420ee5c10c660d ]

This quirk signifies that the adapter cannot do a repeated
START, it always issues a STOP condition after transfers.

Suggested-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Bence Csókás <bence98@sch.bme.hu>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 include/linux/i2c.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Pavel Machek May 19, 2021, 8:13 p.m. UTC | #1
On Mon 2021-05-17 15:59:26, Greg Kroah-Hartman wrote:
> From: Bence Csókás <bence98@sch.bme.hu>

> 

> [ Upstream commit aca01415e076aa96cca0f801f4420ee5c10c660d ]

> 

> This quirk signifies that the adapter cannot do a repeated

> START, it always issues a STOP condition after transfers.

> 

> Suggested-by: Wolfram Sang <wsa@kernel.org>

> Signed-off-by: Bence Csókás <bence98@sch.bme.hu>

> Signed-off-by: Wolfram Sang <wsa@kernel.org>

> Signed-off-by: Sasha Levin <sashal@kernel.org>


Why is this pushed to 5.10 and 4.19? The define is not used anywhere
AFAICT.

Best regards,
							Pavel
							
> +++ b/include/linux/i2c.h

> @@ -687,6 +687,8 @@ struct i2c_adapter_quirks {

> +/* adapter cannot do repeated START */

> +#define I2C_AQ_NO_REP_START		BIT(7)


-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
diff mbox series

Patch

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 56622658b215..a670ae129f4b 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -687,6 +687,8 @@  struct i2c_adapter_quirks {
 #define I2C_AQ_NO_ZERO_LEN_READ		BIT(5)
 #define I2C_AQ_NO_ZERO_LEN_WRITE	BIT(6)
 #define I2C_AQ_NO_ZERO_LEN		(I2C_AQ_NO_ZERO_LEN_READ | I2C_AQ_NO_ZERO_LEN_WRITE)
+/* adapter cannot do repeated START */
+#define I2C_AQ_NO_REP_START		BIT(7)
 
 /*
  * i2c_adapter is the structure used to identify a physical i2c bus along