| Message ID | 20210518090720.21915-1-alex.bennee@linaro.org |
|---|---|
| Headers | show |
| Series | testing and plugin updates | expand |
Patchew URL: https://patchew.org/QEMU/20210518090720.21915-1-alex.bennee@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210518090720.21915-1-alex.bennee@linaro.org
Subject: [PULL v2 00/29] testing and plugin updates
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210514151342.384376-1-richard.henderson@linaro.org -> patchew/20210514151342.384376-1-richard.henderson@linaro.org
- [tag update] patchew/20210517084055.24792-1-davoronetskiy@gmail.com -> patchew/20210517084055.24792-1-davoronetskiy@gmail.com
- [tag update] patchew/20210517121908.2624991-1-pbonzini@redhat.com -> patchew/20210517121908.2624991-1-pbonzini@redhat.com
- [tag update] patchew/20210517183954.1223193-1-philmd@redhat.com -> patchew/20210517183954.1223193-1-philmd@redhat.com
* [new tag] patchew/20210518090720.21915-1-alex.bennee@linaro.org -> patchew/20210518090720.21915-1-alex.bennee@linaro.org
* [new tag] patchew/20210518092352.43610-1-thatlemon@gmail.com -> patchew/20210518092352.43610-1-thatlemon@gmail.com
Switched to a new branch 'test'
53fa360 configure: use cc, not host_cc to set cross_cc for build arch
8d18fbc tests/tcg: don't allow clang as a cross compiler
9ecaa15 tests/tcg: fix missing return
d09604a tests/tcg/ppc64le: tests for brh/brw/brd
86d8dfa tests/docker: gcc-10 based images for ppc64{, le} tests
07c7406 tests/tcg/tricore: Add muls test
b8effdc tests/tcg/tricore: Add msub test
bd850be tests/tcg/tricore: Add madd test
10c3549 tests/tcg/tricore: Add ftoi test
7554856 tests/tcg/tricore: Add fmul test
f7daca6 tests/tcg/tricore: Add fadd test
4531665 tests/tcg/tricore: Add dvstep test
e83079f tests/tcg/tricore: Add clz test
bb6e9e6 tests/tcg/tricore: Add bmerge test
5325639 tests/tcg/tricore: Add macros to create tests and first test 'abs'
b8c8ff4 configure: Emit HOST_CC to config-host.mak
7cc91e7 tests/tcg/tricore: Add build infrastructure
3a44a14 hw/tricore: Add testdevice for tests in tests/tcg/
380656c tests/tcg: Run timeout cmds using --foreground
8e9da44 tests/tcg: Add docker_as and docker_ld cmds
b24d795 tests/docker: Added libbpf library to the docker files.
52f2bd2 tests/tcg: don't iterate through other arch compilers
576f7f1 gitlab: add build-user-hexagon test
375951d tests/tcg: Use Hexagon Docker image
d79c5c5 docker: Add Hexagon image
d8b71a8 tests/docker: add "fetch" sub-command
e09459e tests/docker: allow "update" to add the current user
e8ffae1 tests/docker: make executable an optional argument to "update"
e8f6d5f tests/docker: fix copying of executable in "update"
=== OUTPUT BEGIN ===
1/29 Checking commit e8f6d5fd8833 (tests/docker: fix copying of executable in "update")
2/29 Checking commit e8ffae13f86d (tests/docker: make executable an optional argument to "update")
3/29 Checking commit e09459e20f63 (tests/docker: allow "update" to add the current user)
4/29 Checking commit d8b71a8970c4 (tests/docker: add "fetch" sub-command)
5/29 Checking commit d79c5c54c9cf (docker: Add Hexagon image)
WARNING: line over 80 characters
#208: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63:
+ -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \
ERROR: line over 90 characters
#235: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90:
+ CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \
ERROR: line over 90 characters
#272: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127:
+ CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \
total: 2 errors, 1 warnings, 222 lines checked
Patch 5/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/29 Checking commit 375951decf4b (tests/tcg: Use Hexagon Docker image)
7/29 Checking commit 576f7f1e2010 (gitlab: add build-user-hexagon test)
8/29 Checking commit 52f2bd253948 (tests/tcg: don't iterate through other arch compilers)
9/29 Checking commit b24d79558115 (tests/docker: Added libbpf library to the docker files.)
10/29 Checking commit 8e9da4484f54 (tests/tcg: Add docker_as and docker_ld cmds)
11/29 Checking commit 380656c57796 (tests/tcg: Run timeout cmds using --foreground)
12/29 Checking commit 3a44a149ecb9 (hw/tricore: Add testdevice for tests in tests/tcg/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
new file mode 100644
total: 0 errors, 1 warnings, 152 lines checked
Patch 12/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/29 Checking commit 7cc91e708a6f (tests/tcg/tricore: Add build infrastructure)
14/29 Checking commit b8c8ff47dc26 (configure: Emit HOST_CC to config-host.mak)
15/29 Checking commit 53256392c0a2 (tests/tcg/tricore: Add macros to create tests and first test 'abs')
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#63:
new file mode 100644
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#69: FILE: tests/tcg/tricore/macros.h:2:
+#define LI(reg, val) \
+ mov.u reg, lo:val; \
+ movh DREG_TEMP_LI, up:val; \
+ or reg, reg, DREG_TEMP_LI; \
+
ERROR: spaces required around that ':' (ctx:VxV)
#70: FILE: tests/tcg/tricore/macros.h:3:
+ mov.u reg, lo:val; \
^
ERROR: spaces required around that ':' (ctx:VxV)
#71: FILE: tests/tcg/tricore/macros.h:4:
+ movh DREG_TEMP_LI, up:val; \
^
ERROR: spaces required around that '%' (ctx:WxV)
#77: FILE: tests/tcg/tricore/macros.h:10:
+#define DREG_RS1 %d0
^
ERROR: Macros with complex values should be enclosed in parenthesis
#77: FILE: tests/tcg/tricore/macros.h:10:
+#define DREG_RS1 %d0
ERROR: spaces required around that '%' (ctx:WxV)
#78: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_CALC_RESULT %d1
^
ERROR: Macros with complex values should be enclosed in parenthesis
#78: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_CALC_RESULT %d1
ERROR: spaces required around that '%' (ctx:WxV)
#79: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_TEMP_LI %d10
^
ERROR: Macros with complex values should be enclosed in parenthesis
#79: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_TEMP_LI %d10
ERROR: spaces required around that '%' (ctx:WxV)
#80: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_TEMP %d11
^
ERROR: Macros with complex values should be enclosed in parenthesis
#80: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_TEMP %d11
ERROR: spaces required around that '%' (ctx:WxV)
#81: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_TEST_NUM %d14
^
ERROR: Macros with complex values should be enclosed in parenthesis
#81: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_TEST_NUM %d14
ERROR: spaces required around that '%' (ctx:WxV)
#82: FILE: tests/tcg/tricore/macros.h:15:
+#define DREG_CORRECT_RESULT %d15
^
ERROR: Macros with complex values should be enclosed in parenthesis
#82: FILE: tests/tcg/tricore/macros.h:15:
+#define DREG_CORRECT_RESULT %d15
ERROR: spaces required around that '%' (ctx:WxV)
#84: FILE: tests/tcg/tricore/macros.h:17:
+#define DREG_DEV_ADDR %a15
^
ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: tests/tcg/tricore/macros.h:17:
+#define DREG_DEV_ADDR %a15
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#87: FILE: tests/tcg/tricore/macros.h:20:
+#define TEST_CASE(num, testreg, correct, code...) \
+test_ ## num: \
+ code; \
+ LI(DREG_CORRECT_RESULT, correct) \
+ mov DREG_TEST_NUM, num; \
+ jne testreg, DREG_CORRECT_RESULT, fail \
+
ERROR: spaces required around that ':' (ctx:VxE)
#88: FILE: tests/tcg/tricore/macros.h:21:
+test_ ## num: \
^
WARNING: Block comments use a leading /* on a separate line
#94: FILE: tests/tcg/tricore/macros.h:27:
+/* Actual test case type
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#106: FILE: tests/tcg/tricore/macros.h:39:
+#define TEST_PASSFAIL \
+ j pass; \
+fail: \
+ LI(DREG_TEMP, TESTDEV_ADDR) \
+ mov.a DREG_DEV_ADDR, DREG_TEMP; \
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+ debug; \
+ j fail; \
+pass: \
+ LI(DREG_TEMP, TESTDEV_ADDR) \
+ mov.a DREG_DEV_ADDR, DREG_TEMP; \
+ mov DREG_TEST_NUM, 0; \
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+ debug; \
+ j pass;
ERROR: space prohibited before open square bracket '['
#111: FILE: tests/tcg/tricore/macros.h:44:
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
ERROR: space prohibited before open square bracket '['
#118: FILE: tests/tcg/tricore/macros.h:51:
+ st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
total: 22 errors, 2 warnings, 80 lines checked
Patch 15/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/29 Checking commit bb6e9e6df023 (tests/tcg/tricore: Add bmerge test)
ERROR: spaces required around that '%' (ctx:WxV)
#40: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_RS2 %d1
^
ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_RS2 %d1
ERROR: spaces required around that '%' (ctx:WxV)
#42: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_CALC_PSW %d2
^
ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_CALC_PSW %d2
ERROR: spaces required around that '%' (ctx:WxV)
#43: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_CORRECT_PSW %d3
^
ERROR: Macros with complex values should be enclosed in parenthesis
#43: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_CORRECT_PSW %d3
ERROR: spaces required around that ':' (ctx:VxE)
#52: FILE: tests/tcg/tricore/macros.h:31:
+test_ ## num: \
^
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#83:
new file mode 100644
total: 7 errors, 1 warnings, 58 lines checked
Patch 16/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/29 Checking commit e83079f0aa4a (tests/tcg/tricore: Add clz test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
new file mode 100644
total: 0 errors, 1 warnings, 16 lines checked
Patch 17/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/29 Checking commit 45316650e7e6 (tests/tcg/tricore: Add dvstep test)
ERROR: spaces required around that '%' (ctx:WxV)
#40: FILE: tests/tcg/tricore/macros.h:22:
+#define EREG_RS1 %e6
^
ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: tests/tcg/tricore/macros.h:22:
+#define EREG_RS1 %e6
ERROR: spaces required around that '%' (ctx:WxV)
#41: FILE: tests/tcg/tricore/macros.h:23:
+#define EREG_RS1_LO %d6
^
ERROR: Macros with complex values should be enclosed in parenthesis
#41: FILE: tests/tcg/tricore/macros.h:23:
+#define EREG_RS1_LO %d6
ERROR: spaces required around that '%' (ctx:WxV)
#42: FILE: tests/tcg/tricore/macros.h:24:
+#define EREG_RS1_HI %d7
^
ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: tests/tcg/tricore/macros.h:24:
+#define EREG_RS1_HI %d7
ERROR: spaces required around that '%' (ctx:WxV)
#43: FILE: tests/tcg/tricore/macros.h:25:
+#define EREG_RS2 %e8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#43: FILE: tests/tcg/tricore/macros.h:25:
+#define EREG_RS2 %e8
ERROR: spaces required around that '%' (ctx:WxV)
#44: FILE: tests/tcg/tricore/macros.h:26:
+#define EREG_RS2_LO %d8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#44: FILE: tests/tcg/tricore/macros.h:26:
+#define EREG_RS2_LO %d8
ERROR: spaces required around that '%' (ctx:WxV)
#45: FILE: tests/tcg/tricore/macros.h:27:
+#define EREG_RS2_HI %d9
^
ERROR: Macros with complex values should be enclosed in parenthesis
#45: FILE: tests/tcg/tricore/macros.h:27:
+#define EREG_RS2_HI %d9
ERROR: spaces required around that '%' (ctx:WxV)
#46: FILE: tests/tcg/tricore/macros.h:28:
+#define EREG_CALC_RESULT %e8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#46: FILE: tests/tcg/tricore/macros.h:28:
+#define EREG_CALC_RESULT %e8
ERROR: spaces required around that '%' (ctx:WxV)
#47: FILE: tests/tcg/tricore/macros.h:29:
+#define EREG_CALC_RESULT_HI %d9
^
ERROR: Macros with complex values should be enclosed in parenthesis
#47: FILE: tests/tcg/tricore/macros.h:29:
+#define EREG_CALC_RESULT_HI %d9
ERROR: spaces required around that '%' (ctx:WxV)
#48: FILE: tests/tcg/tricore/macros.h:30:
+#define EREG_CALC_RESULT_LO %d8
^
ERROR: Macros with complex values should be enclosed in parenthesis
#48: FILE: tests/tcg/tricore/macros.h:30:
+#define EREG_CALC_RESULT_LO %d8
ERROR: spaces required around that '%' (ctx:WxV)
#49: FILE: tests/tcg/tricore/macros.h:31:
+#define EREG_CORRECT_RESULT_LO %d0
^
ERROR: Macros with complex values should be enclosed in parenthesis
#49: FILE: tests/tcg/tricore/macros.h:31:
+#define EREG_CORRECT_RESULT_LO %d0
ERROR: spaces required around that '%' (ctx:WxV)
#50: FILE: tests/tcg/tricore/macros.h:32:
+#define EREG_CORRECT_RESULT_HI %d1
^
ERROR: Macros with complex values should be enclosed in parenthesis
#50: FILE: tests/tcg/tricore/macros.h:32:
+#define EREG_CORRECT_RESULT_HI %d1
ERROR: spaces required around that ':' (ctx:VxE)
#60: FILE: tests/tcg/tricore/macros.h:43:
+test_ ## num: \
^
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#87:
new file mode 100644
total: 23 errors, 1 warnings, 69 lines checked
Patch 18/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/29 Checking commit f7daca63bf94 (tests/tcg/tricore: Add fadd test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 23 lines checked
Patch 19/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/29 Checking commit 7554856d96b4 (tests/tcg/tricore: Add fmul test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 15 lines checked
Patch 20/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/29 Checking commit 10c3549000fe (tests/tcg/tricore: Add ftoi test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51:
new file mode 100644
total: 0 errors, 1 warnings, 30 lines checked
Patch 21/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/29 Checking commit bd850bebc9b4 (tests/tcg/tricore: Add madd test)
ERROR: spaces required around that '%' (ctx:WxV)
#40: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_RS3 %d4
^
ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_RS3 %d4
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 2 errors, 1 warnings, 48 lines checked
Patch 22/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/29 Checking commit b8effdc5611a (tests/tcg/tricore: Add msub test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 16 lines checked
Patch 23/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/29 Checking commit 07c74061934c (tests/tcg/tricore: Add muls test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 16 lines checked
Patch 24/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/29 Checking commit 86d8dfa1e1a6 (tests/docker: gcc-10 based images for ppc64{, le} tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85:
deleted file mode 100644
total: 0 errors, 1 warnings, 96 lines checked
Patch 25/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/29 Checking commit d09604a6d20d (tests/tcg/ppc64le: tests for brh/brw/brd)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68:
new file mode 100644
total: 0 errors, 1 warnings, 55 lines checked
Patch 26/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/29 Checking commit 9ecaa15934ab (tests/tcg: fix missing return)
28/29 Checking commit 8d18fbcacab8 (tests/tcg: don't allow clang as a cross compiler)
WARNING: line over 80 characters
#86: FILE: tests/tcg/configure.sh:236:
+ # For host systems we might get away with building without -static
WARNING: line over 80 characters
#91: FILE: tests/tcg/configure.sh:241:
+ echo "CROSS_CC_GUEST=$target_compiler" >> $config_target_mak
total: 0 errors, 2 warnings, 67 lines checked
Patch 28/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/29 Checking commit 53fa36059f08 (configure: use cc, not host_cc to set cross_cc for build arch)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210518090720.21915-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Tue, 18 May 2021 at 10:07, Alex Bennée <alex.bennee@linaro.org> wrote: > > The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92: > > Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-17 16:44:47 +0100) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git tags/pull-testing-and-plugin-updates-180521-2 > > for you to fetch changes up to b1aa4de12e846e0ad18969ee823c19b66d8d4d8f: > > configure: use cc, not host_cc to set cross_cc for build arch (2021-05-18 09:36:21 +0100) > > ---------------------------------------------------------------- > testing and plugin updates: > > - various fixes for binfmt_misc docker images > - add hexagon check-tcg support docker image > - add tricore check-tcg support > - refactor ppc docker images > - add missing ppc64le tests > - don't use host_cc for test fallback > - check-tcg configure.sh tweaks for cross compile/clang > - fix some memory leaks in plugins > > ---------------------------------------------------------------- This fails the 'build-user-hexagon' job in gitlab: https://gitlab.com/qemu-project/qemu/-/jobs/1276171518 "ERROR: Cannot find Ninja" seems likely to be the main issue... thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Tue, 18 May 2021 at 10:07, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92: >> >> Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-17 16:44:47 +0100) >> >> are available in the Git repository at: >> >> https://github.com/stsquad/qemu.git tags/pull-testing-and-plugin-updates-180521-2 >> >> for you to fetch changes up to b1aa4de12e846e0ad18969ee823c19b66d8d4d8f: >> >> configure: use cc, not host_cc to set cross_cc for build arch (2021-05-18 09:36:21 +0100) >> >> ---------------------------------------------------------------- >> testing and plugin updates: >> >> - various fixes for binfmt_misc docker images >> - add hexagon check-tcg support docker image >> - add tricore check-tcg support >> - refactor ppc docker images >> - add missing ppc64le tests >> - don't use host_cc for test fallback >> - check-tcg configure.sh tweaks for cross compile/clang >> - fix some memory leaks in plugins >> >> ---------------------------------------------------------------- > > This fails the 'build-user-hexagon' job in gitlab: > > https://gitlab.com/qemu-project/qemu/-/jobs/1276171518 > > "ERROR: Cannot find Ninja" seems likely to be the main issue... Hmm that's weird: +RUN apt update && \ + DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \ + DEBIAN_FRONTEND=noninteractive eatmydata apt install -yy git ninja-build && \ + DEBIAN_FRONTEND=noninteractive eatmydata \ so ninja should have been installed. I thought I had pushed to both the qemu-project and my personal registries as well. > > > thanks > -- PMM -- Alex Bennée
Peter Maydell <peter.maydell@linaro.org> writes: > On Tue, 18 May 2021 at 10:07, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92: >> >> Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-17 16:44:47 +0100) >> >> are available in the Git repository at: >> >> https://github.com/stsquad/qemu.git tags/pull-testing-and-plugin-updates-180521-2 >> >> for you to fetch changes up to b1aa4de12e846e0ad18969ee823c19b66d8d4d8f: >> >> configure: use cc, not host_cc to set cross_cc for build arch (2021-05-18 09:36:21 +0100) >> >> ---------------------------------------------------------------- >> testing and plugin updates: >> >> - various fixes for binfmt_misc docker images >> - add hexagon check-tcg support docker image >> - add tricore check-tcg support >> - refactor ppc docker images >> - add missing ppc64le tests >> - don't use host_cc for test fallback >> - check-tcg configure.sh tweaks for cross compile/clang >> - fix some memory leaks in plugins >> >> ---------------------------------------------------------------- > > This fails the 'build-user-hexagon' job in gitlab: > > https://gitlab.com/qemu-project/qemu/-/jobs/1276171518 > > "ERROR: Cannot find Ninja" seems likely to be the main issue... OK the proper image is now pushed to the qemu-project registry (my tests used my personal registry as a preference): 17:16:11 [alex.bennee@hackbox2:~/l/q/b/all] testing/next↑244|✔ + docker push registry.gitlab.com/qemu-project/qemu/qemu/debian-hexagon-cross Using default tag: latest The push refers to repository [registry.gitlab.com/qemu-project/qemu/qemu/debian-hexagon-cross] 512e7ffed4ce: Mounted from stsquad/qemu/qemu/debian-hexagon-cross d608c89fd339: Mounted from stsquad/qemu/qemu/debian-hexagon-cross 07cc4994a1db: Mounted from stsquad/qemu/qemu/debian-hexagon-cross 14a1ca976738: Layer already exists latest: digest: sha256:44fbef81dc947e643d6d15ee89ac609a28109fdaced61cbf1a9c5292f2e23076 size: 1162 And now that failing test passes: https://gitlab.com/qemu-project/qemu/-/jobs/1277078226 > > > thanks > -- PMM -- Alex Bennée
On Tue, 18 May 2021 at 10:07, Alex Bennée <alex.bennee@linaro.org> wrote: > > The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92: > > Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-17 16:44:47 +0100) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git tags/pull-testing-and-plugin-updates-180521-2 > > for you to fetch changes up to b1aa4de12e846e0ad18969ee823c19b66d8d4d8f: > > configure: use cc, not host_cc to set cross_cc for build arch (2021-05-18 09:36:21 +0100) > > ---------------------------------------------------------------- > testing and plugin updates: > > - various fixes for binfmt_misc docker images > - add hexagon check-tcg support docker image > - add tricore check-tcg support > - refactor ppc docker images > - add missing ppc64le tests > - don't use host_cc for test fallback > - check-tcg configure.sh tweaks for cross compile/clang > - fix some memory leaks in plugins > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 for any user-visible changes. -- PMM
The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-17 16:44:47 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-and-plugin-updates-180521-2 for you to fetch changes up to b1aa4de12e846e0ad18969ee823c19b66d8d4d8f: configure: use cc, not host_cc to set cross_cc for build arch (2021-05-18 09:36:21 +0100) ---------------------------------------------------------------- testing and plugin updates: - various fixes for binfmt_misc docker images - add hexagon check-tcg support docker image - add tricore check-tcg support - refactor ppc docker images - add missing ppc64le tests - don't use host_cc for test fallback - check-tcg configure.sh tweaks for cross compile/clang - fix some memory leaks in plugins ---------------------------------------------------------------- Alessandro Di Federico (2): docker: Add Hexagon image tests/tcg: Use Hexagon Docker image Alex Bennée (9): tests/docker: fix copying of executable in "update" tests/docker: make executable an optional argument to "update" tests/docker: allow "update" to add the current user tests/docker: add "fetch" sub-command gitlab: add build-user-hexagon test tests/tcg: don't iterate through other arch compilers tests/tcg: fix missing return tests/tcg: don't allow clang as a cross compiler configure: use cc, not host_cc to set cross_cc for build arch Andrew Melnychenko (1): tests/docker: Added libbpf library to the docker files. Bastian Koppelmann (15): tests/tcg: Add docker_as and docker_ld cmds tests/tcg: Run timeout cmds using --foreground hw/tricore: Add testdevice for tests in tests/tcg/ tests/tcg/tricore: Add build infrastructure configure: Emit HOST_CC to config-host.mak tests/tcg/tricore: Add macros to create tests and first test 'abs' tests/tcg/tricore: Add bmerge test tests/tcg/tricore: Add clz test tests/tcg/tricore: Add dvstep test tests/tcg/tricore: Add fadd test tests/tcg/tricore: Add fmul test tests/tcg/tricore: Add ftoi test tests/tcg/tricore: Add madd test tests/tcg/tricore: Add msub test tests/tcg/tricore: Add muls test Matheus Ferst (2): tests/docker: gcc-10 based images for ppc64{,le} tests tests/tcg/ppc64le: tests for brh/brw/brd configure | 3 +- include/hw/tricore/tricore_testdevice.h | 38 ++++ tests/tcg/tricore/macros.h | 129 +++++++++++++ hw/tricore/tricore_testboard.c | 8 + hw/tricore/tricore_testdevice.c | 82 ++++++++ tests/tcg/multiarch/system/memory.c | 1 + tests/tcg/ppc64le/byte_reverse.c | 21 +++ .gitlab-ci.d/containers.yml | 13 +- .gitlab-ci.yml | 11 ++ MAINTAINERS | 3 + hw/tricore/meson.build | 1 + tests/docker/Makefile.include | 29 ++- tests/docker/docker.py | 78 +++++--- tests/docker/dockerfiles/alpine.docker | 1 + tests/docker/dockerfiles/centos8.docker | 1 + .../docker/dockerfiles/debian-hexagon-cross.docker | 45 +++++ .../build-toolchain.sh | 141 ++++++++++++++ .../docker/dockerfiles/debian-powerpc-cross.docker | 12 -- .../dockerfiles/debian-powerpc-test-cross.docker | 17 ++ tests/docker/dockerfiles/debian-ppc64-cross.docker | 11 -- tests/docker/dockerfiles/fedora.docker | 1 + tests/tcg/Makefile.qemu | 17 ++ tests/tcg/Makefile.target | 5 +- tests/tcg/configure.sh | 207 +++++++++++---------- tests/tcg/ppc64/Makefile.target | 13 ++ tests/tcg/ppc64le/Makefile.target | 13 ++ tests/tcg/tricore/Makefile.softmmu-target | 26 +++ tests/tcg/tricore/link.ld | 60 ++++++ tests/tcg/tricore/test_abs.S | 7 + tests/tcg/tricore/test_bmerge.S | 8 + tests/tcg/tricore/test_clz.S | 9 + tests/tcg/tricore/test_dvstep.S | 15 ++ tests/tcg/tricore/test_fadd.S | 16 ++ tests/tcg/tricore/test_fmul.S | 8 + tests/tcg/tricore/test_ftoi.S | 10 + tests/tcg/tricore/test_madd.S | 11 ++ tests/tcg/tricore/test_msub.S | 9 + tests/tcg/tricore/test_muls.S | 9 + 38 files changed, 928 insertions(+), 161 deletions(-) create mode 100644 include/hw/tricore/tricore_testdevice.h create mode 100644 tests/tcg/tricore/macros.h create mode 100644 hw/tricore/tricore_testdevice.c create mode 100644 tests/tcg/ppc64le/byte_reverse.c create mode 100644 tests/docker/dockerfiles/debian-hexagon-cross.docker create mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh delete mode 100644 tests/docker/dockerfiles/debian-powerpc-cross.docker create mode 100644 tests/docker/dockerfiles/debian-powerpc-test-cross.docker delete mode 100644 tests/docker/dockerfiles/debian-ppc64-cross.docker create mode 100644 tests/tcg/tricore/Makefile.softmmu-target create mode 100644 tests/tcg/tricore/link.ld create mode 100644 tests/tcg/tricore/test_abs.S create mode 100644 tests/tcg/tricore/test_bmerge.S create mode 100644 tests/tcg/tricore/test_clz.S create mode 100644 tests/tcg/tricore/test_dvstep.S create mode 100644 tests/tcg/tricore/test_fadd.S create mode 100644 tests/tcg/tricore/test_fmul.S create mode 100644 tests/tcg/tricore/test_ftoi.S create mode 100644 tests/tcg/tricore/test_madd.S create mode 100644 tests/tcg/tricore/test_msub.S create mode 100644 tests/tcg/tricore/test_muls.S -- 2.20.1