| Message ID | 20210514151342.384376-25-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/i386 translate cleanups | expand |
On 14/05/21 17:13, Richard Henderson wrote: > Both of these fields store the size of a single memory access, > so the range of values is 0-8. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/i386/tcg/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c > index 1367e53e4e..847502046f 100644 > --- a/target/i386/tcg/translate.c > +++ b/target/i386/tcg/translate.c > @@ -106,8 +106,8 @@ typedef struct DisasContext { > int repz_opt; /* optimize jumps within repz instructions */ > int mem_index; /* select memory access functions */ > uint32_t flags; /* all execution flags */ > - int popl_esp_hack; /* for correct popl with esp base handling */ > - int rip_offset; /* only used in x86_64, but left for simplicity */ > + uint8_t popl_esp_hack; /* for correct popl with esp base handling */ > + uint8_t rip_offset; /* only used in x86_64, but left for simplicity */ > int cpuid_features; > int cpuid_ext_features; > int cpuid_ext2_features; > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 1367e53e4e..847502046f 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -106,8 +106,8 @@ typedef struct DisasContext { int repz_opt; /* optimize jumps within repz instructions */ int mem_index; /* select memory access functions */ uint32_t flags; /* all execution flags */ - int popl_esp_hack; /* for correct popl with esp base handling */ - int rip_offset; /* only used in x86_64, but left for simplicity */ + uint8_t popl_esp_hack; /* for correct popl with esp base handling */ + uint8_t rip_offset; /* only used in x86_64, but left for simplicity */ int cpuid_features; int cpuid_ext_features; int cpuid_ext2_features;
Both of these fields store the size of a single memory access, so the range of values is 0-8. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/i386/tcg/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1