Message ID | 20210517161022.13984-1-alex.bennee@linaro.org |
---|---|
Headers | show |
Series | testing and plugin updates | expand |
Patchew URL: https://patchew.org/QEMU/20210517161022.13984-1-alex.bennee@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210517161022.13984-1-alex.bennee@linaro.org Subject: [PULL 00/29] testing and plugin updates === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 6005ee0..32de74a master -> master - [tag update] patchew/20210512171550.476130-1-thuth@redhat.com -> patchew/20210512171550.476130-1-thuth@redhat.com - [tag update] patchew/20210517064428.16223-1-vsementsov@virtuozzo.com -> patchew/20210517064428.16223-1-vsementsov@virtuozzo.com - [tag update] patchew/20210517151702.109066-1-sgarzare@redhat.com -> patchew/20210517151702.109066-1-sgarzare@redhat.com * [new tag] patchew/20210517161022.13984-1-alex.bennee@linaro.org -> patchew/20210517161022.13984-1-alex.bennee@linaro.org Switched to a new branch 'test' 5bbea9e plugins/hotpages: Properly freed the hash table values f6787e3 plugins/hotblocks: Properly freed the hash table values d9de308 plugins: Move all typedef and type declaration to the front of the qemu-plugin.h 25de4e5 plugins: Update qemu-plugins.symbols to match qemu-plugins.h 4620d1d configure: use cc, not host_cc to set cross_cc for build arch 7a853fe tests/tcg: don't allow clang as a cross compiler 74edf7c tests/tcg: fix missing return c58c3f3 tests/tcg/ppc64le: tests for brh/brw/brd fa99f89 tests/tcg/tricore: Add muls test 2dca1b2 tests/tcg/tricore: Add msub test 48ca02e tests/tcg/tricore: Add madd test d72dd15 tests/tcg/tricore: Add ftoi test 11e0994 tests/tcg/tricore: Add fmul test 942377c tests/tcg/tricore: Add fadd test 146eaaf tests/tcg/tricore: Add dvstep test c83ac5e tests/tcg/tricore: Add clz test e906f5e tests/tcg/tricore: Add bmerge test 8b084e7 tests/tcg/tricore: Add macros to create tests and first test 'abs' 5cb7078 configure: Emit HOST_CC to config-host.mak 01dc32f tests/tcg/tricore: Add build infrastructure 0969546 hw/tricore: Add testdevice for tests in tests/tcg/ 320b75d tests/tcg: Run timeout cmds using --foreground 383cdb7 tests/docker: Added libbpf library to the docker files. 1b533b2 tests/tcg: Use Hexagon Docker image 87f4321 docker: Add Hexagon image 674981a tests/docker: add "fetch" sub-command 4b15453 tests/docker: allow "update" to add the current user b08a0a3 tests/docker: make executable an optional argument to "update" 45691a9 tests/docker: fix copying of executable in "update" === OUTPUT BEGIN === 1/29 Checking commit 45691a9f1a3c (tests/docker: fix copying of executable in "update") 2/29 Checking commit b08a0a3952e8 (tests/docker: make executable an optional argument to "update") 3/29 Checking commit 4b154532b5ec (tests/docker: allow "update" to add the current user) 4/29 Checking commit 674981a2a08e (tests/docker: add "fetch" sub-command) 5/29 Checking commit 87f4321d401b (docker: Add Hexagon image) WARNING: line over 80 characters #207: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63: + -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \ ERROR: line over 90 characters #234: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90: + CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ ERROR: line over 90 characters #271: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127: + CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ total: 2 errors, 1 warnings, 222 lines checked Patch 5/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/29 Checking commit 1b533b2ebadf (tests/tcg: Use Hexagon Docker image) 7/29 Checking commit 383cdb76706a (tests/docker: Added libbpf library to the docker files.) 8/29 Checking commit 320b75d22d97 (tests/tcg: Run timeout cmds using --foreground) 9/29 Checking commit 09695469a9b9 (hw/tricore: Add testdevice for tests in tests/tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 total: 0 errors, 1 warnings, 152 lines checked Patch 9/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/29 Checking commit 01dc32ff4753 (tests/tcg/tricore: Add build infrastructure) 11/29 Checking commit 5cb7078ea4eb (configure: Emit HOST_CC to config-host.mak) 12/29 Checking commit 8b084e7f9c2f (tests/tcg/tricore: Add macros to create tests and first test 'abs') WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #64: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #70: FILE: tests/tcg/tricore/macros.h:2: +#define LI(reg, val) \ + mov.u reg, lo:val; \ + movh DREG_TEMP_LI, up:val; \ + or reg, reg, DREG_TEMP_LI; \ + ERROR: spaces required around that ':' (ctx:VxV) #71: FILE: tests/tcg/tricore/macros.h:3: + mov.u reg, lo:val; \ ^ ERROR: spaces required around that ':' (ctx:VxV) #72: FILE: tests/tcg/tricore/macros.h:4: + movh DREG_TEMP_LI, up:val; \ ^ ERROR: spaces required around that '%' (ctx:WxV) #78: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #78: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ERROR: spaces required around that '%' (ctx:WxV) #79: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #79: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ERROR: spaces required around that '%' (ctx:WxV) #80: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ^ ERROR: Macros with complex values should be enclosed in parenthesis #80: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ERROR: spaces required around that '%' (ctx:WxV) #81: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ^ ERROR: Macros with complex values should be enclosed in parenthesis #81: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ERROR: spaces required around that '%' (ctx:WxV) #82: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ^ ERROR: Macros with complex values should be enclosed in parenthesis #82: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ERROR: spaces required around that '%' (ctx:WxV) #83: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #83: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ERROR: spaces required around that '%' (ctx:WxV) #85: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #85: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ERROR: Macros with multiple statements should be enclosed in a do - while loop #88: FILE: tests/tcg/tricore/macros.h:20: +#define TEST_CASE(num, testreg, correct, code...) \ +test_ ## num: \ + code; \ + LI(DREG_CORRECT_RESULT, correct) \ + mov DREG_TEST_NUM, num; \ + jne testreg, DREG_CORRECT_RESULT, fail \ + ERROR: spaces required around that ':' (ctx:VxE) #89: FILE: tests/tcg/tricore/macros.h:21: +test_ ## num: \ ^ WARNING: Block comments use a leading /* on a separate line #95: FILE: tests/tcg/tricore/macros.h:27: +/* Actual test case type ERROR: Macros with multiple statements should be enclosed in a do - while loop #107: FILE: tests/tcg/tricore/macros.h:39: +#define TEST_PASSFAIL \ + j pass; \ +fail: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j fail; \ +pass: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + mov DREG_TEST_NUM, 0; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j pass; ERROR: space prohibited before open square bracket '[' #112: FILE: tests/tcg/tricore/macros.h:44: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ ERROR: space prohibited before open square bracket '[' #119: FILE: tests/tcg/tricore/macros.h:51: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ total: 22 errors, 2 warnings, 80 lines checked Patch 12/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/29 Checking commit e906f5eda6d3 (tests/tcg/tricore: Add bmerge test) ERROR: spaces required around that '%' (ctx:WxV) #40: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ERROR: spaces required around that '%' (ctx:WxV) #42: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ^ ERROR: Macros with complex values should be enclosed in parenthesis #42: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ERROR: spaces required around that '%' (ctx:WxV) #43: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ^ ERROR: Macros with complex values should be enclosed in parenthesis #43: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ERROR: spaces required around that ':' (ctx:VxE) #52: FILE: tests/tcg/tricore/macros.h:31: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #83: new file mode 100644 total: 7 errors, 1 warnings, 58 lines checked Patch 13/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/29 Checking commit c83ac5e40e8c (tests/tcg/tricore: Add clz test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 14/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/29 Checking commit 146eaafb8d84 (tests/tcg/tricore: Add dvstep test) ERROR: spaces required around that '%' (ctx:WxV) #40: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ERROR: spaces required around that '%' (ctx:WxV) #41: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #41: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ERROR: spaces required around that '%' (ctx:WxV) #42: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ^ ERROR: Macros with complex values should be enclosed in parenthesis #42: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ERROR: spaces required around that '%' (ctx:WxV) #43: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #43: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ERROR: spaces required around that '%' (ctx:WxV) #44: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #44: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #45: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #45: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #46: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #46: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ERROR: spaces required around that '%' (ctx:WxV) #47: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #47: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #48: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #48: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #49: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #49: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ERROR: spaces required around that '%' (ctx:WxV) #50: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #50: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ERROR: spaces required around that ':' (ctx:VxE) #60: FILE: tests/tcg/tricore/macros.h:43: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #87: new file mode 100644 total: 23 errors, 1 warnings, 69 lines checked Patch 15/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/29 Checking commit 942377ccfbd0 (tests/tcg/tricore: Add fadd test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 23 lines checked Patch 16/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/29 Checking commit 11e0994160b3 (tests/tcg/tricore: Add fmul test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 15 lines checked Patch 17/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/29 Checking commit d72dd15144a3 (tests/tcg/tricore: Add ftoi test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 30 lines checked Patch 18/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/29 Checking commit 48ca02ea0bc9 (tests/tcg/tricore: Add madd test) ERROR: spaces required around that '%' (ctx:WxV) #40: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 ^ ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 2 errors, 1 warnings, 48 lines checked Patch 19/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/29 Checking commit 2dca1b247a62 (tests/tcg/tricore: Add msub test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 20/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/29 Checking commit fa99f891ada4 (tests/tcg/tricore: Add muls test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 21/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/29 Checking commit c58c3f32265b (tests/tcg/ppc64le: tests for brh/brw/brd) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 55 lines checked Patch 22/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/29 Checking commit 74edf7c4c335 (tests/tcg: fix missing return) 24/29 Checking commit 7a853feeca20 (tests/tcg: don't allow clang as a cross compiler) WARNING: line over 80 characters #80: FILE: tests/tcg/configure.sh:269: + # For host systems we might get away with building without -static WARNING: line over 80 characters #108: FILE: tests/tcg/configure.sh:297: + -mbranch-protection=standard -o $TMPE $TMPC; then WARNING: line over 80 characters #119: FILE: tests/tcg/configure.sh:308: + echo "CROSS_CC_HAS_POWER8_VECTOR=y" >> $config_target_mak ERROR: line over 90 characters #141: FILE: tests/tcg/configure.sh:321: + if test $got_cross_cc = no && test "$container" != no && test -n "$container_image"; then WARNING: line over 80 characters #145: FILE: tests/tcg/configure.sh:325: + echo "DOCKER_CROSS_CC_GUEST=$container_cross_cc" >> $config_target_mak total: 1 errors, 4 warnings, 166 lines checked Patch 24/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/29 Checking commit 4620d1dbd8ba (configure: use cc, not host_cc to set cross_cc for build arch) 26/29 Checking commit 25de4e5140c4 (plugins: Update qemu-plugins.symbols to match qemu-plugins.h) 27/29 Checking commit d9de308c7401 (plugins: Move all typedef and type declaration to the front of the qemu-plugin.h) 28/29 Checking commit f6787e315c3e (plugins/hotblocks: Properly freed the hash table values) 29/29 Checking commit 5bbea9e7dbc8 (plugins/hotpages: Properly freed the hash table values) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210517161022.13984-1-alex.bennee@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Alex Bennée <alex.bennee@linaro.org> writes: > The following changes since commit 6005ee07c380cbde44292f5f6c96e7daa70f4f7d: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-05-16 17:22:46 +0100) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git tags/pull-testing-and-plugin-updates-170521-2 > > for you to fetch changes up to e3ac6f02999e88b9f8fb85013121a9408d07b6e2: > > plugins/hotpages: Properly freed the hash table values (2021-05-17 14:38:44 +0100) > > ---------------------------------------------------------------- > testing and plugin updates: > > - various fixes for binfmt_misc docker images > - add hexagon check-tcg support docker image > - add tricore check-tcg support > - add missing ppc64le tests > - don't use host_cc for test fallback > - check-tcg configure.sh tweaks for cross compile/clang > - fix some memory leaks in plugins > > ---------------------------------------------------------------- > Alessandro Di Federico (1): > tests/tcg: Use Hexagon Docker image > > Alex Bennée (8): > tests/docker: fix copying of executable in "update" > tests/docker: make executable an optional argument to "update" > tests/docker: allow "update" to add the current user > tests/docker: add "fetch" sub-command > docker: Add Hexagon image > tests/tcg: fix missing return > tests/tcg: don't allow clang as a cross compiler > configure: use cc, not host_cc to set cross_cc for build arch > > Andrew Melnychenko (1): > tests/docker: Added libbpf library to the docker files. > > Bastian Koppelmann (14): > tests/tcg: Run timeout cmds using --foreground > hw/tricore: Add testdevice for tests in tests/tcg/ > tests/tcg/tricore: Add build infrastructure > configure: Emit HOST_CC to config-host.mak > tests/tcg/tricore: Add macros to create tests and first test 'abs' > tests/tcg/tricore: Add bmerge test > tests/tcg/tricore: Add clz test > tests/tcg/tricore: Add dvstep test > tests/tcg/tricore: Add fadd test > tests/tcg/tricore: Add fmul test > tests/tcg/tricore: Add ftoi test > tests/tcg/tricore: Add madd test > tests/tcg/tricore: Add msub test > tests/tcg/tricore: Add muls test > > Mahmoud Mandour (2): > plugins/hotblocks: Properly freed the hash table values > plugins/hotpages: Properly freed the hash table values > > Matheus Ferst (1): > tests/tcg/ppc64le: tests for brh/brw/brd Oops I have dropped the patch to actually support this. Please ignore and I'll send a v2. -- Alex Bennée