mbox series

[0/5] ARM: dts: qcom: Enable various devices for IPQ806x / RB3011

Message ID cover.1621097174.git.noodles@earth.li
Headers show
Series ARM: dts: qcom: Enable various devices for IPQ806x / RB3011 | expand

Message

Jonathan McDowell May 15, 2021, 4:52 p.m. UTC
This series adds various devices (NAND, USB, tsens, L2CC, RPM) which
have either recently gained mainline drivers, or just failed to be
previously added, to the DTS for the IPQ806x platform. It then enables
them for the MikroTik RB3011 platform, where they have all been tested.

I've done the additions to the main IPQ806x DTS as separate commits for
each logical set, and then a single wholesale set of changes for the
RB3011 to turn everything on. Happy to squash to 1/2 commits or split
out further if desired.

Jonathan McDowell (5):
  ARM: dts: qcom: Add ADM DMA + NAND definitions to ipq806x
  ARM: dts: qcom: Add tsens details to ipq806x
  ARM: dts: qcom: Add USB port definitions to ipq806x
  ARM: dts: qcom: add L2CC and RPM for IPQ8064
  ARM: dts: qcom: Enable NAND + USB for RB3011

 arch/arm/boot/dts/qcom-ipq8064-rb3011.dts |  58 +++
 arch/arm/boot/dts/qcom-ipq8064.dtsi       | 427 +++++++++++++++++++++-
 2 files changed, 484 insertions(+), 1 deletion(-)

Comments

Vinod Koul May 17, 2021, 9:42 a.m. UTC | #1
On 15-05-21, 17:52, Jonathan McDowell wrote:

>  		gcc: clock-controller@900000 {

> -			compatible = "qcom,gcc-ipq8064";

> +			compatible = "qcom,gcc-ipq8064", "syscon";


Does this belong here

>  			reg = <0x00900000 0x4000>;

>  			#clock-cells = <1>;

>  			#reset-cells = <1>;

> +			#power-domain-cells = <1>;

> +

> +			tsens: thermal-sensor@900000 {

> +				compatible = "qcom,ipq8064-tsens";

> +

> +				nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>;

> +				nvmem-cell-names = "calib", "calib_backup";

> +				interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;

> +				interrupt-names = "uplow";

> +

> +				#qcom,sensors = <11>;

> +				#thermal-sensor-cells = <1>;

> +			};


We have sensor under gcc node..?

-- 
~Vinod
Jonathan McDowell May 19, 2021, 11 a.m. UTC | #2
On Mon, May 17, 2021 at 03:12:02PM +0530, Vinod Koul wrote:
> On 15-05-21, 17:52, Jonathan McDowell wrote:

> 

> >  		gcc: clock-controller@900000 {

> > -			compatible = "qcom,gcc-ipq8064";

> > +			compatible = "qcom,gcc-ipq8064", "syscon";

> 

> Does this belong here


No, not sure how that slipped in, will remove for v2.

> >  			reg = <0x00900000 0x4000>;

> >  			#clock-cells = <1>;

> >  			#reset-cells = <1>;

> > +			#power-domain-cells = <1>;

> > +

> > +			tsens: thermal-sensor@900000 {

> > +				compatible = "qcom,ipq8064-tsens";

> > +

> > +				nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>;

> > +				nvmem-cell-names = "calib", "calib_backup";

> > +				interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;

> > +				interrupt-names = "uplow";

> > +

> > +				#qcom,sensors = <11>;

> > +				#thermal-sensor-cells = <1>;

> > +			};

> 

> We have sensor under gcc node..?


Weirdly, yes, that seems to be where it lives for the 8064.

J.

-- 
I'm dangerous when I know what I'm doing.
Jonathan McDowell May 20, 2021, 5:29 p.m. UTC | #3
This series adds various devices (NAND, USB, tsens, L2CC, RPM) which
have either recently gained mainline drivers, or just failed to be
previously added, to the DTS for the IPQ806x platform. It then enables
them for the MikroTik RB3011 platform, where they have all been tested.

I've done the additions to the main IPQ806x DTS as separate commits for
each logical set, and then a single wholesale set of changes for the
RB3011 to turn everything on. Happy to squash to 1/2 commits or split
out further if desired.

v2:
  Fix ADM label to "dma-controller"
  Drop spurious "syscon" on GCC for tsens changes

Jonathan McDowell (5):
  ARM: dts: qcom: Add ADM DMA + NAND definitions to ipq806x
  ARM: dts: qcom: Add tsens details to ipq806x
  ARM: dts: qcom: Add USB port definitions to ipq806x
  ARM: dts: qcom: add L2CC and RPM for IPQ8064
  ARM: dts: qcom: Enable NAND + USB for RB3011

 arch/arm/boot/dts/qcom-ipq8064-rb3011.dts |  58 +++
 arch/arm/boot/dts/qcom-ipq8064.dtsi       | 425 ++++++++++++++++++++++
 2 files changed, 483 insertions(+)