diff mbox series

media: meson: vdec: remove redundant initialization of variable reg_cur

Message ID 20210513220317.137090-1-colin.king@canonical.com
State Accepted
Commit 2c1e75f5baac5432749b90174a7a1f50a97327b2
Headers show
Series media: meson: vdec: remove redundant initialization of variable reg_cur | expand

Commit Message

Colin King May 13, 2021, 10:03 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The variable reg_cur is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/media/meson/vdec/vdec_helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Blumenstingl May 16, 2021, 5:01 p.m. UTC | #1 
On Fri, May 14, 2021 at 12:03 AM Colin King <colin.king@canonical.com> wrote:
>

> From: Colin Ian King <colin.king@canonical.com>

>

> The variable reg_cur is being initialized with a value that is never

> read, it is being updated later on. The assignment is redundant and

> can be removed.

>

> Addresses-Coverity: ("Unused value")

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
diff mbox series

Patch

diff --git a/drivers/staging/media/meson/vdec/vdec_helpers.c b/drivers/staging/media/meson/vdec/vdec_helpers.c
index 7f07a9175815..b9125c295d1d 100644
--- a/drivers/staging/media/meson/vdec/vdec_helpers.c
+++ b/drivers/staging/media/meson/vdec/vdec_helpers.c
@@ -183,7 +183,7 @@  int amvdec_set_canvases(struct amvdec_session *sess,
 	u32 pixfmt = sess->pixfmt_cap;
 	u32 width = ALIGN(sess->width, 32);
 	u32 height = ALIGN(sess->height, 32);
-	u32 reg_cur = reg_base[0];
+	u32 reg_cur;
 	u32 reg_num_cur = 0;
 	u32 reg_base_cur = 0;
 	int i = 0;