| Message ID | 1619058521-35307-1-git-send-email-cang@codeaurora.org |
|---|---|
| Headers | show |
| Series | Introduce hba performance monitoring sysfs nodes | expand |
Hi Can Guo, >Add a new sysfs group which has nodes to monitor data/request transfer >performance. This sysfs group has nodes showing total sectors/requests >transferred, total busy time spent and max/min/avg/sum latencies. This >group can be enhanced later to show more UFS driver layer performance >data during runtime. This series looks good to me. Reviewed-by: Daejun Park <daejun7.park@samsung.com> Thanks, Daejun
On Wed, 2021-04-21 at 19:28 -0700, Can Guo wrote: > + > > +static DEVICE_ATTR_RW(monitor_enable); > > +static DEVICE_ATTR_RW(monitor_chunk_size); > > +static DEVICE_ATTR_RO(read_total_sectors); > > +static DEVICE_ATTR_RO(read_total_busy); > > +static DEVICE_ATTR_RO(read_nr_requests); > > +static DEVICE_ATTR_RO(read_req_latency_avg); > > +static DEVICE_ATTR_RO(read_req_latency_max); > > +static DEVICE_ATTR_RO(read_req_latency_min); > > +static DEVICE_ATTR_RO(read_req_latency_sum); > > +static DEVICE_ATTR_RO(write_total_sectors); > > +static DEVICE_ATTR_RO(write_total_busy); > > +static DEVICE_ATTR_RO(write_nr_requests); > > +static DEVICE_ATTR_RO(write_req_latency_avg); > > +static DEVICE_ATTR_RO(write_req_latency_max); > > +static DEVICE_ATTR_RO(write_req_latency_min); > > +static DEVICE_ATTR_RO(write_req_latency_sum); Can, I like this series of patches, which can help me monitor UFS performance online. I have a suggestion, how do you think that we add this to ufs-debugfs. Then we don't need to poll each parameter one by one, just one interface. Bean
On 2021-05-13 04:21, Bean Huo wrote: > On Wed, 2021-04-21 at 19:28 -0700, Can Guo wrote: >> + >> >> +static DEVICE_ATTR_RW(monitor_enable); >> >> +static DEVICE_ATTR_RW(monitor_chunk_size); >> >> +static DEVICE_ATTR_RO(read_total_sectors); >> >> +static DEVICE_ATTR_RO(read_total_busy); >> >> +static DEVICE_ATTR_RO(read_nr_requests); >> >> +static DEVICE_ATTR_RO(read_req_latency_avg); >> >> +static DEVICE_ATTR_RO(read_req_latency_max); >> >> +static DEVICE_ATTR_RO(read_req_latency_min); >> >> +static DEVICE_ATTR_RO(read_req_latency_sum); >> >> +static DEVICE_ATTR_RO(write_total_sectors); >> >> +static DEVICE_ATTR_RO(write_total_busy); >> >> +static DEVICE_ATTR_RO(write_nr_requests); >> >> +static DEVICE_ATTR_RO(write_req_latency_avg); >> >> +static DEVICE_ATTR_RO(write_req_latency_max); >> >> +static DEVICE_ATTR_RO(write_req_latency_min); >> >> +static DEVICE_ATTR_RO(write_req_latency_sum); > > Can, > > I like this series of patches, which can help me monitor UFS > performance online. I have a suggestion, how do you think that we add > this to ufs-debugfs. Then we don't need to poll each parameter one by > one, just one interface. > > Bean Hi Bean, Thanks for your suggestion, put it into debugfs is also an option. But on Android, debugfs is not mounted by default (the requirement from Google). So it is convenient to have it in sysfs, and one can use below cmd (as I listed in the cover letter) to poll all parameters at once : "grep ^ /dev/null *". Thanks, Can Guo.
On Wed, 2021-04-21 at 19:28 -0700, Can Guo wrote: > Add a new sysfs group which has nodes to monitor data/request > transfer > > performance. This sysfs group has nodes showing total > sectors/requests > > transferred, total busy time spent and max/min/avg/sum latencies. > This > > group can be enhanced later to show more UFS driver layer performance > > statistics data during runtime. > > > > Signed-off-by: Can Guo <cang@codeaurora.org> Acked-by: Bean Huo <beanhuo@micron.com>
Can, > Add a new sysfs group which has nodes to monitor data/request transfer > performance. This sysfs group has nodes showing total sectors/requests > transferred, total busy time spent and max/min/avg/sum latencies. This > group can be enhanced later to show more UFS driver layer performance > data during runtime. Applied to 5.14/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering