mbox series

[net,0/2] sctp: fix the race condition in sctp_destroy_sock in a proper way

Message ID cover.1619989856.git.lucien.xin@gmail.com
Headers show
Series sctp: fix the race condition in sctp_destroy_sock in a proper way | expand

Message

Xin Long May 2, 2021, 9:11 p.m. UTC
The original fix introduced a dead lock, and has to be removed in
Patch 1/2, and we will get a proper way to fix it in Patch 2/2.

Xin Long (2):
  Revert "net/sctp: fix race condition in sctp_destroy_sock"
  sctp: delay auto_asconf init until binding the first addr

 net/sctp/socket.c | 38 ++++++++++++++++++++++----------------
 1 file changed, 22 insertions(+), 16 deletions(-)

Comments

Salvatore Bonaccorso May 10, 2021, 7:10 p.m. UTC | #1
Hi Xin,

On Mon, May 03, 2021 at 05:11:40AM +0800, Xin Long wrote:
> The original fix introduced a dead lock, and has to be removed in

> Patch 1/2, and we will get a proper way to fix it in Patch 2/2.

> 

> Xin Long (2):

>   Revert "net/sctp: fix race condition in sctp_destroy_sock"

>   sctp: delay auto_asconf init until binding the first addr

> 

>  net/sctp/socket.c | 38 ++++++++++++++++++++++----------------

>  1 file changed, 22 insertions(+), 16 deletions(-)


The original commit which got reverted in this series, was already
applied to several stable series, namely all of 4.4.268, 4.9.268,
4.14.232, 4.19.189, 5.4.114, 5.10.32, 5.11.16.

Is it planned to do the revert and bugfix in those as well?

Regards,
Salvatore
Xin Long May 10, 2021, 7:18 p.m. UTC | #2
On Mon, May 10, 2021 at 3:10 PM Salvatore Bonaccorso <carnil@debian.org> wrote:
>

> Hi Xin,

>

> On Mon, May 03, 2021 at 05:11:40AM +0800, Xin Long wrote:

> > The original fix introduced a dead lock, and has to be removed in

> > Patch 1/2, and we will get a proper way to fix it in Patch 2/2.

> >

> > Xin Long (2):

> >   Revert "net/sctp: fix race condition in sctp_destroy_sock"

> >   sctp: delay auto_asconf init until binding the first addr

> >

> >  net/sctp/socket.c | 38 ++++++++++++++++++++++----------------

> >  1 file changed, 22 insertions(+), 16 deletions(-)

>

> The original commit which got reverted in this series, was already

> applied to several stable series, namely all of 4.4.268, 4.9.268,

> 4.14.232, 4.19.189, 5.4.114, 5.10.32, 5.11.16.

>

> Is it planned to do the revert and bugfix in those as well?

Yes. Thanks.