mbox series

[v4,0/7] Add support for AEAD algorithms in Qualcomm Crypto Engine driver

Message ID 20210429150707.3168383-1-thara.gopinath@linaro.org
Headers show
Series Add support for AEAD algorithms in Qualcomm Crypto Engine driver | expand

Message

Thara Gopinath April 29, 2021, 3:07 p.m. UTC
Enable support for AEAD algorithms in Qualcomm CE driver.  The first three
patches in this series are cleanups and add a few missing pieces required
to add support for AEAD algorithms.  Patch 4 introduces supported AEAD
transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w
infrastructure needed to enable and run the AEAD transformations on
Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of
unsupported special inputs.

This patch series has been tested with in kernel crypto testing module
tcrypt.ko with fuzz tests enabled as well.

Thara Gopinath (7):
  crypto: qce: common: Add MAC failed error checking
  crypto: qce: common: Make result dump optional
  crypto: qce: Add mode for rfc4309
  crypto: qce: Add support for AEAD algorithms
  crypto: qce: common: Clean up qce_auth_cfg
  crypto: qce: common: Add support for AEAD algorithms
  crypto: qce: aead: Schedule fallback algorithm

 drivers/crypto/Kconfig      |  15 +
 drivers/crypto/qce/Makefile |   1 +
 drivers/crypto/qce/aead.c   | 841 ++++++++++++++++++++++++++++++++++++
 drivers/crypto/qce/aead.h   |  56 +++
 drivers/crypto/qce/common.c | 196 ++++++++-
 drivers/crypto/qce/common.h |   9 +-
 drivers/crypto/qce/core.c   |   4 +
 7 files changed, 1102 insertions(+), 20 deletions(-)
 create mode 100644 drivers/crypto/qce/aead.c
 create mode 100644 drivers/crypto/qce/aead.h

-- 
2.25.1

Comments

Thara Gopinath May 5, 2021, 10:54 p.m. UTC | #1
On 4/29/21 11:07 AM, Thara Gopinath wrote:
> Enable support for AEAD algorithms in Qualcomm CE driver.  The first three
> patches in this series are cleanups and add a few missing pieces required
> to add support for AEAD algorithms.  Patch 4 introduces supported AEAD
> transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w
> infrastructure needed to enable and run the AEAD transformations on
> Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of
> unsupported special inputs.
> 
> This patch series has been tested with in kernel crypto testing module
> tcrypt.ko with fuzz tests enabled as well.

Hi Herbert,

I have fixed all the review comments on this series and fuzz tests pass 
as well. Do you think this can be merged ?
Herbert Xu May 5, 2021, 10:58 p.m. UTC | #2
On Wed, May 05, 2021 at 06:54:18PM -0400, Thara Gopinath wrote:
> 

> 

> On 4/29/21 11:07 AM, Thara Gopinath wrote:

> > Enable support for AEAD algorithms in Qualcomm CE driver.  The first three

> > patches in this series are cleanups and add a few missing pieces required

> > to add support for AEAD algorithms.  Patch 4 introduces supported AEAD

> > transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w

> > infrastructure needed to enable and run the AEAD transformations on

> > Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of

> > unsupported special inputs.

> > 

> > This patch series has been tested with in kernel crypto testing module

> > tcrypt.ko with fuzz tests enabled as well.

> 

> Hi Herbert,

> 

> I have fixed all the review comments on this series and fuzz tests pass as

> well. Do you think this can be merged ?


We're still in the merge window, no new features are accepted
at this point.  Please be patient.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thara Gopinath May 5, 2021, 11 p.m. UTC | #3
On 5/5/21 6:58 PM, Herbert Xu wrote:
> On Wed, May 05, 2021 at 06:54:18PM -0400, Thara Gopinath wrote:
>>
>>
>> On 4/29/21 11:07 AM, Thara Gopinath wrote:
>>> Enable support for AEAD algorithms in Qualcomm CE driver.  The first three
>>> patches in this series are cleanups and add a few missing pieces required
>>> to add support for AEAD algorithms.  Patch 4 introduces supported AEAD
>>> transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w
>>> infrastructure needed to enable and run the AEAD transformations on
>>> Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of
>>> unsupported special inputs.
>>>
>>> This patch series has been tested with in kernel crypto testing module
>>> tcrypt.ko with fuzz tests enabled as well.
>>
>> Hi Herbert,
>>
>> I have fixed all the review comments on this series and fuzz tests pass as
>> well. Do you think this can be merged ?
> 
> We're still in the merge window, no new features are accepted
> at this point.  Please be patient.

Ok, thanks!

> 
> Thanks,
>
Herbert Xu May 14, 2021, 11:35 a.m. UTC | #4
On Thu, Apr 29, 2021 at 11:07:00AM -0400, Thara Gopinath wrote:
> Enable support for AEAD algorithms in Qualcomm CE driver.  The first three

> patches in this series are cleanups and add a few missing pieces required

> to add support for AEAD algorithms.  Patch 4 introduces supported AEAD

> transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w

> infrastructure needed to enable and run the AEAD transformations on

> Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of

> unsupported special inputs.

> 

> This patch series has been tested with in kernel crypto testing module

> tcrypt.ko with fuzz tests enabled as well.

> 

> Thara Gopinath (7):

>   crypto: qce: common: Add MAC failed error checking

>   crypto: qce: common: Make result dump optional

>   crypto: qce: Add mode for rfc4309

>   crypto: qce: Add support for AEAD algorithms

>   crypto: qce: common: Clean up qce_auth_cfg

>   crypto: qce: common: Add support for AEAD algorithms

>   crypto: qce: aead: Schedule fallback algorithm

> 

>  drivers/crypto/Kconfig      |  15 +

>  drivers/crypto/qce/Makefile |   1 +

>  drivers/crypto/qce/aead.c   | 841 ++++++++++++++++++++++++++++++++++++

>  drivers/crypto/qce/aead.h   |  56 +++

>  drivers/crypto/qce/common.c | 196 ++++++++-

>  drivers/crypto/qce/common.h |   9 +-

>  drivers/crypto/qce/core.c   |   4 +

>  7 files changed, 1102 insertions(+), 20 deletions(-)

>  create mode 100644 drivers/crypto/qce/aead.c

>  create mode 100644 drivers/crypto/qce/aead.h


All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt