mbox series

[V3,0/3] Add DT bindings and device tree nodes for TSENS in SC7280

Message ID 1619778592-8112-1-git-send-email-rkambl@codeaurora.org
Headers show
Series Add DT bindings and device tree nodes for TSENS in SC7280 | expand

Message

Rajeshwari Ravindra Kamble April 30, 2021, 10:29 a.m. UTC
Adding compatible string in TSENS dt-bindings, device node for TSENS controller and 
critical interrupt support, Thermal zone, cooling maps support and changing Hysteresis 
value for critical trip point, adding cooling-cells property.

Changes:
1) Adding sensors according to sensor index rules under thermal-zones.
2) Changing Hysteresis, as it is not needed for critical trip point, when it reaches 
   critical threshold system will go for shutdown.
3) Adding cooling-cells property under cpus node.

Dependencies:
https://lore.kernel.org/patchwork/project/lkml/list/?series=487403
https://lore.kernel.org/patchwork/patch/1410952/

Rajeshwari (3):
  dt-bindings: thermal: tsens: Add compatible string to TSENS binding
    for SC7280
  arm64: dts: qcom: SC7280:  Add device node support for TSENS
  arm64: dts: qcom: SC7280: Add thermal zone support

 .../devicetree/bindings/thermal/qcom-tsens.yaml    |   1 +
 arch/arm64/boot/dts/qcom/sc7280.dtsi               | 874 +++++++++++++++++++++
 2 files changed, 875 insertions(+)

Comments

Rob Herring (Arm) April 30, 2021, 9:46 p.m. UTC | #1
On Fri, Apr 30, 2021 at 03:59:50PM +0530, Rajeshwari wrote:
> Adding compatible string in TSENS dt-bindings for SC7280.
> 
> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>

Is this your full name?

> ---
>  Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index b7a832f..23cf265 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -46,6 +46,7 @@ properties:
>                - qcom,msm8996-tsens
>                - qcom,msm8998-tsens
>                - qcom,sc7180-tsens
> +              - qcom,sc7280-tsens
>                - qcom,sdm845-tsens
>                - qcom,sm8150-tsens
>                - qcom,sm8250-tsens
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
> of Code Aurora Forum, hosted by The Linux Foundation
>
Matthias Kaehlcke May 3, 2021, 5:30 p.m. UTC | #2
On Fri, Apr 30, 2021 at 03:59:50PM +0530, Rajeshwari wrote:
> Adding compatible string in TSENS dt-bindings for SC7280.

> 

> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>


Please make sure to cc reviewers from earlier revisions and to
add tags like my 'Reviewed-by' from v2.

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Matthias Kaehlcke May 3, 2021, 5:33 p.m. UTC | #3
On Fri, Apr 30, 2021 at 03:59:51PM +0530, Rajeshwari wrote:
> Adding device node for TSENS controller and critical interrupt support in SC7280.

> 

> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>


Please add tags from previous versions, like my 'Reviewed-by' from v2,
unless a patch underwent major changes.

Please also add a change log for v > 1, even if it just says 'no changes'
for some patches in the series.
Matthias Kaehlcke May 4, 2021, 8:46 p.m. UTC | #4
On Mon, May 03, 2021 at 10:33:10AM -0700, Matthias Kaehlcke wrote:
> On Fri, Apr 30, 2021 at 03:59:51PM +0530, Rajeshwari wrote:
> > Adding device node for TSENS controller and critical interrupt support in SC7280.
> > 
> > Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
> 
> Please add tags from previous versions, like my 'Reviewed-by' from v2,
> unless a patch underwent major changes.
> 
> Please also add a change log for v > 1, even if it just says 'no changes'
> for some patches in the series.

Forgot to re-add this:

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>