| Message ID | 20210501185116.1338875-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | tcg patch queue | expand |
Patchew URL: https://patchew.org/QEMU/20210501185116.1338875-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210501185116.1338875-1-richard.henderson@linaro.org
Subject: [PULL 0/5] tcg patch queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210501185116.1338875-1-richard.henderson@linaro.org -> patchew/20210501185116.1338875-1-richard.henderson@linaro.org
Switched to a new branch 'test'
3f52d0d decodetree: Extend argument set syntax to allow types
2f170a4 decodetree: Add support for 64-bit instructions
6567eed decodetree: More use of f-strings
95caca8 decodetree: Introduce whex and whexC helpers
b9a64b1 exec: Remove accel/tcg/ from include paths
=== OUTPUT BEGIN ===
1/5 Checking commit b9a64b13ad89 (exec: Remove accel/tcg/ from include paths)
2/5 Checking commit 95caca818e08 (decodetree: Introduce whex and whexC helpers)
ERROR: line over 90 characters
#52: FILE: scripts/decodetree.py:495:
+ output(ind, f'if ((insn & {whexC(innermask)}) == {whexC(innerbits)}) {{\n')
WARNING: line over 80 characters
#53: FILE: scripts/decodetree.py:496:
+ output(ind, f' /* {str_match_bits(p.fixedbits, p.fixedmask)} */\n')
total: 1 errors, 1 warnings, 136 lines checked
Patch 2/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 6567eed04461 (decodetree: More use of f-strings)
4/5 Checking commit 2f170a408195 (decodetree: Add support for 64-bit instructions)
WARNING: line over 80 characters
#75: FILE: scripts/decodetree.py:236:
+ ret = f'deposit{bitop_width}({ret}, {pos}, {bitop_width - pos}, {ext})'
total: 0 errors, 1 warnings, 63 lines checked
Patch 4/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit 3f52d0d96c42 (decodetree: Extend argument set syntax to allow types)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#156:
new file mode 100644
total: 0 errors, 1 warnings, 121 lines checked
Patch 5/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210501185116.1338875-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Sat, 1 May 2021 at 19:51, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit 8f860d2633baf9c2b6261f703f86e394c6bc22ca: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-04-30' into staging (2021-04-30 16:02:00 +0100) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210501 > > for you to fetch changes up to af93ccacc772019298be4c3e47251cdaa60d0c21: > > decodetree: Extend argument set syntax to allow types (2021-05-01 11:45:35 -0700) > > ---------------------------------------------------------------- > Include cleanups. > Decodetree enhancements for power10. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 for any user-visible changes. -- PMM
The following changes since commit 8f860d2633baf9c2b6261f703f86e394c6bc22ca: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-04-30' into staging (2021-04-30 16:02:00 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210501 for you to fetch changes up to af93ccacc772019298be4c3e47251cdaa60d0c21: decodetree: Extend argument set syntax to allow types (2021-05-01 11:45:35 -0700) ---------------------------------------------------------------- Include cleanups. Decodetree enhancements for power10. ---------------------------------------------------------------- Luis Fernando Fujita Pires (1): decodetree: Add support for 64-bit instructions Philippe Mathieu-Daudé (1): exec: Remove accel/tcg/ from include paths Richard Henderson (3): decodetree: Introduce whex and whexC helpers decodetree: More use of f-strings decodetree: Extend argument set syntax to allow types docs/devel/decodetree.rst | 11 ++- meson.build | 1 - include/exec/helper-gen.h | 4 +- include/exec/helper-proto.h | 4 +- include/exec/helper-tcg.h | 4 +- tests/decode/succ_argset_type1.decode | 1 + scripts/decodetree.py | 172 +++++++++++++++++++--------------- 7 files changed, 112 insertions(+), 85 deletions(-) create mode 100644 tests/decode/succ_argset_type1.decode