| Message ID | 5d9ab05cbefb2dabe660c5ac57432fc097e06291.1395832156.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 03/26/2014 04:51 PM, Viresh Kumar wrote: > Currently we are returning notifier_from_errno() from CPU_UP_PREPARE notifier > when we detect an error while calling init_timers_cpu(). notifier_from_errno() > already has enough checks within to do something similar. And so we can call it > directly without checking if there was an error or not. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Regards, Srivatsa S. Bhat > --- > kernel/timer.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/kernel/timer.c b/kernel/timer.c > index 1d35dda..4360edc 100644 > --- a/kernel/timer.c > +++ b/kernel/timer.c > @@ -1646,9 +1646,7 @@ static int timer_cpu_notify(struct notifier_block *self, > case CPU_UP_PREPARE: > case CPU_UP_PREPARE_FROZEN: > err = init_timers_cpu(cpu); > - if (err < 0) > - return notifier_from_errno(err); > - break; > + return notifier_from_errno(err); > #ifdef CONFIG_HOTPLUG_CPU > case CPU_DEAD: > case CPU_DEAD_FROZEN: > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/kernel/timer.c b/kernel/timer.c index 1d35dda..4360edc 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -1646,9 +1646,7 @@ static int timer_cpu_notify(struct notifier_block *self, case CPU_UP_PREPARE: case CPU_UP_PREPARE_FROZEN: err = init_timers_cpu(cpu); - if (err < 0) - return notifier_from_errno(err); - break; + return notifier_from_errno(err); #ifdef CONFIG_HOTPLUG_CPU case CPU_DEAD: case CPU_DEAD_FROZEN:
Currently we are returning notifier_from_errno() from CPU_UP_PREPARE notifier when we detect an error while calling init_timers_cpu(). notifier_from_errno() already has enough checks within to do something similar. And so we can call it directly without checking if there was an error or not. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- kernel/timer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)