diff mbox series

dt-bindings: display: renesas,du: Make resets optional on R-Car H1

Message ID 2da75fd2e971dfab8dd05a2a28bb1d6d9cbe5adb.1619700420.git.geert+renesas@glider.be
State Superseded
Headers show
Series dt-bindings: display: renesas,du: Make resets optional on R-Car H1 | expand

Commit Message

Geert Uytterhoeven April 29, 2021, 12:47 p.m. UTC
The "resets" property is not present on R-Car Gen1 SoCs.
Supporting it would require migrating from renesas,cpg-clocks to
renesas,cpg-mssr.

Reflect this in the DT bindings by removing the global "required:
resets".  All SoCs that do have "resets" properties already have
SoC-specific rules making it required.

Fixes: 99d66127fad25ebb ("dt-bindings: display: renesas,du: Convert binding to YAML")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/display/renesas,du.yaml | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart April 29, 2021, 3:47 p.m. UTC | #1
Hi Geert,

Thank you for the patch.

On Thu, Apr 29, 2021 at 02:47:31PM +0200, Geert Uytterhoeven wrote:
> The "resets" property is not present on R-Car Gen1 SoCs.
> Supporting it would require migrating from renesas,cpg-clocks to
> renesas,cpg-mssr.
> 
> Reflect this in the DT bindings by removing the global "required:
> resets".  All SoCs that do have "resets" properties already have
> SoC-specific rules making it required.

Should we drop the

        resets:
	  maxItems: 1

from renesas,du-r8a7779 then ? And maybe the

  resets: true

in the general case ?

> Fixes: 99d66127fad25ebb ("dt-bindings: display: renesas,du: Convert binding to YAML")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/display/renesas,du.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> index 552a99ce4f1280d7..e955034da53b86e2 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> @@ -89,7 +89,6 @@ required:
>    - reg
>    - clocks
>    - interrupts
> -  - resets
>    - ports
>  
>  allOf:
Laurent Pinchart June 17, 2021, 1:57 a.m. UTC | #2
Hi Geert,

On Thu, Apr 29, 2021 at 06:47:06PM +0300, Laurent Pinchart wrote:
> On Thu, Apr 29, 2021 at 02:47:31PM +0200, Geert Uytterhoeven wrote:

> > The "resets" property is not present on R-Car Gen1 SoCs.

> > Supporting it would require migrating from renesas,cpg-clocks to

> > renesas,cpg-mssr.

> > 

> > Reflect this in the DT bindings by removing the global "required:

> > resets".  All SoCs that do have "resets" properties already have

> > SoC-specific rules making it required.

> 

> Should we drop the

> 

>         resets:

> 	  maxItems: 1

> 

> from renesas,du-r8a7779 then ? And maybe the

> 

>   resets: true

> 

> in the general case ?


Any opinion on this ?

> > Fixes: 99d66127fad25ebb ("dt-bindings: display: renesas,du: Convert binding to YAML")

> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > ---

> >  Documentation/devicetree/bindings/display/renesas,du.yaml | 1 -

> >  1 file changed, 1 deletion(-)

> > 

> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml

> > index 552a99ce4f1280d7..e955034da53b86e2 100644

> > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml

> > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml

> > @@ -89,7 +89,6 @@ required:

> >    - reg

> >    - clocks

> >    - interrupts

> > -  - resets

> >    - ports

> >  

> >  allOf:


-- 
Regards,

Laurent Pinchart
Geert Uytterhoeven June 17, 2021, 7:22 a.m. UTC | #3
Hi Laurent,

On Thu, Jun 17, 2021 at 3:57 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thu, Apr 29, 2021 at 06:47:06PM +0300, Laurent Pinchart wrote:
> > On Thu, Apr 29, 2021 at 02:47:31PM +0200, Geert Uytterhoeven wrote:
> > > The "resets" property is not present on R-Car Gen1 SoCs.
> > > Supporting it would require migrating from renesas,cpg-clocks to
> > > renesas,cpg-mssr.
> > >
> > > Reflect this in the DT bindings by removing the global "required:
> > > resets".  All SoCs that do have "resets" properties already have
> > > SoC-specific rules making it required.
> >
> > Should we drop the
> >
> >         resets:
> >         maxItems: 1
> >
> > from renesas,du-r8a7779 then ? And maybe the
> >
> >   resets: true
> >
> > in the general case ?
>
> Any opinion on this ?

Oops, I did reply to this on April 29, but accidentally dropped
all CCs, which made it disappear from your radar, too?

| R-Car H1 does have a reset controller, we just don't have support for
| it in the DT bindings and Linux driver yet.  So from that point of view
| it makes sense to keep it.
|
| Of course we can remove it, and re-add it later if we ever add support,
| as at that time we probably will want to change the bindings anyway
| to make it required again.

And you replied on April 30, also in private:

|> R-Car H1 does have a reset controller, we just don't have support for
| > it in the DT bindings and Linux driver yet.  So from that point of view
| > it makes sense to keep it.
|
| Not sure what we would "keep", given that there's no reset controller
| available :-)
|
| > Of course we can remove it, and re-add it later if we ever add support,
| > as at that time we probably will want to change the bindings anyway
| > to make it required again.
|
| Let's not bother. I doubt H1 will get support for a reset controller as
| that's an old platform, and the DT bindings thus don't matter too much.
| I'll take this patch as-is.
|
| Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > > Fixes: 99d66127fad25ebb ("dt-bindings: display: renesas,du: Convert binding to YAML")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  Documentation/devicetree/bindings/display/renesas,du.yaml | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > index 552a99ce4f1280d7..e955034da53b86e2 100644
> > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > @@ -89,7 +89,6 @@ required:
> > >    - reg
> > >    - clocks
> > >    - interrupts
> > > -  - resets
> > >    - ports
> > >
> > >  allOf:

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
index 552a99ce4f1280d7..e955034da53b86e2 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.yaml
+++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
@@ -89,7 +89,6 @@  required:
   - reg
   - clocks
   - interrupts
-  - resets
   - ports
 
 allOf: