diff mbox series

[v4,03/10] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3568

Message ID 20210429081151.17558-4-cl@rock-chips.com
State Superseded
Headers show
Series arm64: dts: rockchip: add basic dtsi/dts files for RK3568 SoC | expand

Commit Message

cl April 29, 2021, 8:11 a.m. UTC
From: Liang Chen <cl@rock-chips.com>

add "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc" for mmc nodes on
a rk3568 platform to rockchip-dw-mshc.yaml.

Signed-off-by: Liang Chen <cl@rock-chips.com>
---
 .../devicetree/bindings/mmc/rockchip-dw-mshc.yaml        | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Rob Herring (Arm) April 30, 2021, 9:13 p.m. UTC | #1
On Thu, Apr 29, 2021 at 04:11:44PM +0800, cl@rock-chips.com wrote:
> From: Liang Chen <cl@rock-chips.com>

> 

> add "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc" for mmc nodes on

> a rk3568 platform to rockchip-dw-mshc.yaml.

> 

> Signed-off-by: Liang Chen <cl@rock-chips.com>

> ---

>  .../devicetree/bindings/mmc/rockchip-dw-mshc.yaml        | 9 +--------

>  1 file changed, 1 insertion(+), 8 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

> index 3762f1c8de96..eaa3b0ef24f6 100644

> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

> @@ -29,21 +29,14 @@ properties:

>        - const: rockchip,rk3288-dw-mshc

>        - items:

>            - enum:

> -            # for Rockchip PX30

>                - rockchip,px30-dw-mshc

> -            # for Rockchip RK3036

>                - rockchip,rk3036-dw-mshc

> -            # for Rockchip RK322x

>                - rockchip,rk3228-dw-mshc

> -            # for Rockchip RK3308

>                - rockchip,rk3308-dw-mshc

> -            # for Rockchip RK3328

>                - rockchip,rk3328-dw-mshc

> -            # for Rockchip RK3368

>                - rockchip,rk3368-dw-mshc

> -            # for Rockchip RK3399

>                - rockchip,rk3399-dw-mshc

> -            # for Rockchip RV1108


I find these comments redundant, so I'm fine with the change. But please 
state why you are removing them in the commit msg.

Acked-by: Rob Herring <robh@kernel.org>


> +              - rockchip,rk3568-dw-mshc

>                - rockchip,rv1108-dw-mshc

>            - const: rockchip,rk3288-dw-mshc

>  

> -- 

> 2.17.1

> 

> 

>
Ulf Hansson May 11, 2021, 10:56 a.m. UTC | #2
On Thu, 29 Apr 2021 at 10:12, <cl@rock-chips.com> wrote:
>

> From: Liang Chen <cl@rock-chips.com>

>

> add "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc" for mmc nodes on

> a rk3568 platform to rockchip-dw-mshc.yaml.

>

> Signed-off-by: Liang Chen <cl@rock-chips.com>


Applied for next (and by amending the commit message according to
Rob's suggestion), thanks!

Kind regards
Uffe


> ---

>  .../devicetree/bindings/mmc/rockchip-dw-mshc.yaml        | 9 +--------

>  1 file changed, 1 insertion(+), 8 deletions(-)

>

> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

> index 3762f1c8de96..eaa3b0ef24f6 100644

> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

> @@ -29,21 +29,14 @@ properties:

>        - const: rockchip,rk3288-dw-mshc

>        - items:

>            - enum:

> -            # for Rockchip PX30

>                - rockchip,px30-dw-mshc

> -            # for Rockchip RK3036

>                - rockchip,rk3036-dw-mshc

> -            # for Rockchip RK322x

>                - rockchip,rk3228-dw-mshc

> -            # for Rockchip RK3308

>                - rockchip,rk3308-dw-mshc

> -            # for Rockchip RK3328

>                - rockchip,rk3328-dw-mshc

> -            # for Rockchip RK3368

>                - rockchip,rk3368-dw-mshc

> -            # for Rockchip RK3399

>                - rockchip,rk3399-dw-mshc

> -            # for Rockchip RV1108

> +              - rockchip,rk3568-dw-mshc

>                - rockchip,rv1108-dw-mshc

>            - const: rockchip,rk3288-dw-mshc

>

> --

> 2.17.1

>

>

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
index 3762f1c8de96..eaa3b0ef24f6 100644
--- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
+++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
@@ -29,21 +29,14 @@  properties:
       - const: rockchip,rk3288-dw-mshc
       - items:
           - enum:
-            # for Rockchip PX30
               - rockchip,px30-dw-mshc
-            # for Rockchip RK3036
               - rockchip,rk3036-dw-mshc
-            # for Rockchip RK322x
               - rockchip,rk3228-dw-mshc
-            # for Rockchip RK3308
               - rockchip,rk3308-dw-mshc
-            # for Rockchip RK3328
               - rockchip,rk3328-dw-mshc
-            # for Rockchip RK3368
               - rockchip,rk3368-dw-mshc
-            # for Rockchip RK3399
               - rockchip,rk3399-dw-mshc
-            # for Rockchip RV1108
+              - rockchip,rk3568-dw-mshc
               - rockchip,rv1108-dw-mshc
           - const: rockchip,rk3288-dw-mshc