| Message ID | 20210419165323.v1.1.I9f9e8bcc849d91c1bb588a5181317c3e2ad48461@changeid |
|---|---|
| State | Accepted |
| Commit | 8faca89c34eb1af9dba5069bddd144e95d6b96d3 |
| Headers | show |
| Series | [v1] Bluetooth: Fix the HCI to MGMT status conversion table | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=469907 ---Test result--- ############################## Test: CheckPatch - PASS ############################## Test: CheckGitLint - PASS ############################## Test: CheckBuildK - PASS ############################## Test: CheckTestRunner: Setup - PASS ############################## Test: CheckTestRunner: l2cap-tester - PASS Total: 40, Passed: 34 (85.0%), Failed: 0, Not Run: 6 ############################## Test: CheckTestRunner: bnep-tester - PASS Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: mgmt-tester - PASS Total: 416, Passed: 402 (96.6%), Failed: 0, Not Run: 14 ############################## Test: CheckTestRunner: rfcomm-tester - PASS Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: sco-tester - PASS Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: smp-tester - PASS Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: userchan-tester - PASS Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
Ping for attention, thanks. On Mon, Apr 19, 2021 at 4:53 PM Yu Liu <yudiliu@google.com> wrote: > > 0x2B, 0x31 and 0x33 are reserved for future use but were not present in > the HCI to MGMT conversion table, this caused the conversion to be > incorrect for the HCI status code greater than 0x2A. > > Reviewed-by: Miao-chen Chou <mcchou@chromium.org> > Signed-off-by: Yu Liu <yudiliu@google.com> > --- > > Changes in v1: > - Initial change > > net/bluetooth/mgmt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > index 40f75b8e1416..b44e19c69c44 100644 > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -252,12 +252,15 @@ static const u8 mgmt_status_table[] = { > MGMT_STATUS_TIMEOUT, /* Instant Passed */ > MGMT_STATUS_NOT_SUPPORTED, /* Pairing Not Supported */ > MGMT_STATUS_FAILED, /* Transaction Collision */ > + MGMT_STATUS_FAILED, /* Reserved for future use */ > MGMT_STATUS_INVALID_PARAMS, /* Unacceptable Parameter */ > MGMT_STATUS_REJECTED, /* QoS Rejected */ > MGMT_STATUS_NOT_SUPPORTED, /* Classification Not Supported */ > MGMT_STATUS_REJECTED, /* Insufficient Security */ > MGMT_STATUS_INVALID_PARAMS, /* Parameter Out Of Range */ > + MGMT_STATUS_FAILED, /* Reserved for future use */ > MGMT_STATUS_BUSY, /* Role Switch Pending */ > + MGMT_STATUS_FAILED, /* Reserved for future use */ > MGMT_STATUS_FAILED, /* Slot Violation */ > MGMT_STATUS_FAILED, /* Role Switch Failed */ > MGMT_STATUS_INVALID_PARAMS, /* EIR Too Large */ > -- > 2.31.1.368.gbe11c130af-goog >
Hi Yu, > 0x2B, 0x31 and 0x33 are reserved for future use but were not present in > the HCI to MGMT conversion table, this caused the conversion to be > incorrect for the HCI status code greater than 0x2A. > > Reviewed-by: Miao-chen Chou <mcchou@chromium.org> > Signed-off-by: Yu Liu <yudiliu@google.com> > --- > > Changes in v1: > - Initial change > > net/bluetooth/mgmt.c | 3 +++ > 1 file changed, 3 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 40f75b8e1416..b44e19c69c44 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -252,12 +252,15 @@ static const u8 mgmt_status_table[] = { MGMT_STATUS_TIMEOUT, /* Instant Passed */ MGMT_STATUS_NOT_SUPPORTED, /* Pairing Not Supported */ MGMT_STATUS_FAILED, /* Transaction Collision */ + MGMT_STATUS_FAILED, /* Reserved for future use */ MGMT_STATUS_INVALID_PARAMS, /* Unacceptable Parameter */ MGMT_STATUS_REJECTED, /* QoS Rejected */ MGMT_STATUS_NOT_SUPPORTED, /* Classification Not Supported */ MGMT_STATUS_REJECTED, /* Insufficient Security */ MGMT_STATUS_INVALID_PARAMS, /* Parameter Out Of Range */ + MGMT_STATUS_FAILED, /* Reserved for future use */ MGMT_STATUS_BUSY, /* Role Switch Pending */ + MGMT_STATUS_FAILED, /* Reserved for future use */ MGMT_STATUS_FAILED, /* Slot Violation */ MGMT_STATUS_FAILED, /* Role Switch Failed */ MGMT_STATUS_INVALID_PARAMS, /* EIR Too Large */