| Message ID | 1619347376-56140-1-git-send-email-jiapeng.chong@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | net: davicom: Remove redundant assignment to ret | expand |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 25 Apr 2021 18:42:56 +0800 you wrote: > Variable ret is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed. > > Cleans up the following clang-analyzer warning: > > drivers/net/ethernet/davicom/dm9000.c:1527:5: warning: Value stored to > 'ret' is never read [clang-analyzer-deadcode.DeadStores]. > > [...] Here is the summary with links: - net: davicom: Remove redundant assignment to ret https://git.kernel.org/netdev/net-next/c/9176e3802719 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index 8a9096a..e0c0349 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -1524,7 +1524,6 @@ static struct dm9000_plat_data *dm9000_parse_dt(struct device *dev) if (ret) { dev_err(db->dev, "irq %d cannot set wakeup (%d)\n", db->irq_wake, ret); - ret = 0; } else { irq_set_irq_wake(db->irq_wake, 0); db->wake_supported = 1;
Variable ret is set to zero but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Cleans up the following clang-analyzer warning: drivers/net/ethernet/davicom/dm9000.c:1527:5: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/net/ethernet/davicom/dm9000.c | 1 - 1 file changed, 1 deletion(-)