Message ID | 20210419145435.14083-1-alex.bennee@linaro.org |
---|---|
Headers | show |
Series | testing/next (hexagon/tricore/test cc) | expand |
Patchew URL: https://patchew.org/QEMU/20210419145435.14083-1-alex.bennee@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210419145435.14083-1-alex.bennee@linaro.org Subject: [PATCH for post 6.0 v1 00/25] testing/next (hexagon/tricore/test cc) === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210412044644.55083-1-crosa@redhat.com -> patchew/20210412044644.55083-1-crosa@redhat.com * [new tag] patchew/20210419145435.14083-1-alex.bennee@linaro.org -> patchew/20210419145435.14083-1-alex.bennee@linaro.org Switched to a new branch 'test' 577249a tests/tcg/tricore: Add muls test 5ef297b tests/tcg/tricore: Add msub test 60d2b3d tests/tcg/tricore: Add madd test e10597f tests/tcg/tricore: Add ftoi test a00bef9 tests/tcg/tricore: Add fmul test 2c65e8a tests/tcg/tricore: Add fadd test 7be3f15 tests/tcg/tricore: Add dvstep test 2749026 tests/tcg/tricore: Add clz test 40bbef5 tests/tcg/tricore: Add bmerge test 56f8362 tests/tcg/tricore: Add macros to create tests and first test 'abs' 1ac43af configure: Emit HOST_CC to config-host.mak 0fe19d9 tests/tcg/tricore: Add build infrastructure 5793db7 hw/tricore: Add testdevice for tests in tests/tcg/ 5c35bd9 tests/tcg: Run timeout cmds using --foreground 3c36b27 tests/tcg: Add docker_as and docker_ld cmds bc285a6 tests/docker: Added libbpf library to the docker files. 7326208 tests/tcg: don't iterate through other arch compilers 2a78f78 gitlab: add build-user-hexagon test 7278054 tests/tcg: Use Hexagon Docker image 73903c8 docker: Add Hexagon image 2baa96d tests/docker: add "fetch" sub-command e654d76 tests/docker: allow "update" to add the current user 57ff9bc tests/docker: make executable an optional argument to "update" 25c2969 tests/docker: fix copying of executable in "update" 77f7328 checkpatch: Fix use of uninitialized value === OUTPUT BEGIN === 1/25 Checking commit 77f7328cc4aa (checkpatch: Fix use of uninitialized value) 2/25 Checking commit 25c296904fd8 (tests/docker: fix copying of executable in "update") 3/25 Checking commit 57ff9bce683b (tests/docker: make executable an optional argument to "update") 4/25 Checking commit e654d7663890 (tests/docker: allow "update" to add the current user) 5/25 Checking commit 2baa96d796e7 (tests/docker: add "fetch" sub-command) 6/25 Checking commit 73903c8e6a47 (docker: Add Hexagon image) WARNING: line over 80 characters #203: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63: + -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \ ERROR: line over 90 characters #230: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90: + CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ ERROR: line over 90 characters #267: FILE: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127: + CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ total: 2 errors, 1 warnings, 221 lines checked Patch 6/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/25 Checking commit 727805463520 (tests/tcg: Use Hexagon Docker image) 8/25 Checking commit 2a78f78e1f07 (gitlab: add build-user-hexagon test) 9/25 Checking commit 732620837934 (tests/tcg: don't iterate through other arch compilers) 10/25 Checking commit bc285a619930 (tests/docker: Added libbpf library to the docker files.) 11/25 Checking commit 3c36b274bb6e (tests/tcg: Add docker_as and docker_ld cmds) 12/25 Checking commit 5c35bd9924d9 (tests/tcg: Run timeout cmds using --foreground) 13/25 Checking commit 5793db7a034e (hw/tricore: Add testdevice for tests in tests/tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 152 lines checked Patch 13/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/25 Checking commit 0fe19d907c2b (tests/tcg/tricore: Add build infrastructure) 15/25 Checking commit 1ac43af60bb2 (configure: Emit HOST_CC to config-host.mak) 16/25 Checking commit 56f8362be549 (tests/tcg/tricore: Add macros to create tests and first test 'abs') WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #67: FILE: tests/tcg/tricore/macros.h:2: +#define LI(reg, val) \ + mov.u reg, lo:val; \ + movh DREG_TEMP_LI, up:val; \ + or reg, reg, DREG_TEMP_LI; \ + ERROR: spaces required around that ':' (ctx:VxV) #68: FILE: tests/tcg/tricore/macros.h:3: + mov.u reg, lo:val; \ ^ ERROR: spaces required around that ':' (ctx:VxV) #69: FILE: tests/tcg/tricore/macros.h:4: + movh DREG_TEMP_LI, up:val; \ ^ ERROR: spaces required around that '%' (ctx:WxV) #75: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #75: FILE: tests/tcg/tricore/macros.h:10: +#define DREG_RS1 %d0 ERROR: spaces required around that '%' (ctx:WxV) #76: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #76: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_CALC_RESULT %d1 ERROR: spaces required around that '%' (ctx:WxV) #77: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ^ ERROR: Macros with complex values should be enclosed in parenthesis #77: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_TEMP_LI %d10 ERROR: spaces required around that '%' (ctx:WxV) #78: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ^ ERROR: Macros with complex values should be enclosed in parenthesis #78: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_TEMP %d11 ERROR: spaces required around that '%' (ctx:WxV) #79: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ^ ERROR: Macros with complex values should be enclosed in parenthesis #79: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_TEST_NUM %d14 ERROR: spaces required around that '%' (ctx:WxV) #80: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #80: FILE: tests/tcg/tricore/macros.h:15: +#define DREG_CORRECT_RESULT %d15 ERROR: spaces required around that '%' (ctx:WxV) #82: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ^ ERROR: Macros with complex values should be enclosed in parenthesis #82: FILE: tests/tcg/tricore/macros.h:17: +#define DREG_DEV_ADDR %a15 ERROR: Macros with multiple statements should be enclosed in a do - while loop #85: FILE: tests/tcg/tricore/macros.h:20: +#define TEST_CASE(num, testreg, correct, code...) \ +test_ ## num: \ + code; \ + LI(DREG_CORRECT_RESULT, correct) \ + mov DREG_TEST_NUM, num; \ + jne testreg, DREG_CORRECT_RESULT, fail \ + ERROR: spaces required around that ':' (ctx:VxE) #86: FILE: tests/tcg/tricore/macros.h:21: +test_ ## num: \ ^ WARNING: Block comments use a leading /* on a separate line #92: FILE: tests/tcg/tricore/macros.h:27: +/* Actual test case type ERROR: Macros with multiple statements should be enclosed in a do - while loop #104: FILE: tests/tcg/tricore/macros.h:39: +#define TEST_PASSFAIL \ + j pass; \ +fail: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j fail; \ +pass: \ + LI(DREG_TEMP, TESTDEV_ADDR) \ + mov.a DREG_DEV_ADDR, DREG_TEMP; \ + mov DREG_TEST_NUM, 0; \ + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ + debug; \ + j pass; ERROR: space prohibited before open square bracket '[' #109: FILE: tests/tcg/tricore/macros.h:44: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ ERROR: space prohibited before open square bracket '[' #116: FILE: tests/tcg/tricore/macros.h:51: + st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\ total: 22 errors, 2 warnings, 80 lines checked Patch 16/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/25 Checking commit 40bbef582452 (tests/tcg/tricore: Add bmerge test) ERROR: spaces required around that '%' (ctx:WxV) #38: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #38: FILE: tests/tcg/tricore/macros.h:11: +#define DREG_RS2 %d1 ERROR: spaces required around that '%' (ctx:WxV) #40: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ^ ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: tests/tcg/tricore/macros.h:13: +#define DREG_CALC_PSW %d2 ERROR: spaces required around that '%' (ctx:WxV) #41: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ^ ERROR: Macros with complex values should be enclosed in parenthesis #41: FILE: tests/tcg/tricore/macros.h:14: +#define DREG_CORRECT_PSW %d3 ERROR: spaces required around that ':' (ctx:VxE) #50: FILE: tests/tcg/tricore/macros.h:31: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #81: new file mode 100644 total: 7 errors, 1 warnings, 58 lines checked Patch 17/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/25 Checking commit 2749026f4db4 (tests/tcg/tricore: Add clz test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 total: 0 errors, 1 warnings, 34 lines checked Patch 18/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/25 Checking commit 7be3f1510885 (tests/tcg/tricore: Add dvstep test) ERROR: spaces required around that '%' (ctx:WxV) #51: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #51: FILE: tests/tcg/tricore/macros.h:22: +#define EREG_RS1 %e6 ERROR: spaces required around that '%' (ctx:WxV) #52: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ^ ERROR: Macros with complex values should be enclosed in parenthesis #52: FILE: tests/tcg/tricore/macros.h:23: +#define EREG_RS1_LO %d6 ERROR: spaces required around that '%' (ctx:WxV) #53: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ^ ERROR: Macros with complex values should be enclosed in parenthesis #53: FILE: tests/tcg/tricore/macros.h:24: +#define EREG_RS1_HI %d7 ERROR: spaces required around that '%' (ctx:WxV) #54: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #54: FILE: tests/tcg/tricore/macros.h:25: +#define EREG_RS2 %e8 ERROR: spaces required around that '%' (ctx:WxV) #55: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #55: FILE: tests/tcg/tricore/macros.h:26: +#define EREG_RS2_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #56: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #56: FILE: tests/tcg/tricore/macros.h:27: +#define EREG_RS2_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #57: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #57: FILE: tests/tcg/tricore/macros.h:28: +#define EREG_CALC_RESULT %e8 ERROR: spaces required around that '%' (ctx:WxV) #58: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ^ ERROR: Macros with complex values should be enclosed in parenthesis #58: FILE: tests/tcg/tricore/macros.h:29: +#define EREG_CALC_RESULT_HI %d9 ERROR: spaces required around that '%' (ctx:WxV) #59: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ^ ERROR: Macros with complex values should be enclosed in parenthesis #59: FILE: tests/tcg/tricore/macros.h:30: +#define EREG_CALC_RESULT_LO %d8 ERROR: spaces required around that '%' (ctx:WxV) #60: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ^ ERROR: Macros with complex values should be enclosed in parenthesis #60: FILE: tests/tcg/tricore/macros.h:31: +#define EREG_CORRECT_RESULT_LO %d0 ERROR: spaces required around that '%' (ctx:WxV) #61: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ^ ERROR: Macros with complex values should be enclosed in parenthesis #61: FILE: tests/tcg/tricore/macros.h:32: +#define EREG_CORRECT_RESULT_HI %d1 ERROR: spaces required around that ':' (ctx:VxE) #71: FILE: tests/tcg/tricore/macros.h:43: +test_ ## num: \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #98: new file mode 100644 total: 23 errors, 1 warnings, 76 lines checked Patch 19/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/25 Checking commit 2c65e8abba3c (tests/tcg/tricore: Add fadd test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 30 lines checked Patch 20/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/25 Checking commit a00bef9b2eb0 (tests/tcg/tricore: Add fmul test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 22 lines checked Patch 21/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/25 Checking commit e10597f38ece (tests/tcg/tricore: Add ftoi test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 37 lines checked Patch 22/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/25 Checking commit 60d2b3d2d9b2 (tests/tcg/tricore: Add madd test) ERROR: spaces required around that '%' (ctx:WxV) #51: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 ^ ERROR: Macros with complex values should be enclosed in parenthesis #51: FILE: tests/tcg/tricore/macros.h:12: +#define DREG_RS3 %d4 WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #80: new file mode 100644 total: 2 errors, 1 warnings, 55 lines checked Patch 23/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/25 Checking commit 5ef297b49088 (tests/tcg/tricore: Add msub test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 23 lines checked Patch 24/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/25 Checking commit 577249a8a4a1 (tests/tcg/tricore: Add muls test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 23 lines checked Patch 25/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210419145435.14083-1-alex.bennee@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com