diff mbox series

[29/40] drm/amd/amdgpu/amdgpu_fence: Provide description for 'sched_score'

Message ID 20210416143725.2769053-30-lee.jones@linaro.org
State Accepted
Commit b16cc4bb1abbe3c725228f4020f9ebd8ea1d1188
Headers show
Series Rid W=1 warnings from GPU! | expand

Commit Message

Lee Jones April 16, 2021, 2:37 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:444: warning: Function parameter or member 'sched_score' not described in 'amdgpu_fence_driver_init_ring'

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Jerome Glisse <glisse@freedesktop.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.27.0

Comments

Christian König April 16, 2021, 3:52 p.m. UTC | #1
Am 16.04.21 um 16:37 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:444: warning: Function parameter or member 'sched_score' not described in 'amdgpu_fence_driver_init_ring'
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> index 47ea468596184..30772608eac6c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> @@ -434,6 +434,7 @@ int amdgpu_fence_driver_start_ring(struct amdgpu_ring *ring,
>    *
>    * @ring: ring to init the fence driver on
>    * @num_hw_submission: number of entries on the hardware queue
> + * @sched_score: optional score atomic shared with other schedulers
>    *
>    * Init the fence driver for the requested ring (all asics).
>    * Helper function for amdgpu_fence_driver_init().
Alex Deucher April 20, 2021, 11:57 p.m. UTC | #2
Applied.  Thanks!

Alex

On Fri, Apr 16, 2021 at 11:52 AM Christian König
<christian.koenig@amd.com> wrote:
>

> Am 16.04.21 um 16:37 schrieb Lee Jones:

> > Fixes the following W=1 kernel build warning(s):

> >

> >   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:444: warning: Function parameter or member 'sched_score' not described in 'amdgpu_fence_driver_init_ring'

> >

> > Cc: Alex Deucher <alexander.deucher@amd.com>

> > Cc: "Christian König" <christian.koenig@amd.com>

> > Cc: David Airlie <airlied@linux.ie>

> > Cc: Daniel Vetter <daniel@ffwll.ch>

> > Cc: Sumit Semwal <sumit.semwal@linaro.org>

> > Cc: Jerome Glisse <glisse@freedesktop.org>

> > Cc: amd-gfx@lists.freedesktop.org

> > Cc: dri-devel@lists.freedesktop.org

> > Cc: linux-media@vger.kernel.org

> > Cc: linaro-mm-sig@lists.linaro.org

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

>

> Reviewed-by: Christian König <christian.koenig@amd.com>

>

> > ---

> >   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +

> >   1 file changed, 1 insertion(+)

> >

> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c

> > index 47ea468596184..30772608eac6c 100644

> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c

> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c

> > @@ -434,6 +434,7 @@ int amdgpu_fence_driver_start_ring(struct amdgpu_ring *ring,

> >    *

> >    * @ring: ring to init the fence driver on

> >    * @num_hw_submission: number of entries on the hardware queue

> > + * @sched_score: optional score atomic shared with other schedulers

> >    *

> >    * Init the fence driver for the requested ring (all asics).

> >    * Helper function for amdgpu_fence_driver_init().

>

> _______________________________________________

> amd-gfx mailing list

> amd-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
index 47ea468596184..30772608eac6c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
@@ -434,6 +434,7 @@  int amdgpu_fence_driver_start_ring(struct amdgpu_ring *ring,
  *
  * @ring: ring to init the fence driver on
  * @num_hw_submission: number of entries on the hardware queue
+ * @sched_score: optional score atomic shared with other schedulers
  *
  * Init the fence driver for the requested ring (all asics).
  * Helper function for amdgpu_fence_driver_init().